billing/worker/subscriptionsync/service/reconciler/patch_test.go

package reconciler

import (
	"testing"

	"github.com/alpacahq/alpacadecimal"
	"github.com/stretchr/testify/require"

	"github.com/openmeterio/openmeter/openmeter/billing/worker/subscriptionsync/service/persistedstate"
	"github.com/openmeterio/openmeter/openmeter/billing/worker/subscriptionsync/service/targetstate"
	"github.com/openmeterio/openmeter/openmeter/productcatalog"
	"github.com/openmeterio/openmeter/openmeter/subscription"
	"github.com/openmeterio/openmeter/pkg/featuregate"
)

func TestPatchCollectionRouterResolveDefaultCollection(t *testing.T) {
	t.Parallel()

	flatRateCard := &productcatalog.FlatFeeRateCard{
		RateCardMeta: productcatalog.RateCardMeta{
			Key: "flat",
			Price: productcatalog.NewPriceFrom(productcatalog.FlatPrice{
				Amount:      alpacadecimal.NewFromInt(100),
				PaymentTerm: productcatalog.InAdvancePaymentTerm,
			}),
		},
	}
	usageRateCard := &productcatalog.UsageBasedRateCard{
		RateCardMeta: productcatalog.RateCardMeta{
			Key:   "usage",
			Price: productcatalog.NewPriceFrom(productcatalog.UnitPrice{Amount: alpacadecimal.NewFromInt(1)}),
		},
	}

	testCases := []struct {
		name                    string
		settlementMode          productcatalog.SettlementMode
		enableCreditThenInvoice bool
		enableCredits           bool
		rateCard                productcatalog.RateCard
		expectedCollection      any
	}{
		{
			name:               "credit only flat fee uses flat fee charges",
			settlementMode:     productcatalog.CreditOnlySettlementMode,
			rateCard:           flatRateCard,
			expectedCollection: &flatFeeChargeCollection{},
			enableCredits:      true,
		},
		{
			name:               "credits disabled stays on invoice lines",
			settlementMode:     productcatalog.CreditOnlySettlementMode,
			enableCredits:      false,
			rateCard:           flatRateCard,
			expectedCollection: &lineInvoicePatchCollection{},
		},
		{
			name:               "credit only usage uses usage based charges",
			settlementMode:     productcatalog.CreditOnlySettlementMode,
			rateCard:           usageRateCard,
			expectedCollection: &usageBasedChargeCollection{},
			enableCredits:      true,
		},
		{
			name:                    "credit then invoice disabled stays on invoice lines",
			settlementMode:          productcatalog.CreditThenInvoiceSettlementMode,
			enableCredits:           true,
			enableCreditThenInvoice: false,
			rateCard:                flatRateCard,
			expectedCollection:      &lineInvoicePatchCollection{},
		},
		{
			name:                    "credit then invoice enabled flat fee uses flat fee charges",
			settlementMode:          productcatalog.CreditThenInvoiceSettlementMode,
			enableCredits:           true,
			enableCreditThenInvoice: true,
			rateCard:                flatRateCard,
			expectedCollection:      &flatFeeChargeCollection{},
		},
		{
			name:                    "credit then invoice enabled usage uses usage based charges",
			settlementMode:          productcatalog.CreditThenInvoiceSettlementMode,
			enableCredits:           true,
			enableCreditThenInvoice: true,
			rateCard:                usageRateCard,
			expectedCollection:      &usageBasedChargeCollection{},
		},
	}

	for _, tt := range testCases {
		t.Run(tt.name, func(t *testing.T) {
			t.Parallel()

			router, err := newPatchCollectionRouter(patchCollectionRouterConfig{
				capacity:                 1,
				invoices:                 persistedstate.Invoices{},
				creditThenInvoiceEnabled: tt.enableCreditThenInvoice,
				creditsEnabled:           tt.enableCredits,
				featureGate: featuregate.NewFeatureGateChecker(featuregate.NewNoop(), featuregate.Flags{
					featuregate.CtxKeyCredits: string(featuregate.CtxKeyCredits),
				}, map[featuregate.FeatureFlag]bool{featuregate.CtxKeyCredits: true}),
			})
			require.NoError(t, err)

			collection, err := router.ResolveDefaultCollection(testTargetStateItem(tt.settlementMode, tt.rateCard))
			require.NoError(t, err)
			require.IsType(t, tt.expectedCollection, collection)
		})
	}
}

func testTargetStateItem(settlementMode productcatalog.SettlementMode, rateCard productcatalog.RateCard) targetstate.StateItem {
	return targetstate.StateItem{
		SubscriptionItemWithPeriods: targetstate.SubscriptionItemWithPeriods{
			UniqueID: "item-1",
			SubscriptionItemView: subscription.SubscriptionItemView{
				Spec: subscription.SubscriptionItemSpec{
					CreateSubscriptionItemInput: subscription.CreateSubscriptionItemInput{
						CreateSubscriptionItemPlanInput: subscription.CreateSubscriptionItemPlanInput{
							PhaseKey: "phase-1",
							ItemKey:  "item-1",
							RateCard: rateCard,
						},
					},
				},
			},
		},
		Subscription: subscription.Subscription{
			SettlementMode: settlementMode,
		},
	}
}

func TestIsCreditEnabled(t *testing.T) {
	t.Parallel()

	t.Run("happy_path", func(t *testing.T) {
		router, err := newPatchCollectionRouter(patchCollectionRouterConfig{
			capacity:                 1,
			invoices:                 persistedstate.Invoices{},
			creditThenInvoiceEnabled: false,
			creditsEnabled:           true,
			featureGate: featuregate.NewFeatureGateChecker(featuregate.NewNoop(), featuregate.Flags{
				featuregate.CtxKeyCredits: string(featuregate.CtxKeyCredits),
			}, map[featuregate.FeatureFlag]bool{featuregate.CtxKeyCredits: true}),
		})
		require.NoError(t, err)

		enabled, err := router.isCreditsEnabled("test")
		require.NoError(t, err)
		require.True(t, enabled)
	})

	t.Run("no_feature_gate_client", func(t *testing.T) {
		_, err := newPatchCollectionRouter(patchCollectionRouterConfig{
			capacity:                 1,
			invoices:                 persistedstate.Invoices{},
			creditThenInvoiceEnabled: false,
			creditsEnabled:           true,
			featureGate: featuregate.NewFeatureGateChecker(nil, featuregate.Flags{
				featuregate.CtxKeyCredits: string(featuregate.CtxKeyCredits),
			}, map[featuregate.FeatureFlag]bool{featuregate.CtxKeyCredits: true}),
		})
		require.Error(t, err)
	})

	t.Run("credit_flag_disabled", func(t *testing.T) {
		router, err := newPatchCollectionRouter(patchCollectionRouterConfig{
			capacity:                 1,
			invoices:                 persistedstate.Invoices{},
			creditThenInvoiceEnabled: false,
			creditsEnabled:           false,
			featureGate: featuregate.NewFeatureGateChecker(featuregate.NewNoop(), featuregate.Flags{
				featuregate.CtxKeyCredits: string(featuregate.CtxKeyCredits),
			}, map[featuregate.FeatureFlag]bool{featuregate.CtxKeyCredits: true}),
		})
		require.NoError(t, err)

		enabled, err := router.isCreditsEnabled("test")
		require.NoError(t, err)
		require.False(t, enabled)
	})

	t.Run("credits_disabled_via_feature_flag", func(t *testing.T) {
		// creditsEnabled=true so the struct-level short-circuit doesn't fire;
		// the gate itself returns false for the mapped flag.
		router, err := newPatchCollectionRouter(patchCollectionRouterConfig{
			capacity:                 1,
			invoices:                 persistedstate.Invoices{},
			creditThenInvoiceEnabled: false,
			creditsEnabled:           true,
			featureGate: featuregate.NewFeatureGateChecker(
				alwaysFalseGate{},
				featuregate.Flags{featuregate.CtxKeyCredits: "my-credits-flag"},
				map[featuregate.FeatureFlag]bool{featuregate.CtxKeyCredits: true},
			),
		})
		require.NoError(t, err)

		enabled, err := router.isCreditsEnabled("test-ns")
		require.NoError(t, err)
		require.False(t, enabled)
	})
}

// alwaysFalseGate is a Gate implementation that always returns false.
type alwaysFalseGate struct{}

func (alwaysFalseGate) EvaluateBool(_, _ string, _ bool) (bool, error) {
	return false, nil
}