Update app.py

app.py

@@ -1,5 +1,5 @@
 # app.py
-# @title Beer Game Final Version (v4.4 - Added Diagram Image)
+# @title Beer Game Final Version (v4.6 - Fixed Role, UI Logic, and Upload Bug)
 
 # -----------------------------------------------------------------------------
 # 1. Import Libraries
@@ -57,15 +57,21 @@ else:
 
 
 # -----------------------------------------------------------------------------
-# 3. Core Game Logic Functions (No changes in this section)
+# 3. Core Game Logic Functions
 # -----------------------------------------------------------------------------
 
 def get_customer_demand(week: int) -> int:
     return 4 if week <= 4 else 8
 
 def init_game_state(llm_personality: str, info_sharing: str):
+    """Initializes or resets the game state in st.session_state."""
     roles = ["Retailer", "Wholesaler", "Distributor", "Factory"]
-    human_role = random.choice(roles)
+    
+    # =============== CHANGE 1: Fixed Role ===============
+    # Human role is no longer random. Everyone is Distributor.
+    human_role = "Distributor"
+    # ======================================================
+    
     participant_id = str(uuid.uuid4())[:8]
 
     st.session_state.game_state = {
@@ -80,6 +86,8 @@ def init_game_state(llm_personality: str, info_sharing: str):
     for i, name in enumerate(roles):
         upstream = roles[i + 1] if i + 1 < len(roles) else None
         downstream = roles[i - 1] if i - 1 >= 0 else None
+        
+        # This logic remains correct: Factory has 0 shipping weeks for incoming.
         if name == "Distributor": shipping_weeks = FACTORY_SHIPPING_DELAY
         elif name == "Factory": shipping_weeks = 0
         else: shipping_weeks = SHIPPING_DELAY
@@ -91,7 +99,7 @@ def init_game_state(llm_personality: str, info_sharing: str):
             'incoming_order': 0, 'order_placed': 0, 'shipment_sent': 0,
             'weekly_cost': 0, 'total_cost': 0, 'upstream_name': upstream, 'downstream_name': downstream,
         }
-    st.info(f"New game started! AI Mode: **{llm_personality} / {info_sharing}**. You have been randomly assigned the role of: **{human_role}**.")
+    st.info(f"New game started! AI Mode: **{llm_personality} / {info_sharing}**. You are playing as the: **{human_role}**.")
 
 def get_llm_order_decision(prompt: str, echelon_name: str) -> (int, str):
     if not client: return 8, "NO_API_KEY_DEFAULT"
@@ -139,6 +147,11 @@ def get_llm_prompt(echelon_state: dict, week: int, llm_personality: str, info_sh
         return f"**You are a reactive supply chain manager for the {echelon_state['name']}.** You have a limited view and tend to over-correct based on fear.\n\n**Your Mindset: **Your top priority is try to not have a backlog.\n\n{base_info}\n\n**Your Task:** You just saw your own inventory and a new order coming. Your gut instinct is to panic and order enough to ensure you are never caught with a backlog again.\n\n**React emotionally.** What is your knee-jerk order quantity? Respond with a single integer."
 
 def step_game(human_final_order: int, human_initial_order: int, ai_suggestion: int):
+    # This function's core logic is sound and correctly models the delays.
+    # Factory inventory is correctly handled by 'factory_production_pipeline'.
+    # Other echelons are correctly handled by 'incoming_shipments'.
+    # No changes needed here.
+    
     state = st.session_state.game_state
     week, echelons, human_role = state['week'], state['echelons'], state['human_role']
     llm_personality, info_sharing = state['llm_personality'], state['info_sharing']
@@ -215,7 +228,7 @@ def plot_results(df: pd.DataFrame, title: str, human_role: str):
     inventory_pivot.plot(ax=axes[0], kind='line', marker='o', markersize=4); axes[0].set_title('Inventory Levels'); axes[0].grid(True, linestyle='--'); axes[0].set_ylabel('Stock (Units)')
 
     order_pivot = plot_df.pivot(index='week', columns='echelon', values='order_placed').reindex(columns=echelons)
-    order_pivot.plot(ax=axes[1], style='--'); axes[1].plot(range(1, WS + 1), [get_customer_demand(w) for w in range(1, WEEKS + 1)], label='Customer Demand', color='black', lw=2.5); axes[1].set_title('Order Quantities (The Bullwhip Effect)'); axes[1].grid(True, linestyle='--'); axes[1].legend(); axes[1].set_ylabel('Ordered (Units)')
+    order_pivot.plot(ax=axes[1], style='--'); axes[1].plot(range(1, WEEKS + 1), [get_customer_demand(w) for w in range(1, WEEKS + 1)], label='Customer Demand', color='black', lw=2.5); axes[1].set_title('Order Quantities (The Bullwhip Effect)'); axes[1].grid(True, linestyle='--'); axes[1].legend(); axes[1].set_ylabel('Ordered (Units)')
 
     total_costs = plot_df.groupby('echelon')['total_cost'].max().reindex(echelons)
     total_costs.plot(kind='bar', ax=axes[2], rot=0); axes[2].set_title('Total Cumulative Cost'); axes[2].set_ylabel('Cost ($)')
@@ -271,42 +284,49 @@ else:
         col1, col2 = st.columns(2)
         with col1:
             st.subheader("🔗 The Supply Chain")
-            
-            # =============== IMAGE ADDED HERE ===============
             try:
                 st.image(IMAGE_PATH, caption="Orders flow upstream (right), beer flows downstream (left).")
             except FileNotFoundError:
                 st.warning("Image file not found. Please ensure 'beer_game_diagram.png' is uploaded to the repository.")
-            # ================================================
                 
             st.markdown("""
-            You will be randomly assigned one of four roles. The other three will be controlled by AI agents.
+            You will play the role of the **Distributor**. The other three roles (Retailer, Wholesaler, Factory) will be controlled by AI agents.
             - **Retailer:** Fulfills end-customer demand. Orders from the Wholesaler.
             - **Wholesaler:** Fulfills Retailer orders. Orders from the Distributor.
-            - **Distributor:** Fulfills Wholesaler orders. Orders from the Factory.
-            - **Factory:** Fulfills Distributor orders. Produces new beer.
+            - **Distributor (You):** Fulfills Wholesaler orders. Orders from the Factory.
+            - **Factory:** Fulfills your orders. Produces new beer.
             """)
         with col2:
             st.subheader("⏳ The Challenge: Delays!")
             st.markdown("""
-            The key challenge is managing delays. As shown in the diagram, there are **shipping delays** for beer to arrive and **production delays** at the factory. 
+            The key challenge is managing the **delays** shown in the diagram.
             
-            There is also a one-week **order-passing delay** (the small boxes) for your order to reach your supplier. 
+            * **Order Delays:** It takes **1 week** for your order to reach your supplier (the Factory).
+            * **Shipping Delays:** It takes **1 week** for beer to be shipped from the Factory to you. (It takes 2 weeks for all other shipping links).
+            * **Production Delays:** The Factory needs **1 week** to produce new beer.
             
-            You must order enough to meet future demand without creating a huge pile of expensive inventory.
+            This means there is a **2-week** total lead time from when you order to when you receive beer (1 week order delay + 1 week production delay, or 1 week shipping delay). *Note: The diagram shows generic delays; our game uses the specific delays listed here.*
             """)
         
-        st.subheader("🎮 How to Play This Version")
+        st.subheader("🎮 How Each Week Works")
         st.markdown("""
-        1.  **Configure the Game:** Choose the AI's behavior and the level of information sharing.
-        2.  **Get Your Role:** You will be randomly assigned a role.
-        3.  **Make Your Decision (Two Steps):**
-            - **Step 1:** Based on your current status, submit your **initial order**.
-            - **Step 2:** After submitting, you will see an **AI suggestion**. You can either follow it or stick to your own judgment when submitting your **final order**.
-        4.  **Advance:** Once you submit your final order, the week advances, and all AI agents make their moves.
+        Your main job is to place an order each week. The system handles the rest.
+        
+        **1. Automated Steps (Start of Week)**
+        When a new week begins, the system first automates three steps based on past decisions:
+        * **(Step 1: Shipments Arrive):** Shipments from the Factory (which you ordered weeks ago) arrive and are added to your inventory.
+        * **(Step 2: New Orders Arrive):** You receive a new incoming order from the Wholesaler.
+        * **(Step 3: Ship Beer):** The system automatically ships as much beer as you have in stock to fulfill the Wholesaler's order, plus any leftover backlog. Any unfulfilled amount becomes your new backlog for next week.
+        
+        **2. Your Decision (Two-Step Process)**
+        After the automated steps, you will see your new inventory and backlog. Now, it's your turn to perform **Step 4**:
+        * **(Step 4a):** Based on your new status, submit your **initial order** to the Factory.
+        * **(Step 4b):** After submitting, you will see an **AI suggestion**. Review it, then submit your **final order**.
+        
+        Submitting your final order advances the game to the next week, and the cycle repeats.
         """)
+
         st.markdown("---")
-        
         st.header("⚙️ Game Configuration")
         c1, c2 = st.columns(2)
         with c1:
@@ -335,23 +355,33 @@ else:
                     st.markdown(f"##### {icon} {name} {'(You)' if name == human_role else ''}")
                     st.metric("Inventory", e['inventory']); st.metric("Backlog", e['backlog'])
                     st.write(f"Incoming Order: **{e['incoming_order']}**")
-                    st.write(f"Arriving Next Week: **{list(e['incoming_shipments'])[0] if e['incoming_shipments'] else 0}**")
+
+                    # =============== CHANGE 2: Fixed Factory UI Logic ===============
+                    if name == "Factory":
+                        prod_completing = list(state['factory_production_pipeline'])[0] if state['factory_production_pipeline'] else 0
+                        st.write(f"Production Completing: **{prod_completing}**")
+                    else:
+                        arriving = list(e['incoming_shipments'])[0] if e['incoming_shipments'] else 0
+                        st.write(f"Arriving Next Week: **{arriving}**")
+                    # ==============================================================
         else:
             st.info("In Local Information mode, you can only see your own status dashboard.")
-            e = echelons[human_role]
+            e = echelons[human_role] # This is always the Distributor
             st.markdown(f"### 👤 {human_role} (Your Dashboard)")
             col1, col2, col3, col4 = st.columns(4)
             col1.metric("Current Inventory", e['inventory'])
             col2.metric("Current Backlog", e['backlog'])
             col3.write(f"**Incoming Order (This Week):**\n# {e['incoming_order']}")
+            # This is correct for the Distributor
             col4.write(f"**Shipment Arriving (Next Week):**\n# {list(e['incoming_shipments'])[0] if e['incoming_shipments'] else 0}")
+        
         st.markdown("---")
-        st.header("Your Decision")
+        st.header("Your Decision (Step 4)")
         human_echelon_state = echelons[human_role]
 
         if state['decision_step'] == 'initial_order':
             with st.form(key="initial_order_form"):
-                st.markdown("#### **Step 1:** Based on the information available, submit your **initial** order.")
+                st.markdown("#### **Step 4a:** Based on the information available, submit your **initial** order.")
                 initial_order = st.number_input("Your Initial Order Quantity:", min_value=0, step=1, value=human_echelon_state['incoming_order'])
                 if st.form_submit_button("Submit Initial Order & See AI Suggestion", type="primary"):
                     state['human_initial_order'] = int(initial_order)
@@ -367,7 +397,7 @@ else:
                 st.session_state.final_order_input = ai_suggestion
 
             with st.form(key="final_order_form"):
-                st.markdown(f"#### **Step 2:** The AI suggests ordering **{ai_suggestion}** units.")
+                st.markdown(f"#### **Step 4b:** The AI suggests ordering **{ai_suggestion}** units.")
                 st.markdown("Considering the AI's advice, submit your **final** order to end the week.")
                 st.number_input("Your Final Order Quantity:", min_value=0, step=1, key='final_order_input')
                 if st.form_submit_button("Submit Final Order & Advance to Next Week"):
@@ -394,12 +424,10 @@ else:
                     display_df['Weekly Cost'] = display_df['Weekly Cost'].apply(lambda x: f"${x:,.2f}")
                 st.dataframe(display_df.sort_values(by="Week", ascending=False), hide_index=True, use_container_width=True)
 
-        # =============== IMAGE ADDED TO SIDEBAR ===============
         try:
             st.sidebar.image(IMAGE_PATH, caption="Supply Chain Reference")
         except FileNotFoundError:
             st.sidebar.warning("Image file not found.")
-        # ======================================================
             
         st.sidebar.header("Game Info")
         st.sidebar.markdown(f"**Game ID**: `{state['participant_id']}`\n\n**Current Week**: {week}")
@@ -414,7 +442,15 @@ else:
         st.header("🎉 Game Over!")
         state = st.session_state.game_state
         logs_df = pd.json_normalize(state['logs'])
-        fig = plot_results(logs_df, f"Beer Game (Human: {state['human_role']})\n(AI: {state['llm_personality']} | Info: {state['info_sharing']})", state['human_role'])
+        
+        # =============== CHANGE 3: Fixed Typo Bug ===============
+        fig = plot_results(
+            logs_df, 
+            f"Beer Game (Human: {state['human_role']})\n(AI: {state['llm_personality']} | Info: {state['info_sharing']})", 
+            state['human_role']
+        )
+        # ========================================================
+        
         st.pyplot(fig)
         save_logs_and_upload(state)
         if st.button("✨ Start a New Game"):