fix: robust conditional_download (handle query names, try mirrors, raise last error)

DeepFakeAI/utilities.py

@@ -160,15 +160,26 @@ def is_video(video_path : str) -> bool:
 
 
 def conditional_download(download_directory_path : str, urls : List[str]) -> None:
-	if not os.path.exists(download_directory_path):
-		os.makedirs(download_directory_path)
-	for url in urls:
-		download_file_path = os.path.join(download_directory_path, os.path.basename(url))
-		if not os.path.exists(download_file_path):
-			request = urllib.request.urlopen(url) # type: ignore[attr-defined]
-			total = int(request.headers.get('Content-Length', 0))
-			with tqdm(total = total, desc = wording.get('downloading'), unit = 'B', unit_scale = True, unit_divisor = 1024) as progress:
-				urllib.request.urlretrieve(url, download_file_path, reporthook = lambda count, block_size, total_size: progress.update(block_size)) # type: ignore[attr-defined]
+    if not os.path.exists(download_directory_path):
+        os.makedirs(download_directory_path)
+    last_error: Optional[Exception] = None
+    for url in urls:
+        # handle query strings when deriving filename
+        base_name = os.path.basename(url.split('?')[0])
+        download_file_path = os.path.join(download_directory_path, base_name)
+        if os.path.exists(download_file_path):
+            return
+        try:
+            request = urllib.request.urlopen(url)  # type: ignore[attr-defined]
+            total = int(request.headers.get('Content-Length', 0) or 0)
+            with tqdm(total = total, desc = wording.get('downloading'), unit = 'B', unit_scale = True, unit_divisor = 1024) as progress:
+                urllib.request.urlretrieve(url, download_file_path, reporthook = lambda count, block_size, total_size: progress.update(block_size))  # type: ignore[attr-defined]
+            return
+        except Exception as e:  # try next mirror
+            last_error = e
+            continue
+    if last_error:
+        raise last_error
 
 
 def resolve_relative_path(path : str) -> str: