Prioritize nested category structure check in check_user_has_category_data

app/smart_recommendation.py

@@ -171,33 +171,9 @@ class SmartBudgetRecommender:
                 {"headCategories.categories.category": category_id},
             ]
         
-        # Combine user and category conditions
-        for user_cond in user_conditions:
-            for cat_cond in category_conditions:
-                budget_query = {**user_cond, **cat_cond}
-                budget_count = self.db.budgets.count_documents(budget_query)
-                if budget_count > 0:
-                    print(f"✅ Found {budget_count} budget(s) for user {user_id} with category_id {category_id}")
-                    print(f"   Query that matched: {budget_query}")
-                    return True
-        
-        # Also try a more comprehensive query using $and and $or
-        try:
-            comprehensive_query = {
-                "$and": [
-                    {"$or": user_conditions},
-                    {"$or": category_conditions}
-                ]
-            }
-            budget_count = self.db.budgets.count_documents(comprehensive_query)
-            if budget_count > 0:
-                print(f"✅ Found {budget_count} budget(s) using comprehensive query for user {user_id} with category_id {category_id}")
-                return True
-        except Exception as e:
-            print(f"⚠️ Error with comprehensive query: {e}")
-        
-        # Additional check: Look for budgets with nested category arrays
-        # Some budgets might have categories nested in arrays like headCategories[].categories[]
+        # FIRST: Check nested structure (headCategories[].categories[].category) - most common case
+        # Budgets have structure: headCategories[].categories[].category (ObjectId)
+        print(f"🔍 Checking nested structure: headCategories[].categories[].category for category_id {category_id}")
         try:
             try:
                 category_objid = ObjectId(category_id)
@@ -205,15 +181,18 @@ class SmartBudgetRecommender:
                 category_objid = category_id
             
             # Try to find budgets with nested category structures
+            # Structure: headCategories[].categories[].category
             nested_query = {
                 "$and": [
                     {"$or": user_conditions},
                     {
                         "$or": [
-                            {"headCategories": {"$elemMatch": {"headCategory": category_objid}}},
-                            {"headCategories": {"$elemMatch": {"headCategory": category_id}}},
+                            # Check if category_id is in headCategories[].categories[].category
                             {"headCategories": {"$elemMatch": {"categories": {"$elemMatch": {"category": category_objid}}}}},
                             {"headCategories": {"$elemMatch": {"categories": {"$elemMatch": {"category": category_id}}}}},
+                            # Also check if category_id is a headCategory itself
+                            {"headCategories": {"$elemMatch": {"headCategory": category_objid}}},
+                            {"headCategories": {"$elemMatch": {"headCategory": category_id}}},
                         ]
                     }
                 ]
@@ -221,9 +200,40 @@ class SmartBudgetRecommender:
             nested_count = self.db.budgets.count_documents(nested_query)
             if nested_count > 0:
                 print(f"✅ Found {nested_count} budget(s) with nested category structure for user {user_id} with category_id {category_id}")
+                print(f"   Nested query matched: headCategories[].categories[].category = {category_id}")
                 return True
+            else:
+                print(f"🔍 Nested query found 0 budgets for category_id {category_id}")
         except Exception as e:
             print(f"⚠️ Error checking nested categories: {e}")
+            import traceback
+            traceback.print_exc()
+        
+        # SECOND: Combine user and category conditions (direct fields)
+        print(f"🔍 Checking direct category fields for category_id {category_id}")
+        for user_cond in user_conditions:
+            for cat_cond in category_conditions:
+                budget_query = {**user_cond, **cat_cond}
+                budget_count = self.db.budgets.count_documents(budget_query)
+                if budget_count > 0:
+                    print(f"✅ Found {budget_count} budget(s) for user {user_id} with category_id {category_id}")
+                    print(f"   Query that matched: {budget_query}")
+                    return True
+        
+        # THIRD: Also try a more comprehensive query using $and and $or
+        try:
+            comprehensive_query = {
+                "$and": [
+                    {"$or": user_conditions},
+                    {"$or": category_conditions}
+                ]
+            }
+            budget_count = self.db.budgets.count_documents(comprehensive_query)
+            if budget_count > 0:
+                print(f"✅ Found {budget_count} budget(s) using comprehensive query for user {user_id} with category_id {category_id}")
+                return True
+        except Exception as e:
+            print(f"⚠️ Error with comprehensive query: {e}")
         
         # Debug: Check if user has ANY budgets at all and what categories they have
         try: