Fix get_recommendation_for_category to generate recommendations when category_id is a budget _id

app/smart_recommendation.py

@@ -382,21 +382,86 @@ class SmartBudgetRecommender:
                             if budget_amount is None:
                                 budget_amount = budget_amount_from_budget
                             
-                            # Generate recommendation for this category using the budget amount
-                            return self._generate_single_recommendation(
-                                user_id, actual_category_id, category_name, 
-                                month, year, budget_amount, using_budget_amount_only=False
-                            )
+                            # Generate recommendation using the budget's data
+                            avg_expense = budget_amount
+                            monthly_values = [avg_expense]
+                            std_dev = avg_expense * 0.05
+                            months_analyzed = 1
+                            
+                            data = {
+                                "average_monthly": avg_expense,
+                                "total": avg_expense,
+                                "count": 1,
+                                "months_analyzed": months_analyzed,
+                                "std_dev": std_dev,
+                                "monthly_values": monthly_values,
+                            }
+                            
+                            confidence = self._calculate_confidence(data)
+                            
+                            # Get AI recommendation
+                            ai_result = self._get_ai_recommendation(category_name, data, avg_expense)
+                            if ai_result and ai_result.get("recommended_budget"):
+                                recommended_budget = ai_result.get("recommended_budget")
+                                reason = ai_result.get("reason", f"AI recommendation for {category_name}")
+                                action = ai_result.get("action")
+                            else:
+                                recommended_budget = avg_expense * 1.10
+                                reason = f"Based on your budget of {budget_amount:,.0f}, I recommend {recommended_budget:,.0f} to account for variability and inflation."
+                                action = "increase"
+                            
+                            return [BudgetRecommendation(
+                                category=category_name,
+                                category_id=actual_category_id,
+                                average_expense=round(avg_expense, 2),
+                                recommended_budget=round(recommended_budget or 0, 2),
+                                reason=reason,
+                                confidence=confidence,
+                                action=action
+                            )]
                         elif budget_amount_from_budget > 0:
                             # Budget exists but no categories - use budget name and amount
                             budget_name = budget_by_id.get("name", "Budget")
                             if budget_amount is None:
                                 budget_amount = budget_amount_from_budget
+                            
                             # Generate recommendation using budget name
-                            return self._generate_single_recommendation(
-                                user_id, category_id, budget_name,
-                                month, year, budget_amount, using_budget_amount_only=False
-                            )
+                            avg_expense = budget_amount
+                            monthly_values = [avg_expense]
+                            std_dev = avg_expense * 0.05
+                            months_analyzed = 1
+                            
+                            data = {
+                                "average_monthly": avg_expense,
+                                "total": avg_expense,
+                                "count": 1,
+                                "months_analyzed": months_analyzed,
+                                "std_dev": std_dev,
+                                "monthly_values": monthly_values,
+                            }
+                            
+                            confidence = self._calculate_confidence(data)
+                            
+                            # Get AI recommendation
+                            ai_result = self._get_ai_recommendation(budget_name, data, avg_expense)
+                            if ai_result and ai_result.get("recommended_budget"):
+                                recommended_budget = ai_result.get("recommended_budget")
+                                reason = ai_result.get("reason", f"AI recommendation for {budget_name}")
+                                action = ai_result.get("action")
+                            else:
+                                recommended_budget = avg_expense * 1.10
+                                reason = f"Based on your budget of {budget_amount:,.0f}, I recommend {recommended_budget:,.0f} to account for variability."
+                                action = "increase"
+                            
+                            return [BudgetRecommendation(
+                                category=budget_name,
+                                category_id=category_id,
+                                average_expense=round(avg_expense, 2),
+                                recommended_budget=round(recommended_budget or 0, 2),
+                                reason=reason,
+                                confidence=confidence,
+                                action=action
+                            )]
             except (ValueError, TypeError):
                 pass  # category_id is not a valid ObjectId, continue with normal check
         except Exception: