Match budgets by createdBy ObjectId

app/smart_recommendation.py

@@ -7,6 +7,7 @@ from typing import Dict, List
 
 import requests
 from dotenv import load_dotenv
+from bson import ObjectId
 
 from app.models import BudgetRecommendation, CategoryExpense
 
@@ -255,14 +256,15 @@ class SmartBudgetRecommender:
         We treat each budget document (e.g. \"Office Maintenance\", \"LOGICGO\")
         as a spending category and derive an \"average\" from its amounts.
         """
-        budgets = list(
-            self.db.budgets.find(
-                {
-                    "createdBy": user_id,
-                    "status": "OPEN",
-                }
-            )
-        )
+        # createdBy is stored as ObjectId in WalletSync, while user_id is a string.
+        # Try to cast to ObjectId; if it fails, fall back to matching the raw string.
+        query: Dict = {"status": "OPEN"}
+        try:
+            query["createdBy"] = ObjectId(user_id)
+        except Exception:
+            query["createdBy"] = user_id
+
+        budgets = list(self.db.budgets.find(query))
 
         if not budgets:
             return {}