Fix average_expense to use user-provided budget_amount and enhance OpenAI prompt to recommend decrease when budget is too high

app/smart_recommendation.py

@@ -374,6 +374,7 @@ class SmartBudgetRecommender:
                             category_name = self._get_category_name(actual_category_id)
                             
                             # PRIORITY: Use provided budget_amount if available, otherwise use budget's maxAmount
+                            # IMPORTANT: If user provided budget_amount, use it as the base for recommendation
                             if budget_amount is None or budget_amount <= 0:
                                 budget_max_amount = float(budget_by_id.get("maxAmount", 0) or 0)
                                 budget_spend_amount = float(budget_by_id.get("spendAmount", 0) or 0)
@@ -381,7 +382,8 @@ class SmartBudgetRecommender:
                             
                             # If we have a valid budget amount, generate recommendation
                             if budget_amount and budget_amount > 0:
-                                # Generate recommendation using the provided budget_amount (user's input)
+                                # CRITICAL: Use the provided budget_amount as average_expense
+                                # This is what the user wants to set, so recommendations should be based on this
                                 avg_expense = budget_amount
                                 monthly_values = [avg_expense]
                                 std_dev = avg_expense * 0.05
@@ -1445,19 +1447,31 @@ class SmartBudgetRecommender:
                 f"💰 USER'S BUDGET AMOUNT: The user has SET/PLANNED a budget of {avg_expense:,.2f} for this category.\n"
                 f"This is the budget amount the user wants to allocate - this is the ONLY data point available.\n"
                 f"There is NO spending history to analyze - this is a fresh budget.\n\n"
-                f"🎯 YOUR TASK: Provide a recommendation based on the user's budget amount of {avg_expense:,.2f}\n\n"
+                f"🎯 YOUR TASK: Provide an INTELLIGENT recommendation based on the user's budget amount of {avg_expense:,.2f}\n\n"
                 f"Your recommendation should be based on:\n"
                 f"  1. The user's provided budget amount: {avg_expense:,.2f} (this is what they want to set)\n"
                 f"  2. Category-specific knowledge (e.g., Food & Drinks inflation, Transport volatility)\n"
                 f"  3. General best practices (add 10-15% buffer for new budgets to account for variability)\n"
                 f"  4. Economic factors (inflation typically 2-5% annually, category-specific inflation)\n\n"
                 f"💡 KEY INSIGHT: The user has indicated they want to budget {avg_expense:,.2f} for this category.\n"
-                f"   - If this amount seems reasonable for the category, recommend keeping it or a small increase (5-10%)\n"
-                f"   - If this category typically requires more (e.g., Food & Drinks with inflation), recommend increase (10-20%)\n"
-                f"   - Always add a buffer for unexpected expenses and inflation\n\n"
+                f"   - ANALYZE if this amount is REASONABLE for the category:\n"
+                f"     * If the amount seems TOO LOW for the category → Recommend INCREASE (10-20%)\n"
+                f"     * If the amount seems TOO HIGH for the category → Recommend DECREASE (10-20%)\n"
+                f"     * If the amount seems REASONABLE → Recommend KEEP or small increase (5-10% buffer)\n"
+                f"   - Consider category-specific factors:\n"
+                f"     * Food & Drinks: Typically needs 10-15% buffer for inflation and variability\n"
+                f"     * Transport: May need 15-20% buffer due to fuel price volatility\n"
+                f"     * Entertainment: May need less buffer (5-10%) if amount is reasonable\n"
+                f"     * Utilities: Usually stable, 5-10% buffer is sufficient\n"
+                f"   - Use your knowledge about typical spending ranges for this category\n"
+                f"   - If user's amount is clearly excessive for the category, recommend DECREASE\n"
+                f"   - If user's amount is clearly insufficient, recommend INCREASE\n\n"
+                f"🚨 CRITICAL: DO NOT ALWAYS RECOMMEND INCREASE!\n"
+                f"   - If the user's budget amount ({avg_expense:,.2f}) is already generous for {category}, recommend DECREASE\n"
+                f"   - If the amount is reasonable, recommend KEEP with small buffer (5-10%)\n"
+                f"   - Only recommend INCREASE if the amount seems insufficient for the category\n\n"
                 f"DO NOT reference fake trends or historical patterns - this is a new budget!\n"
                 f"Recommend a budget that accounts for typical variability and inflation for this category.\n"
-                f"For new budgets, typically recommend 10-15% increase from the user's provided amount to create a safety buffer.\n"
             )
         else:
             # This is based on real historical data