Fix budget _id check logic and remove excessive debug logs

app/smart_recommendation.py

@@ -44,7 +44,7 @@ class SmartBudgetRecommender:
         # This ensures we only show recommendations for budgets the user actually created
         if not category_data:
             print(f"No budgets found for user_id: {user_id}, returning empty recommendations")
-            return []
+                return []
         
         recommendations: List[BudgetRecommendation] = []
 
@@ -84,7 +84,7 @@ class SmartBudgetRecommender:
                         elif std_dev > avg_expense * 0.05:
                             recommended_budget = avg_expense * 1.20
                             action = "increase"
-                        else:
+            else:
                             recommended_budget = avg_expense * 1.05
                             action = "increase"
                 
@@ -125,8 +125,6 @@ class SmartBudgetRecommender:
         Returns:
             True if user has previous data for this category, False otherwise
         """
-        print(f"🔍 check_user_has_category_data: Checking for user_id={user_id}, category_id={category_id}")
-        
         # FIRST: Check if category_id is actually a budget _id
         # If so, find the budget and check if it belongs to the user and has categories
         try:
@@ -136,14 +134,15 @@ class SmartBudgetRecommender:
                 budget_by_id = self.db.budgets.find_one({"_id": budget_id_objid})
                 if budget_by_id:
                     budget_created_by = budget_by_id.get("createdBy")
-                    # Check if this budget belongs to the user
-                    budget_user_match = (
-                        str(budget_created_by) == str(user_id) or 
-                        budget_created_by == ObjectId(user_id) if isinstance(budget_created_by, ObjectId) else False
-                    )
+                    # Check if this budget belongs to the user (handle both ObjectId and string comparisons)
+                    budget_user_match = False
+                    if budget_created_by:
+                        if isinstance(budget_created_by, ObjectId):
+                            budget_user_match = (str(budget_created_by) == str(user_id) or budget_created_by == ObjectId(user_id))
+                        else:
+                            budget_user_match = (str(budget_created_by) == str(user_id))
                     
                     if budget_user_match:
-                        print(f"✅ category_id {category_id} is a budget _id for user {user_id}")
                         # Extract all category IDs from this budget's headCategories
                         head_categories = budget_by_id.get("headCategories", [])
                         category_ids_in_budget = []
@@ -161,22 +160,13 @@ class SmartBudgetRecommender:
                                         if nc_id:
                                             category_ids_in_budget.append(str(nc_id))
                         
-                        print(f"🔍 Found {len(category_ids_in_budget)} category IDs in budget {category_id}")
                         # If budget has categories, consider it as having previous data
                         if category_ids_in_budget:
-                            print(f"✅ Budget {category_id} contains categories: {category_ids_in_budget[:5]}...")
-                            print(f"   Budget name: {budget_by_id.get('name', 'Unknown')}, maxAmount: {budget_by_id.get('maxAmount', 0)}")
                             return True
-                        else:
-                            print(f"⚠️ Budget {category_id} exists but has no categories")
-                    else:
-                        print(f"⚠️ Budget {category_id} exists but belongs to different user")
             except (ValueError, TypeError):
                 pass  # category_id is not a valid ObjectId, continue with normal check
         except Exception as e:
-            print(f"⚠️ Error checking if category_id is a budget _id: {e}")
-            import traceback
-            traceback.print_exc()
+            pass  # Silently continue if budget check fails
         
         # Build comprehensive user query
         user_conditions = []
@@ -222,79 +212,60 @@ class SmartBudgetRecommender:
                 {"headCategories.categories.category": category_id},
             ]
         
-        # FIRST: Check nested structure (headCategories[].categories[].category) - most common case
-        # Budgets have structure: headCategories[].categories[].category (ObjectId)
-        # User ID is stored in createdBy field
-        print(f"🔍 Checking nested structure: headCategories[].categories[].category for category_id {category_id}")
+        # SECOND: Check nested structure (headCategories[].categories[].category) - most common case
         try:
             try:
                 category_objid = ObjectId(category_id)
             except (ValueError, TypeError):
                 category_objid = category_id
             
-            # Try multiple nested query patterns to ensure we catch all cases
-            nested_queries = []
-            
-            # Pattern 1: Using $elemMatch for nested arrays (most accurate)
-            nested_queries.append({
-                "$and": [
-                    {"$or": user_conditions},
-                    {
-                        "$or": [
-                            # Check if category_id is in headCategories[].categories[].category
-                            {"headCategories": {"$elemMatch": {"categories": {"$elemMatch": {"category": category_objid}}}}},
-                            {"headCategories": {"$elemMatch": {"categories": {"$elemMatch": {"category": category_id}}}}},
-                            # Also check if category_id is a headCategory itself
-                            {"headCategories": {"$elemMatch": {"headCategory": category_objid}}},
-                            {"headCategories": {"$elemMatch": {"headCategory": category_id}}},
-                        ]
-                    }
-                ]
-            })
-            
-            # Pattern 2: Using dot notation (simpler, might work for some MongoDB versions)
-            nested_queries.append({
-                "$and": [
-                    {"$or": user_conditions},
-                    {
-                        "$or": [
-                            {"headCategories.categories.category": category_objid},
-                            {"headCategories.categories.category": category_id},
-                            {"headCategories.headCategory": category_objid},
-                            {"headCategories.headCategory": category_id},
-                        ]
-                    }
-                ]
-            })
+            # Try multiple nested query patterns
+            nested_queries = [
+                {
+                    "$and": [
+                        {"$or": user_conditions},
+                        {
+                            "$or": [
+                                {"headCategories": {"$elemMatch": {"categories": {"$elemMatch": {"category": category_objid}}}}},
+                                {"headCategories": {"$elemMatch": {"categories": {"$elemMatch": {"category": category_id}}}}},
+                                {"headCategories": {"$elemMatch": {"headCategory": category_objid}}},
+                                {"headCategories": {"$elemMatch": {"headCategory": category_id}}},
+                            ]
+                        }
+                    ]
+                },
+                {
+                    "$and": [
+                        {"$or": user_conditions},
+                        {
+                            "$or": [
+                                {"headCategories.categories.category": category_objid},
+                                {"headCategories.categories.category": category_id},
+                                {"headCategories.headCategory": category_objid},
+                                {"headCategories.headCategory": category_id},
+                            ]
+                        }
+                    ]
+                }
+            ]
             
-            # Try each nested query pattern
-            for i, nested_query in enumerate(nested_queries, 1):
+            for nested_query in nested_queries:
                 try:
-                    nested_count = self.db.budgets.count_documents(nested_query)
-                    if nested_count > 0:
-                        print(f"✅ Found {nested_count} budget(s) with nested category structure for user {user_id} with category_id {category_id}")
-                        print(f"   Nested query pattern {i} matched: headCategories[].categories[].category = {category_id}")
+                    if self.db.budgets.count_documents(nested_query) > 0:
                         return True
-                except Exception as e:
-                    print(f"⚠️ Error with nested query pattern {i}: {e}")
+                except Exception:
                     continue
-            
-            print(f"🔍 Nested query found 0 budgets for category_id {category_id}")
-        except Exception as e:
-            print(f"⚠️ Error checking nested categories: {e}")
-            import traceback
-            traceback.print_exc()
+        except Exception:
+            pass
         
-        # SECOND: Combine user and category conditions (direct fields)
-        print(f"🔍 Checking direct category fields for category_id {category_id}")
+        # THIRD: Check direct category fields
         for user_cond in user_conditions:
             for cat_cond in category_conditions:
-                budget_query = {**user_cond, **cat_cond}
-                budget_count = self.db.budgets.count_documents(budget_query)
-                if budget_count > 0:
-                    print(f"✅ Found {budget_count} budget(s) for user {user_id} with category_id {category_id}")
-                    print(f"   Query that matched: {budget_query}")
-                    return True
+                try:
+                    if self.db.budgets.count_documents({**user_cond, **cat_cond}) > 0:
+                        return True
+                except Exception:
+                    continue
         
         # THIRD: Also try a more comprehensive query using $and and $or
         try:
@@ -466,7 +437,6 @@ class SmartBudgetRecommender:
             import traceback
             traceback.print_exc()
         
-        print(f"❌ No previous data found for user {user_id} with category_id {category_id}")
         return False
     
     def get_recommendation_for_category(self, user_id: str, category_id: str, month: int, year: int, budget_amount: Optional[float] = None) -> List[BudgetRecommendation]:
@@ -879,7 +849,7 @@ class SmartBudgetRecommender:
             
             if isinstance(date, str):
                 try:
-                    date = datetime.fromisoformat(date.replace('Z', '+00:00'))
+                date = datetime.fromisoformat(date.replace('Z', '+00:00'))
                 except (ValueError, AttributeError):
                     continue
             elif not isinstance(date, datetime):
@@ -1163,7 +1133,7 @@ class SmartBudgetRecommender:
             print(f"Final fallback search failed: {e}")
         
         return str(category_id) if category_id else "Uncategorized"
-    
+
     def _get_category_stats_from_budgets(
         self, user_id: str, month: int, year: int
     ) -> Dict:
@@ -1372,14 +1342,14 @@ class SmartBudgetRecommender:
                     result[result_key] = {
                         "category_name": category_name,
                         "category_id": str(category_id) if category_id else None,
-                        "average_monthly": base_amount,
-                        "total": base_amount,
-                        "count": 1,
-                        "months_analyzed": 1,
-                        "std_dev": 0.0,
-                        "monthly_values": [base_amount],
-                    }
-                else:
+                    "average_monthly": base_amount,
+                    "total": base_amount,
+                    "count": 1,
+                    "months_analyzed": 1,
+                    "std_dev": 0.0,
+                    "monthly_values": [base_amount],
+                }
+            else:
                     result[result_key]["total"] += base_amount
                     result[result_key]["count"] += 1
                     result[result_key]["months_analyzed"] = result[result_key]["count"]
@@ -1404,14 +1374,14 @@ class SmartBudgetRecommender:
         if not OPENAI_API_KEY:
             print(f"⚠️ OpenAI API key not found in environment variables for category: {category}")
             return None
-        
+
         print(f"🔄 Calling OpenAI API for category: {category}...")
 
         # Handle empty monthly_values
         if not data.get("monthly_values") or len(data["monthly_values"]) == 0:
             history = f"{avg_expense:.0f}"
         else:
-            history = ", ".join(f"{value:.0f}" for value in data["monthly_values"])
+        history = ", ".join(f"{value:.0f}" for value in data["monthly_values"])
         
         # Build comprehensive data summary for OpenAI to analyze
         monthly_values = data.get("monthly_values", [])
@@ -1450,8 +1420,8 @@ class SmartBudgetRecommender:
         
         if is_new_budget:
             # This is a new budget - no historical data
-            summary = (
-                f"Category: {category}\n"
+        summary = (
+            f"Category: {category}\n"
                 f"⚠️ IMPORTANT: This is a NEW BUDGET with NO historical spending data.\n"
                 f"The user has provided a budget amount of {avg_expense:,.2f} for this category.\n"
                 f"This is the ONLY data point available - there is NO spending history to analyze.\n\n"
@@ -1475,7 +1445,7 @@ class SmartBudgetRecommender:
                 f"Number of months analyzed: {data['months_analyzed']}\n"
                 f"Total spending: {data.get('total', avg_expense * data['months_analyzed']):,.2f}\n"
                 f"Trend Analysis: {trend_analysis}\n"
-            )
+        )
 
         prompt = (
             "You are an expert global personal finance coach with deep knowledge of:\n"