Better system prompt

app.py

@@ -146,59 +146,59 @@ async def stream_response(query, history):
             yield chunk
 
 async def stream_response_gemini(query, history):
-    """Stream response using Gemini API"""
+    """Stream response using Gemini API with a proper system_instruction."""
     logger.info(f"Processing query with Gemini: {query}")
     start_time = time.time()
     first_token_logged = False
 
+    # Build the system instruction once
     current_date = datetime.now().strftime("%Y-%m-%d")
-    
     system_prompt = (
-        "You are Tim Luka Horstmann, a Computer Scientist. A user is asking you a question. Respond as yourself, using the first person, in a friendly and concise manner. "
+        "You are Tim Luka Horstmann, a Computer Scientist. "
+        "A user is asking you a question. Respond as yourself, using the first person, in a friendly and concise manner. "
         "For questions about your CV, base your answer *exclusively* on the provided CV information below and do not add any details not explicitly stated. "
-        "For casual questions not covered by the CV, respond naturally but limit answers to general truths about yourself (e.g., your current location is Paris, France, or your field is AI) "
-        "and say 'I don't have specific details to share about that' if pressed for specifics beyond the CV or FAQs. Do not invent facts, experiences, or opinions not supported by the CV or FAQs. "
-        f"Today's date is {current_date}. "
-        f"CV: {full_cv_text}"
+        "For casual questions not covered by the CV, respond naturally but limit answers to general truths about yourself (e.g., your current location is Paris, France) "
+        "and say 'I don't have specific details to share about that' if pressed for specifics beyond the CV or FAQs. "
+        f"Today's date is {current_date}. CV: {full_cv_text}"
     )
 
-    # Build messages for Gemini (no system role - embed instructions in first user message)
-    messages = []
-    
-    # Add conversation history
-    for msg in history:
-        role = "user" if msg["role"] == "user" else "model"
-        messages.append(types.Content(role=role, parts=[types.Part.from_text(text=msg["content"])]))
-    
-    # Add current query with system prompt embedded
-    if not history:  # If no history, include system prompt with the first message
-        combined_query = f"{system_prompt}\n\nUser question: {query}"
-    else:
-        combined_query = query
-    
-    messages.append(types.Content(role="user", parts=[types.Part.from_text(text=combined_query)]))
+    # Build only the user/model history as contents
+    contents = [
+        *[
+            types.Content(
+                role=msg["role"],
+                parts=[types.Part.from_text(msg["content"])]
+            )
+            for msg in history
+        ],
+        # Always append the current user query at the end
+        types.Content(
+            role="user",
+            parts=[types.Part.from_text(query)]
+        )
+    ]
 
     try:
         response = gemini_client.models.generate_content_stream(
             model=gemini_model,
-            contents=messages,
+            contents=contents,
             config=types.GenerateContentConfig(
-                temperature=0.3,
-                top_p=0.7,
-                max_output_tokens=512,
+                system_instruction=system_prompt,
+                # temperature=0.3,
+                # top_p=0.7,
+                # max_output_tokens=512,
                 response_mime_type="text/plain",
             )
         )
-        
+
         for chunk in response:
             if chunk.text:
                 if not first_token_logged:
                     logger.info(f"First token time (Gemini): {time.time() - start_time:.2f}s")
                     first_token_logged = True
                 yield f"data: {chunk.text}\n\n"
-        
         yield "data: [DONE]\n\n"
-        
+
     except Exception as e:
         logger.error(f"Gemini API error: {str(e)}")
         yield f"data: Sorry, I encountered an error with Gemini API: {str(e)}\n\n"