File size: 13,320 Bytes
67f8819
 
 
 
 
 
 
 
 
 
 
 
405cd30
 
 
 
67f8819
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
"""
Task API routes with JWT authentication and user isolation.

Per @specs/001-auth-api-bridge/api/rest-endpoints.md and
@specs/001-auth-api-bridge/contracts/pydantic-models.md
"""
from fastapi import APIRouter, Depends, HTTPException, status, Request
from sqlmodel import Session, select
from typing import List, Optional
from uuid import UUID
from datetime import datetime

from api.dependencies import get_current_user, verify_user_ownership
from services.task import TaskService
from config import engine
from models.user import UserTable
from pydantic import BaseModel, Field, constr


# =============================================================================
# Pydantic Models for Request/Response Validation
# Per @specs/001-auth-api-bridge/contracts/pydantic-models.md
# =============================================================================

class TaskCreateRequest(BaseModel):
    """Request model for creating a task."""
    title: constr(min_length=1, max_length=255, strip_whitespace=True) = Field(
        ...,
        description="Task title (1-255 characters)"
    )
    description: Optional[constr(max_length=5000)] = Field(
        None,
        description="Task description (optional, max 5000 characters)"
    )
    priority: str = Field(
        default="medium",
        description="Task priority level: low, medium, or high"
    )


class TaskUpdateRequest(BaseModel):
    """Request model for updating a task."""
    title: Optional[constr(min_length=1, max_length=255, strip_whitespace=True)] = Field(
        None,
        description="Task title (1-255 characters)"
    )
    description: Optional[constr(max_length=5000)] = Field(
        None,
        description="Task description (optional, max 5000 characters)"
    )
    priority: Optional[str] = Field(
        None,
        description="Task priority level: low, medium, or high"
    )


class TaskResponse(BaseModel):
    """Response model for a task."""
    id: UUID = Field(..., description="Unique task identifier")
    title: str = Field(..., description="Task title")
    description: Optional[str] = Field(None, description="Task description")
    completed: bool = Field(..., description="Task completion status")
    priority: str = Field(..., description="Task priority level")
    created_at: str = Field(..., description="Task creation timestamp (ISO 8601)")
    completed_at: Optional[str] = Field(None, description="Task completion timestamp (ISO 8601)")

    model_config = {"from_attributes": True}


class TaskListResponse(BaseModel):
    """Response model for a list of tasks."""
    tasks: List[TaskResponse] = Field(..., description="List of tasks")
    count: int = Field(..., description="Total number of tasks")


class ErrorDetail(BaseModel):
    """Error detail structure."""
    code: str = Field(..., description="Error code (e.g., UNAUTHORIZED, NOT_FOUND)")
    message: str = Field(..., description="Human-readable error message")
    details: dict = Field(default_factory=dict, description="Additional error context")


class ErrorResponse(BaseModel):
    """Standard error response."""
    error: ErrorDetail


# =============================================================================
# Task Routes with JWT Authentication
# =============================================================================

router = APIRouter()


def ensure_user_exists(session: Session, user_id: UUID) -> None:
    """Create user if they don't exist in the database."""
    user = session.get(UserTable, user_id)
    if user is None:
        # Create user with a placeholder email
        user = UserTable(
            id=user_id,
            email=f"user-{str(user_id)[:8]}@placeholder.com",
            created_at=datetime.utcnow(),
            updated_at=datetime.utcnow()
        )
        session.add(user)
        session.commit()
        print(f"Created new user: {user_id}")


@router.post(
    "/api/{user_id}/tasks",
    response_model=TaskResponse,
    status_code=status.HTTP_201_CREATED,
    responses={
        401: {"model": ErrorResponse, "description": "Unauthorized - Invalid or missing token"},
        403: {"model": ErrorResponse, "description": "Forbidden - User ID mismatch"},
        400: {"model": ErrorResponse, "description": "Bad Request - Validation error"}
    }
)
async def create_task(
    user_id: str,
    task_data: TaskCreateRequest,
    request: Request,
    current_user: str = Depends(get_current_user)
):
    """
    Create a new task for the authenticated user.

    Per @specs/001-auth-api-bridge/api/rest-endpoints.md

    Security:
    - JWT token must be valid and not expired
    - user_id in path must match JWT sub claim (user ownership)
    - Task is automatically assigned to authenticated user
    """
    # Verify user ownership: user_id in path must match authenticated user
    await verify_user_ownership(request, user_id)

    # Create task with user_id from verified JWT
    with Session(engine) as session:
        # Ensure user exists in database
        ensure_user_exists(session, UUID(current_user))

        task = TaskService.create_task(
            session=session,
            user_id=UUID(current_user),
            title=task_data.title,
            description=task_data.description,
            priority=task_data.priority
        )

        # Convert datetime objects to ISO 8601 strings for JSON response
        return TaskResponse(
            id=task.id,
            title=task.title,
            description=task.description,
            completed=task.completed,
            priority=task.priority,
            created_at=task.created_at.isoformat(),
            completed_at=task.completed_at.isoformat() if task.completed_at else None
        )


@router.get(
    "/api/{user_id}/tasks",
    response_model=TaskListResponse,
    responses={
        401: {"model": ErrorResponse, "description": "Unauthorized - Invalid or missing token"},
        403: {"model": ErrorResponse, "description": "Forbidden - User ID mismatch"}
    }
)
async def list_tasks(
    user_id: str,
    request: Request,  # type: ignore
    current_user: str = Depends(get_current_user)
):
    """
    List all tasks for the authenticated user.

    Per @specs/001-auth-api-bridge/api/rest-endpoints.md

    Security:
    - JWT token must be valid
    - user_id in path must match JWT sub claim
    - Only returns tasks owned by authenticated user
    """
    await verify_user_ownership(request, user_id)

    with Session(engine) as session:
        tasks = TaskService.get_user_tasks(session=session, user_id=UUID(current_user))

        return TaskListResponse(
            tasks=[
                TaskResponse(
                    id=task.id,
                    title=task.title,
                    description=task.description,
                    completed=task.completed,
                    priority=task.priority,
                    created_at=task.created_at.isoformat(),
                    completed_at=task.completed_at.isoformat() if task.completed_at else None
                )
                for task in tasks
            ],
            count=len(tasks)
        )


@router.get(
    "/api/{user_id}/tasks/{task_id}",
    response_model=TaskResponse,
    responses={
        401: {"model": ErrorResponse, "description": "Unauthorized"},
        403: {"model": ErrorResponse, "description": "Forbidden - Task belongs to different user"},
        404: {"model": ErrorResponse, "description": "Task not found"}
    }
)
async def get_task(
    user_id: str,
    task_id: str,
    request: Request,  # type: ignore
    current_user: str = Depends(get_current_user)
):
    """
    Get details of a specific task.

    Security:
    - JWT token must be valid
    - user_id in path must match JWT sub claim
    - Task must belong to authenticated user
    """
    await verify_user_ownership(request, user_id)

    with Session(engine) as session:
        task = TaskService.get_task_by_id(
            session=session,
            task_id=UUID(task_id),
            user_id=UUID(current_user)
        )

        if not task:
            raise HTTPException(
                status_code=status.HTTP_404_NOT_FOUND,
                detail="Task not found"
            )

        return TaskResponse(
            id=task.id,
            title=task.title,
            description=task.description,
            completed=task.completed,
            priority=task.priority,
            created_at=task.created_at.isoformat(),
            completed_at=task.completed_at.isoformat() if task.completed_at else None
        )


@router.patch(
    "/api/{user_id}/tasks/{task_id}/complete",
    response_model=TaskResponse,
    responses={
        401: {"model": ErrorResponse, "description": "Unauthorized"},
        403: {"model": ErrorResponse, "description": "Forbidden - Task belongs to different user"},
        404: {"model": ErrorResponse, "description": "Task not found"}
    }
)
async def complete_task(
    user_id: str,
    task_id: str,
    request: Request,  # type: ignore
    current_user: str = Depends(get_current_user)
):
    """
    Mark a task as completed.

    Per @specs/001-auth-api-bridge/api/rest-endpoints.md

    Security:
    - JWT token must be valid
    - user_id in path must match JWT sub claim
    - Task must belong to authenticated user

    Idempotent: Can be called multiple times with same result
    """
    await verify_user_ownership(request, user_id)

    with Session(engine) as session:
        task = TaskService.complete_task(
            session=session,
            task_id=UUID(task_id),
            user_id=UUID(current_user)
        )

        if not task:
            raise HTTPException(
                status_code=status.HTTP_404_NOT_FOUND,
                detail="Task not found"
            )

        return TaskResponse(
            id=task.id,
            title=task.title,
            description=task.description,
            completed=task.completed,
            priority=task.priority,
            created_at=task.created_at.isoformat(),
            completed_at=task.completed_at.isoformat() if task.completed_at else None
        )


@router.patch(
    "/api/{user_id}/tasks/{task_id}",
    response_model=TaskResponse,
    responses={
        401: {"model": ErrorResponse, "description": "Unauthorized"},
        403: {"model": ErrorResponse, "description": "Forbidden - Task belongs to different user"},
        404: {"model": ErrorResponse, "description": "Task not found"}
    }
)
async def update_task(
    user_id: str,
    task_id: str,
    task_data: TaskUpdateRequest,
    request: Request,  # type: ignore
    current_user: str = Depends(get_current_user)
):
    """
    Update a task's title and/or description.

    Per @specs/001-auth-api-bridge/api/rest-endpoints.md

    Security:
    - JWT token must be valid
    - user_id in path must match JWT sub claim
    - Task must belong to authenticated user
    """
    await verify_user_ownership(request, user_id)

    with Session(engine) as session:
        # Check if at least one field is being updated
        if task_data.title is None and task_data.description is None and task_data.priority is None:
            raise HTTPException(
                status_code=status.HTTP_400_BAD_REQUEST,
                detail="At least one field (title, description, or priority) must be provided"
            )

        task = TaskService.update_task(
            session=session,
            task_id=UUID(task_id),
            user_id=UUID(current_user),
            title=task_data.title,
            description=task_data.description,
            priority=task_data.priority
        )

        if not task:
            raise HTTPException(
                status_code=status.HTTP_404_NOT_FOUND,
                detail="Task not found"
            )

        return TaskResponse(
            id=task.id,
            title=task.title,
            description=task.description,
            completed=task.completed,
            priority=task.priority,
            created_at=task.created_at.isoformat(),
            completed_at=task.completed_at.isoformat() if task.completed_at else None
        )



@router.delete(
    "/api/{user_id}/tasks/{task_id}",
    status_code=status.HTTP_204_NO_CONTENT,
    responses={
        401: {"model": ErrorResponse, "description": "Unauthorized"},
        403: {"model": ErrorResponse, "description": "Forbidden - Task belongs to different user"},
        404: {"model": ErrorResponse, "description": "Task not found"}
    }
)
async def delete_task(
    user_id: str,
    task_id: str,
    request: Request,  # type: ignore
    current_user: str = Depends(get_current_user)
):
    """
    Delete a task.

    Security:
    - JWT token must be valid
    - user_id in path must match JWT sub claim
    - Task must belong to authenticated user
    """
    await verify_user_ownership(request, user_id)

    with Session(engine) as session:
        success = TaskService.delete_task(
            session=session,
            task_id=UUID(task_id),
            user_id=UUID(current_user)
        )

        if not success:
            raise HTTPException(
                status_code=status.HTTP_404_NOT_FOUND,
                detail="Task not found"
            )

        return None