v2.3 we did it

src/app.py

@@ -230,6 +230,13 @@ def start_radio_stream():
     return "🎵 Starting your personalized radio show...", None, None, None, ""
 
 
+def show_pending_player():
+    """Called by timer to finally show the media player"""
+    player_html = radio_state.get("pending_player_html", "")
+    print("⏰ Timer fired: Showing pending media player now")
+    # Return player HTML and disable timer
+    return player_html, gr.Timer(value=0, active=False)
+
 def start_and_play_first_segment():
     """
     One-shot helper for the UI:
@@ -272,15 +279,15 @@ def start_and_play_first_segment():
             }
             print("📋 Using default preferences")
     
-    # Check if resuming from stopped state
-    if radio_state.get("is_stopped") and radio_state.get("planned_show"):
+    # Check if resuming from stopped state (only if show was manually stopped, not completed)
+    if radio_state.get("is_stopped") and radio_state.get("planned_show") and radio_state["current_segment_index"] < len(radio_state["planned_show"]):
         print("▶️ Resuming from stopped state...")
         radio_state["is_playing"] = True
         radio_state["is_stopped"] = False
         radio_state["stop_flag"] = False
         
         # Play next segment (continuing from where we stopped)
-        segment_info, host_audio, music_html, progress, now_playing, llm_script = play_next_segment()
+        segment_info, host_audio, music_html, progress, now_playing, llm_script, timer_config = play_next_segment()
         
         return (
             "▶️ Resuming radio...",
@@ -290,15 +297,30 @@ def start_and_play_first_segment():
             progress,
             now_playing,
             llm_script,
+            timer_config
         )
     
-    if radio_state["is_playing"]:
-        return (
-            "📻 Radio is already playing!",
-            "**Welcome!** Set your preferences and start the radio.",
-            None, None, "Ready to start", "📻 AI Radio",
-            "Model-generated script will appear here for each segment.",
-        )
+    # If show completed or no valid show to resume, start fresh
+    # Also check if is_playing is True but show is actually completed
+    if radio_state.get("is_playing") and radio_state.get("planned_show"):
+        # Check if show is actually completed
+        if radio_state["current_segment_index"] >= len(radio_state["planned_show"]):
+            # Show completed, reset and start fresh
+            print("🔄 Show completed, resetting for new show...")
+            reset_radio()
+        else:
+            # Show is actually playing
+            return (
+                "📻 Radio is already playing!",
+                "**Welcome!** Set your preferences and start the radio.",
+                None, None, "Ready to start", "📻 AI Radio",
+                "Model-generated script will appear here for each segment.",
+                gr.Timer(value=0, active=False)
+            )
+    elif radio_state.get("is_playing"):
+        # is_playing is True but no planned show - reset
+        print("🔄 is_playing=True but no planned_show, resetting...")
+        reset_radio()
     
     import time
     t0 = time.time()
@@ -326,7 +348,7 @@ def start_and_play_first_segment():
     # Step 2 & 3: Generate and play first segment (LLM + TTS inside play_next_segment)
     print("  [2/3] Generating first segment (LLM)...")
     t1 = time.time()
-    segment_info, host_audio, music_html, progress, now_playing, llm_script = play_next_segment()
+    segment_info, host_audio, music_html, progress, now_playing, llm_script, timer_config = play_next_segment()
     print(f"  [2/3] Done in {time.time()-t1:.1f}s")
     print(f"  [3/3] Total time: {time.time()-t0:.1f}s")
     print(f"  Host audio file: {host_audio}")
@@ -339,6 +361,7 @@ def start_and_play_first_segment():
         progress,
         now_playing,
         llm_script,
+        timer_config
     )
 
 def play_next_segment():
@@ -356,11 +379,11 @@ def play_next_segment():
             radio_state["is_playing"] = True
             radio_state["stop_flag"] = False
         else:
-            return "⏸️ No show planned. Click 'Generate & Play' to start.", None, None, None, "", ""
+            return "⏸️ No show planned. Click 'Generate & Play' to start.", None, None, None, "", "", gr.Timer(value=0, active=False)
     
     if radio_state["stop_flag"]:
         radio_state["is_playing"] = False
-        return "⏸️ Radio paused", None, None, None, "", ""
+        return "⏸️ Radio paused", None, None, None, "", "", gr.Timer(value=0, active=False)
     
     # If there are remaining news TTS batches, play the next one without advancing to a new segment
     if radio_state.get("current_news_batches"):
@@ -395,11 +418,11 @@ def play_next_segment():
                 radio_state["news_total_batches"] = 0
                 radio_state["news_batches_played"] = 0
             
-            return segment_info, host_audio_file, "", progress, get_now_playing(segment), display_script
+            return segment_info, host_audio_file, "", progress, get_now_playing(segment), display_script, gr.Timer(value=0, active=False)
     
     if radio_state["current_segment_index"] >= len(radio_state["planned_show"]):
         radio_state["is_playing"] = False
-        return "🎊 Show completed! Hope you enjoyed it.", None, None, None, "", ""
+        return "🎊 Show completed! Hope you enjoyed it.", None, None, None, "", "", gr.Timer(value=0, active=False)
     
     # Get current segment
     segment_index = radio_state["current_segment_index"]
@@ -750,8 +773,38 @@ def play_next_segment():
     
     threading.Thread(target=_prefetch_next, daemon=True).start()
     
-    # Return: segment_info, host_audio, music_player_html, progress, now_playing, segmented LLM script for UI
-    return segment_info, host_audio_file, music_player_html, progress, get_now_playing(segment), display_script
+    # Calculate segment duration and set up delayed player if needed
+    timer_config = gr.Timer(value=0, active=False)
+    
+    # Only delay player if we have both host audio and a music/podcast player
+    if host_audio_file and os.path.exists(host_audio_file) and music_player_html and ("<iframe" in music_player_html):
+        try:
+            audio = AudioSegment.from_file(host_audio_file)
+            host_duration_s = len(audio) / 1000.0
+            
+            # Start player 3 seconds before host speech ends
+            delay_s = max(0.5, host_duration_s - 3.0)
+            
+            print(f"⏱️ Host duration: {host_duration_s:.1f}s, Scheduling player in {delay_s:.1f}s")
+            
+            # Store the actual player HTML
+            radio_state["pending_player_html"] = music_player_html
+            
+            # Return placeholder/empty player and active timer
+            music_player_html = create_placeholder_html(
+                segment.get('track', {}).get('title', 'Content') if segment.get('type') == 'music' else segment.get('podcast', {}).get('title', 'Podcast'),
+                segment.get('track', {}).get('artist', '') if segment.get('type') == 'music' else segment.get('podcast', {}).get('host', ''),
+                delay_s,
+                segment.get('type', 'music')
+            )
+            timer_config = gr.Timer(value=delay_s, active=True)
+            
+        except Exception as e:
+            print(f"⚠️ Error calculating audio duration for delay: {e}")
+            # Fallback: play immediately (leave music_player_html as is, timer inactive)
+    
+    # Return: segment_info, host_audio, music_player_html, progress, now_playing, segmented LLM script for UI, timer
+    return segment_info, host_audio_file, music_player_html, progress, get_now_playing(segment), display_script, timer_config
 
 def stop_radio():
     """Stop the radio stream - pauses at current segment without resetting"""
@@ -765,13 +818,14 @@ def stop_radio():
     
     status_msg = f"⏹️ Stopped at segment {current_idx}/{total_segments}. Click 'Generate & Play' or 'Next Segment' to continue."
     
-    # Return status, clear audio, clear music player, progress, now playing
+    # Return status, clear audio, clear music player, progress, now playing, timer
     return (
         status_msg,
         None,  # Clear audio
         "",    # Clear music player HTML
         f"Stopped at {current_idx}/{total_segments}",
-        f"⏸️ Paused - Segment {current_idx}/{total_segments}"
+        f"⏸️ Paused - Segment {current_idx}/{total_segments}",
+        gr.Timer(value=0, active=False)  # Stop timer
     )
 
 
@@ -959,6 +1013,7 @@ def handle_voice_request():
         # Create music player HTML with volume fading (0→30% during host speech, then 30%→100%)
         music_player_html = ""
         player_id = f"voice_player_{int(time.time())}"
+        timer_config = gr.Timer(value=0, active=False)
         
         if track.get("source") == "youtube":
             youtube_id = track.get("youtube_id", "")
@@ -966,53 +1021,48 @@ def handle_voice_request():
                 youtube_id = track["url"].split("v=")[-1].split("&")[0]
             
             if youtube_id:
-                # # COMMENTED OUT: Delayed loading mechanism
-                # # Get host audio duration to calculate delay
-                # delay_ms = 0
-                # if audio_file and os.path.exists(audio_file):
-                #     try:
-                #         audio = AudioSegment.from_file(audio_file)
-                #         duration_ms = len(audio)
-                #         delay_ms = max(0, duration_ms - 3000)  # Start 3 seconds before end
-                #         print(f"⏱️ Voice request audio: {duration_ms}ms, YouTube delay: {delay_ms}ms")
-                #     except Exception as e:
-                #         print(f"⚠️ Could not get audio duration: {e}")
-                
-                # # Store the actual iframe HTML for later (after host speech ends)
-                # delay_s = delay_ms / 1000.0
-                # actual_player_html = create_youtube_player_html(
-                #     youtube_id,
-                #     track.get('title', 'Unknown'),
-                #     track.get('artist', 'Unknown'),
-                #     track['url']
-                # )
-                
-                # # Schedule the player to be ready after the delay
-                # radio_state["pending_player"] = {
-                #     "html": actual_player_html,
-                #     "ready_at": time.time() + delay_s,
-                #     "type": "music",
-                #     "title": track.get('title', 'Unknown')
-                # }
-                
-                # # Return placeholder initially (no iframe yet!)
-                # music_player_html = create_placeholder_html(
-                #     track.get('title', 'Unknown'),
-                #     track.get('artist', 'Unknown'),
-                #     delay_s,
-                #     "music"
-                # )
-                # print(f"✅ Voice request YouTube player scheduled - iframe added after {delay_s:.1f}s")
-                # print(f"✅ YouTube player scheduled: {track.get('title', 'Unknown')} (ID: {youtube_id})")
-                
-                # Simple immediate iframe - start track with host
-                music_player_html = create_youtube_player_html(
-                    youtube_id,
-                    track.get('title', 'Unknown'),
-                    track.get('artist', 'Unknown'),
-                    track['url']
-                )
-                print(f"✅ Voice request YouTube player created immediately: {track.get('title', 'Unknown')} (ID: {youtube_id})")
+                # Delayed loading mechanism with gr.Timer
+                try:
+                    # Get host audio duration to calculate delay
+                    delay_s = 0.5
+                    if audio_file and os.path.exists(audio_file):
+                        audio = AudioSegment.from_file(audio_file)
+                        duration_ms = len(audio)
+                        delay_s = max(0.5, (duration_ms / 1000.0) - 3.0)  # Start 3 seconds before end
+                        print(f"⏱️ Voice request audio: {duration_ms}ms, YouTube delay: {delay_s:.1f}s")
+
+                    # Create the actual player HTML
+                    actual_player_html = create_youtube_player_html(
+                        youtube_id,
+                        track.get('title', 'Unknown'),
+                        track.get('artist', 'Unknown'),
+                        track['url']
+                    )
+                    
+                    # Store for timer callback
+                    radio_state["pending_player_html"] = actual_player_html
+                    
+                    # Create placeholder
+                    music_player_html = create_placeholder_html(
+                        track.get('title', 'Unknown'),
+                        track.get('artist', 'Unknown'),
+                        delay_s,
+                        "music"
+                    )
+                    
+                    # Activate timer
+                    timer_config = gr.Timer(value=delay_s, active=True)
+                    print(f"✅ Voice request: Player scheduled in {delay_s:.1f}s")
+                    
+                except Exception as e:
+                    print(f"⚠️ Error calculating delay for voice request: {e}")
+                    # Fallback: immediate play
+                    music_player_html = create_youtube_player_html(
+                        youtube_id,
+                        track.get('title', 'Unknown'),
+                        track.get('artist', 'Unknown'),
+                        track['url']
+                    )
             else:
                 music_player_html = f"""
                 <div style="padding: 1rem; background: #f0f0f0; border-radius: 10px; margin: 1rem 0;">
@@ -1042,10 +1092,10 @@ def handle_voice_request():
         # The browser may block autoplay - user may need to click play
         
         # Return with player
-        return f"✅ {host_response}\n\n🎵 Playing: {track['title']} by {track['artist']}", audio_file, music_player_html
+        return f"✅ {host_response}\n\n🎵 Playing: {track['title']} by {track['artist']}", audio_file, music_player_html, timer_config
         
     except Exception as e:
-        return f"❌ Error processing voice request: {e}", None, ""
+        return f"❌ Error processing voice request: {e}", None, "", gr.Timer(value=0, active=False)
 
 def get_now_playing(segment: Dict[str, Any]) -> str:
     """Get now playing text"""
@@ -1561,26 +1611,14 @@ with gr.Blocks(css=custom_css, title="AI Radio 🎵", theme=gr.themes.Soft(), he
             audio_output = gr.Audio(label="🔊 Host Speech", autoplay=True, type="filepath", elem_id="host_audio")
             music_player = gr.HTML(label="🎵 Music/Podcast Player (streaming)")
             
-            # # COMMENTED OUT: Timer to check for pending players (delayed loading mechanism)
-            # # Timer to check for pending players (polls every 2 seconds)
-            # player_timer = gr.Timer(value=2, active=True)
-            
-            # def check_pending_player():
-            #     """Check if there's a pending player ready to show"""
-            #     pending = radio_state.get("pending_player")
-            #     if pending and time.time() >= pending.get("ready_at", 0):
-            #         html = pending.get("html", "")
-            #         title = pending.get("title", "Unknown")
-            #         radio_state["pending_player"] = None  # Clear it
-            #         print(f"▶️ Adding iframe for: {title}")
-            #         return html
-            #     return gr.update()  # No change
-            
-            # player_timer.tick(
-            #     fn=check_pending_player,
-            #     inputs=[],
-            #     outputs=[music_player]
-            # )
+            # Timer for delayed player loading (start disabled)
+            player_timer = gr.Timer(value=0, active=False)
+            
+            player_timer.tick(
+                fn=show_pending_player,
+                inputs=[],
+                outputs=[music_player, player_timer]
+            )
             
             status_text = gr.Textbox(label="Status", value="Ready", interactive=False, visible=False)
             
@@ -1588,19 +1626,19 @@ with gr.Blocks(css=custom_css, title="AI Radio 🎵", theme=gr.themes.Soft(), he
             start_btn.click(
                 fn=start_and_play_first_segment,
                 inputs=[],
-                outputs=[status_text, segment_info, audio_output, music_player, progress_text, now_playing, llm_script]
+                outputs=[status_text, segment_info, audio_output, music_player, progress_text, now_playing, llm_script, player_timer]
             )
             
             next_btn.click(
                 fn=play_next_segment,
                 inputs=[],
-                outputs=[segment_info, audio_output, music_player, progress_text, now_playing, llm_script]
+                outputs=[segment_info, audio_output, music_player, progress_text, now_playing, llm_script, player_timer]
             )
             
             stop_btn.click(
                 fn=stop_radio,
                 inputs=[],
-                outputs=[status_text, audio_output, music_player, progress_text, now_playing],
+                outputs=[status_text, audio_output, music_player, progress_text, now_playing, player_timer],
                 js="() => { if(window.cancelNextSegment) window.cancelNextSegment(); }"
             )
             
@@ -1608,7 +1646,7 @@ with gr.Blocks(css=custom_css, title="AI Radio 🎵", theme=gr.themes.Soft(), he
             voice_btn.click(
                 fn=handle_voice_request,
                 inputs=[],
-                outputs=[voice_status, audio_output, music_player]
+                outputs=[voice_status, audio_output, music_player, player_timer]
             )
             
             # Like/Dislike buttons