Fix Docker frontend install peer dependency resolution

.github/workflows/deploy-hf-space.yml

@@ -20,6 +20,7 @@ jobs:
     env:
       FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
       HF_SPACE_TOKEN: ${{ secrets.HF_SPACE_TOKEN }}
+      HF_TOKEN: ${{ secrets.HF_TOKEN }}
       HF_SPACE_ID: ${{ vars.HF_SPACE_ID || 'Ma-Ri-Ba-Ku/Clafoutis' }}
     steps:
       - name: Checkout repository
@@ -31,8 +32,9 @@ jobs:
         shell: bash
         run: |
           set -euo pipefail
-          if [ -z "${HF_SPACE_TOKEN:-}" ]; then
-            echo "HF_SPACE_TOKEN is empty; skipping deployment."
+          EFFECTIVE_HF_TOKEN="${HF_SPACE_TOKEN:-${HF_TOKEN:-}}"
+          if [ -z "${EFFECTIVE_HF_TOKEN}" ]; then
+            echo "No token found; set HF_SPACE_TOKEN or HF_TOKEN in GitHub Secrets. Skipping deployment."
             exit 0
           fi
 
@@ -44,5 +46,5 @@ jobs:
           git config user.name "github-actions[bot]"
           git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
 
-          git remote add hf-space "https://oauth2:${HF_TOKEN}@huggingface.co/spaces/${HF_SPACE_ID}"
+          git remote add hf-space "https://oauth2:${EFFECTIVE_HF_TOKEN}@huggingface.co/spaces/${HF_SPACE_ID}"
           git push --force hf-space HEAD:main

Dockerfile

@@ -3,7 +3,7 @@
 FROM node:20-alpine AS frontend-builder
 WORKDIR /app/app/frontend
 COPY app/frontend/package.json app/frontend/package-lock.json* ./
-RUN npm install
+RUN npm install --legacy-peer-deps
 COPY app/frontend/ ./
 ARG VITE_API_BASE_URL=
 ENV VITE_API_BASE_URL=${VITE_API_BASE_URL}

README.md

@@ -211,7 +211,7 @@ uvicorn app.main:app --app-dir app/backend --reload
 
 ```bash
 cd app/frontend
-npm install
+npm install --legacy-peer-deps
 npm run dev
 ```
 
@@ -244,6 +244,9 @@ CLAFOUTIS_BODLEIAN_USE_FIXTURES=true
 CLAFOUTIS_EUROPEANA_USE_FIXTURES=true
 CLAFOUTIS_EUROPEANA_API_KEY=
 
+# Hugging Face Spaces: HF_TOKEN est aussi accepté en fallback pour Europeana
+# (utile si votre secret Space est nommé HF_TOKEN).
+
 CLAFOUTIS_ENABLE_CAPABILITY_PROBING=true
 CLAFOUTIS_CAPABILITY_PROBE_USE_FIXTURES=true
 CLAFOUTIS_CAPABILITY_PROBE_TIMEOUT_SECONDS=2
@@ -298,6 +301,9 @@ Puis ouvrir :
    - `CLAFOUTIS_BODLEIAN_USE_FIXTURES=true`
    - `CLAFOUTIS_EUROPEANA_USE_FIXTURES=true`
 4. Optionnel : ajouter `CLAFOUTIS_EUROPEANA_API_KEY` pour le mode live Europeana.
+   Le backend accepte aussi `HF_TOKEN` en fallback si votre secret Space porte ce nom.
+5. Si vous utilisez le workflow GitHub de déploiement, configurez un secret GitHub
+   `HF_SPACE_TOKEN` (ou `HF_TOKEN`, désormais accepté en fallback).
 
 Le point d’entrée est `scripts/start.sh`, qui démarre Uvicorn sur `HOST/PORT` compatibles Space Docker.
 

app/backend/app/config/settings.py

@@ -1,6 +1,6 @@
 """Application settings loaded from environment variables."""
 
-from pydantic import Field
+from pydantic import AliasChoices, Field
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 
@@ -20,7 +20,10 @@ class Settings(BaseSettings):
     bodleian_api_base_url: str = "https://api.bodleian.ox.ac.uk/iiif"
     europeana_use_fixtures: bool = False
     europeana_api_base_url: str = "https://api.europeana.eu/record/v2/search.json"
-    europeana_api_key: str = ""
+    europeana_api_key: str = Field(
+        default="",
+        validation_alias=AliasChoices("CLAFOUTIS_EUROPEANA_API_KEY", "EUROPEANA_API_KEY", "HF_TOKEN"),
+    )
 
     # Runtime capability probing
     enable_capability_probing: bool = True

app/tests/unit/backend/test_settings.py

@@ -0,0 +1,27 @@
+"""Settings environment aliases tests."""
+
+from app.config.settings import Settings
+
+
+def test_europeana_api_key_reads_clafoutis_prefixed_env(monkeypatch) -> None:
+    """Europeana API key should be loaded from CLAFOUTIS_EUROPEANA_API_KEY first."""
+
+    monkeypatch.setenv("CLAFOUTIS_EUROPEANA_API_KEY", "prefixed-key")
+    monkeypatch.delenv("EUROPEANA_API_KEY", raising=False)
+    monkeypatch.delenv("HF_TOKEN", raising=False)
+
+    loaded = Settings()
+
+    assert loaded.europeana_api_key == "prefixed-key"
+
+
+def test_europeana_api_key_accepts_hf_token_fallback(monkeypatch) -> None:
+    """HF Space secret HF_TOKEN should be accepted as a fallback for Europeana wskey."""
+
+    monkeypatch.delenv("CLAFOUTIS_EUROPEANA_API_KEY", raising=False)
+    monkeypatch.delenv("EUROPEANA_API_KEY", raising=False)
+    monkeypatch.setenv("HF_TOKEN", "hf-secret-token")
+
+    loaded = Settings()
+
+    assert loaded.europeana_api_key == "hf-secret-token"