Spaces:
Build error
Build error
File size: 34,751 Bytes
9bb793c cd353f9 9bb793c cd353f9 9bb793c b134c5d 9bb793c b134c5d 9bb793c cd353f9 9bb793c cd353f9 9bb793c cd353f9 9bb793c cd353f9 9bb793c cd353f9 9bb793c 193eb98 9bb793c 193eb98 9bb793c cd353f9 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c cd353f9 9bb793c cd353f9 9bb793c 2d76892 9bb793c 2d76892 9bb793c cd353f9 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 193eb98 9b4e099 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 2d76892 9bb793c 9b4e099 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 | """
Tests du pipeline d'analyse IA :
- prompt_loader : chargement + rendu des templates
- client_factory : construction du genai.Client selon le provider
- response_parser: parsing JSON brut → layout + OCRResult
- master_writer : écriture ai_raw.json et master.json
- analyzer : run_primary_analysis (end-to-end mocké)
"""
# 1. stdlib
import io
import json
from datetime import datetime, timezone
from pathlib import Path
from unittest.mock import MagicMock, call, patch
# 2. third-party
import pytest
from PIL import Image
from pydantic import ValidationError
# 3. local
from app.schemas.corpus_profile import (
CorpusProfile,
ExportConfig,
LayerType,
ScriptType,
UncertaintyConfig,
)
from app.schemas.image import ImageDerivativeInfo
from app.schemas.model_config import ModelConfig, ProviderType
from app.schemas.page_master import OCRResult, PageMaster
from app.services.ai.analyzer import run_primary_analysis
from app.services.ai.client_factory import build_client
from app.services.ai.master_writer import write_ai_raw, write_master_json
from app.services.ai.prompt_loader import load_and_render_prompt
from app.services.ai.response_parser import ParseError, parse_ai_response
# ---------------------------------------------------------------------------
# Helpers
# ---------------------------------------------------------------------------
def _make_jpeg_bytes(width: int = 100, height: int = 100) -> bytes:
img = Image.new("RGB", (width, height), color=(128, 64, 32))
buf = io.BytesIO()
img.save(buf, format="JPEG", quality=85)
return buf.getvalue()
def _make_corpus_profile(
profile_id: str = "medieval-illuminated",
prompt_rel_path: str = "prompts/medieval-illuminated/primary_v1.txt",
) -> CorpusProfile:
return CorpusProfile(
profile_id=profile_id,
label="Manuscrit médiéval enluminé",
language_hints=["la"],
script_type=ScriptType.CAROLINE,
active_layers=[LayerType.IMAGE, LayerType.OCR_DIPLOMATIC],
prompt_templates={"primary": prompt_rel_path},
uncertainty_config=UncertaintyConfig(),
export_config=ExportConfig(),
)
def _make_model_config(provider: ProviderType = ProviderType.GOOGLE_AI_STUDIO) -> ModelConfig:
return ModelConfig(
corpus_id="test-corpus",
selected_model_id="gemini-2.0-flash",
selected_model_display_name="Gemini 2.0 Flash",
provider=provider,
supports_vision=True,
last_fetched_at=datetime.now(tz=timezone.utc),
)
def _make_image_info() -> ImageDerivativeInfo:
return ImageDerivativeInfo(
original_url="https://example.com/iiif/f001.jpg",
original_width=3000,
original_height=4000,
derivative_path="/data/corpora/test-corpus/derivatives/0001r.jpg",
derivative_width=1125,
derivative_height=1500,
thumbnail_path="/data/corpora/test-corpus/derivatives/0001r_thumb.jpg",
thumbnail_width=192,
thumbnail_height=256,
)
def _valid_ai_json(regions: list | None = None) -> str:
if regions is None:
regions = [
{"id": "r1", "type": "text_block", "bbox": [10, 20, 300, 400], "confidence": 0.95},
{"id": "r2", "type": "miniature", "bbox": [0, 0, 500, 600], "confidence": 0.88},
]
return json.dumps({
"layout": {"regions": regions},
"ocr": {
"diplomatic_text": "Incipit liber beati Ieronimi",
"blocks": [],
"lines": [],
"language": "la",
"confidence": 0.87,
"uncertain_segments": [],
},
})
# ---------------------------------------------------------------------------
# Tests — load_and_render_prompt
# ---------------------------------------------------------------------------
def test_prompt_loader_renders_variables(tmp_path):
tpl = tmp_path / "prompt.txt"
tpl.write_text("Corpus : {{profile_label}}\nLangue : {{language_hints}}")
result = load_and_render_prompt(tpl, {
"profile_label": "Manuscrit test",
"language_hints": "la, fr",
})
assert "Manuscrit test" in result
assert "la, fr" in result
assert "{{profile_label}}" not in result
assert "{{language_hints}}" not in result
def test_prompt_loader_unknown_variable_raises(tmp_path):
"""Une variable absente du contexte lève ValueError (CLAUDE.md §8)."""
tpl = tmp_path / "prompt.txt"
tpl.write_text("Hello {{name}} — {{unknown}}")
with pytest.raises(ValueError, match="Variables non résolues"):
load_and_render_prompt(tpl, {"name": "World"})
def test_prompt_loader_empty_context(tmp_path):
tpl = tmp_path / "prompt.txt"
tpl.write_text("Texte sans variables.")
result = load_and_render_prompt(tpl, {})
assert result == "Texte sans variables."
def test_prompt_loader_file_not_found():
with pytest.raises(FileNotFoundError):
load_and_render_prompt("/nonexistent/path/prompt.txt", {})
def test_prompt_loader_accepts_path_object(tmp_path):
tpl = tmp_path / "sub" / "tpl.txt"
tpl.parent.mkdir()
tpl.write_text("OK {{var}}")
result = load_and_render_prompt(tpl, {"var": "value"})
assert result == "OK value"
def test_prompt_loader_multiple_occurrences(tmp_path):
"""Une même variable peut apparaître plusieurs fois."""
tpl = tmp_path / "prompt.txt"
tpl.write_text("{{x}} et {{x}} encore")
result = load_and_render_prompt(tpl, {"x": "Z"})
assert result == "Z et Z encore"
# ---------------------------------------------------------------------------
# Tests — build_client
# ---------------------------------------------------------------------------
def test_build_client_google_ai_studio(monkeypatch):
monkeypatch.setenv("GOOGLE_AI_STUDIO_API_KEY", "fake-key-studio")
with patch("app.services.ai.client_factory.genai.Client") as mock_cls:
mock_cls.return_value = MagicMock()
client = build_client(ProviderType.GOOGLE_AI_STUDIO)
mock_cls.assert_called_once_with(api_key="fake-key-studio")
assert client is mock_cls.return_value
def test_build_client_google_ai_studio_missing_env(monkeypatch):
monkeypatch.delenv("GOOGLE_AI_STUDIO_API_KEY", raising=False)
with pytest.raises(RuntimeError, match="GOOGLE_AI_STUDIO_API_KEY"):
build_client(ProviderType.GOOGLE_AI_STUDIO)
def test_build_client_vertex_service_account(monkeypatch):
sa_json = json.dumps({
"type": "service_account",
"project_id": "my-project",
"private_key_id": "key-id",
"private_key": "-----BEGIN RSA PRIVATE KEY-----\nfake\n-----END RSA PRIVATE KEY-----\n",
"client_email": "sa@my-project.iam.gserviceaccount.com",
"client_id": "123",
"auth_uri": "https://accounts.google.com/o/oauth2/auth",
"token_uri": "https://oauth2.googleapis.com/token",
})
monkeypatch.setenv("VERTEX_SERVICE_ACCOUNT_JSON", sa_json)
mock_creds = MagicMock()
with (
patch("app.services.ai.client_factory.service_account.Credentials.from_service_account_info",
return_value=mock_creds) as mock_sa,
patch("app.services.ai.client_factory.genai.Client") as mock_cls,
):
mock_cls.return_value = MagicMock()
client = build_client(ProviderType.VERTEX_SERVICE_ACCOUNT)
mock_sa.assert_called_once()
mock_cls.assert_called_once_with(
vertexai=True,
project="my-project",
location="us-central1",
credentials=mock_creds,
)
assert client is mock_cls.return_value
def test_build_client_vertex_sa_missing_env(monkeypatch):
monkeypatch.delenv("VERTEX_SERVICE_ACCOUNT_JSON", raising=False)
with pytest.raises(RuntimeError, match="VERTEX_SERVICE_ACCOUNT_JSON"):
build_client(ProviderType.VERTEX_SERVICE_ACCOUNT)
def test_build_client_vertex_sa_invalid_json(monkeypatch):
monkeypatch.setenv("VERTEX_SERVICE_ACCOUNT_JSON", "not-valid-json{{{")
with pytest.raises(ValueError, match="JSON invalide"):
build_client(ProviderType.VERTEX_SERVICE_ACCOUNT)
def test_build_client_vertex_sa_missing_project_id(monkeypatch):
sa_json = json.dumps({"type": "service_account"}) # no project_id
monkeypatch.setenv("VERTEX_SERVICE_ACCOUNT_JSON", sa_json)
with pytest.raises(ValueError, match="project_id"):
build_client(ProviderType.VERTEX_SERVICE_ACCOUNT)
# ---------------------------------------------------------------------------
# Tests — parse_ai_response
# ---------------------------------------------------------------------------
def test_parse_valid_response():
layout, ocr = parse_ai_response(_valid_ai_json())
assert len(layout["regions"]) == 2
assert layout["regions"][0]["id"] == "r1"
assert layout["regions"][0]["type"] == "text_block"
assert layout["regions"][0]["bbox"] == [10, 20, 300, 400]
assert isinstance(ocr, OCRResult)
assert ocr.diplomatic_text == "Incipit liber beati Ieronimi"
assert ocr.confidence == pytest.approx(0.87)
def test_parse_invalid_json_raises_parse_error():
with pytest.raises(ParseError, match="non parseable"):
parse_ai_response("this is not json at all {{}")
def test_parse_non_object_raises_parse_error():
with pytest.raises(ParseError, match="objet JSON attendu"):
parse_ai_response("[1, 2, 3]")
def test_parse_invalid_bbox_region_is_skipped():
"""Une région avec bbox invalide est ignorée ; les autres sont conservées."""
raw = json.dumps({
"layout": {
"regions": [
{"id": "r1", "type": "text_block", "bbox": [0, 0, 100, 100], "confidence": 0.9},
{"id": "r_bad", "type": "text_block", "bbox": [0, 0, -10, 50], "confidence": 0.7},
{"id": "r3", "type": "miniature", "bbox": [5, 5, 200, 300], "confidence": 0.8},
]
},
"ocr": {},
})
layout, ocr = parse_ai_response(raw)
assert len(layout["regions"]) == 2
ids = [r["id"] for r in layout["regions"]]
assert "r1" in ids
assert "r3" in ids
assert "r_bad" not in ids
def test_parse_zero_width_bbox_is_skipped():
"""Une bbox avec width=0 est rejetée par le validator Pydantic."""
raw = json.dumps({
"layout": {
"regions": [
{"id": "r1", "type": "text_block", "bbox": [0, 0, 0, 100], "confidence": 0.9},
]
},
"ocr": {},
})
layout, _ = parse_ai_response(raw)
assert len(layout["regions"]) == 0
def test_parse_all_bad_regions_returns_empty_layout():
raw = json.dumps({
"layout": {"regions": [
{"id": "r1", "type": "text_block", "bbox": [-5, 0, 100, 100], "confidence": 0.9},
]},
"ocr": {},
})
layout, _ = parse_ai_response(raw)
assert layout == {"regions": []}
def test_parse_missing_layout_returns_empty():
raw = json.dumps({"ocr": {"diplomatic_text": "hello", "confidence": 0.5}})
layout, ocr = parse_ai_response(raw)
assert layout == {"regions": []}
assert ocr.diplomatic_text == "hello"
def test_parse_missing_ocr_returns_default():
raw = json.dumps({"layout": {"regions": []}})
layout, ocr = parse_ai_response(raw)
assert isinstance(ocr, OCRResult)
assert ocr.diplomatic_text == ""
assert ocr.confidence == 0.0
def test_parse_markdown_code_fence_stripped():
"""Les balises ```json ... ``` sont supprimées avant parsing."""
inner = json.dumps({"layout": {"regions": []}, "ocr": {}})
fenced = f"```json\n{inner}\n```"
layout, ocr = parse_ai_response(fenced)
assert layout == {"regions": []}
def test_parse_markdown_code_fence_no_lang_stripped():
inner = json.dumps({"layout": {"regions": []}, "ocr": {}})
fenced = f"```\n{inner}\n```"
layout, ocr = parse_ai_response(fenced)
assert layout == {"regions": []}
def test_parse_invalid_ocr_uses_defaults():
"""Un champ OCR hors bornes (confidence > 1) → valeurs par défaut."""
raw = json.dumps({
"layout": {"regions": []},
"ocr": {"confidence": 9.9}, # confidence > 1.0 : Pydantic rejette
})
layout, ocr = parse_ai_response(raw)
assert ocr.confidence == 0.0 # valeur par défaut
def test_parse_empty_regions_list():
raw = json.dumps({"layout": {"regions": []}, "ocr": {}})
layout, _ = parse_ai_response(raw)
assert layout == {"regions": []}
# ---------------------------------------------------------------------------
# Tests — write_ai_raw / write_master_json
# ---------------------------------------------------------------------------
def test_write_ai_raw_creates_file(tmp_path):
out = tmp_path / "page" / "ai_raw.json"
write_ai_raw("raw AI text here", out)
assert out.exists()
def test_write_ai_raw_valid_json(tmp_path):
out = tmp_path / "ai_raw.json"
write_ai_raw('{"not": "valid json from AI"}', out)
content = json.loads(out.read_text(encoding="utf-8"))
assert "response_text" in content
assert content["response_text"] == '{"not": "valid json from AI"}'
def test_write_ai_raw_creates_parent_dirs(tmp_path):
out = tmp_path / "deep" / "nested" / "dir" / "ai_raw.json"
write_ai_raw("text", out)
assert out.exists()
def test_write_ai_raw_with_non_json_text(tmp_path):
"""Même si le texte brut est invalide, ai_raw.json est créé."""
out = tmp_path / "ai_raw.json"
write_ai_raw("this is not json at all", out)
content = json.loads(out.read_text(encoding="utf-8"))
assert content["response_text"] == "this is not json at all"
def _make_page_master() -> PageMaster:
return PageMaster(
page_id="test-ms-0001r",
corpus_profile="medieval-illuminated",
manuscript_id="ms-test",
folio_label="0001r",
sequence=1,
image={
"master": "https://example.com/img.jpg",
"derivative_web": "/data/deriv.jpg",
"thumbnail": "/data/thumb.jpg",
"width": 1500,
"height": 2000,
},
layout={"regions": []},
processing={
"provider": "google_ai_studio",
"model_id": "gemini-2.0-flash",
"model_display_name": "Gemini 2.0 Flash",
"prompt_version": "prompts/medieval-illuminated/primary_v1.txt",
"raw_response_path": "/data/ai_raw.json",
"processed_at": datetime.now(tz=timezone.utc),
},
)
def test_write_master_json_creates_file(tmp_path):
out = tmp_path / "master.json"
pm = _make_page_master()
write_master_json(pm, out)
assert out.exists()
def test_write_master_json_valid_json(tmp_path):
out = tmp_path / "master.json"
pm = _make_page_master()
write_master_json(pm, out)
content = json.loads(out.read_text(encoding="utf-8"))
assert content["page_id"] == "test-ms-0001r"
assert content["schema_version"] == "1.0"
def test_write_master_json_creates_parent_dirs(tmp_path):
out = tmp_path / "a" / "b" / "c" / "master.json"
write_master_json(_make_page_master(), out)
assert out.exists()
def test_write_master_json_contains_processing_info(tmp_path):
out = tmp_path / "master.json"
write_master_json(_make_page_master(), out)
content = json.loads(out.read_text(encoding="utf-8"))
assert content["processing"]["model_id"] == "gemini-2.0-flash"
assert content["processing"]["prompt_version"] == "prompts/medieval-illuminated/primary_v1.txt"
# ---------------------------------------------------------------------------
# Tests — run_primary_analysis (end-to-end mocké)
# ---------------------------------------------------------------------------
def _setup_prompt_file(tmp_path: Path, rel_path: str) -> Path:
"""Crée le fichier template dans tmp_path/rel_path."""
full = tmp_path / rel_path
full.parent.mkdir(parents=True, exist_ok=True)
full.write_text(
"Analyse {{profile_label}} en {{language_hints}} ({{script_type}}).",
encoding="utf-8",
)
return full
def _setup_derivative(tmp_path: Path) -> Path:
"""Crée un JPEG dérivé factice dans tmp_path."""
deriv = tmp_path / "derivative.jpg"
deriv.write_bytes(_make_jpeg_bytes(200, 300))
return deriv
def _make_mock_provider(ai_response_text: str) -> MagicMock:
"""Retourne un mock AIProvider dont generate_content() retourne ai_response_text."""
mock_provider = MagicMock()
mock_provider.generate_content.return_value = ai_response_text
return mock_provider
def test_run_primary_analysis_success(tmp_path):
"""Cas nominal : retourne un PageMaster, crée les deux fichiers."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
profile = _make_corpus_profile(prompt_rel_path=prompt_rel)
model_cfg = _make_model_config()
image_info = _make_image_info()
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=profile,
model_config=model_cfg,
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=image_info,
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert isinstance(result, PageMaster)
assert result.page_id == "test-corpus-0001r"
assert result.corpus_profile == "medieval-illuminated"
assert result.folio_label == "0001r"
assert result.sequence == 1
def test_run_primary_analysis_files_created(tmp_path):
"""Les deux fichiers obligatoires (R05) sont créés sur disque."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
page_dir = tmp_path / "data" / "corpora" / "test-corpus" / "pages" / "0001r"
assert (page_dir / "ai_raw.json").exists()
assert (page_dir / "master.json").exists()
def test_run_primary_analysis_raw_written_before_parse(tmp_path):
"""ai_raw.json est écrit AVANT que le parsing échoue (R05)."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
mock_provider = _make_mock_provider("this is definitely not json {{{{")
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
with pytest.raises(ParseError):
run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
# ai_raw.json existe malgré l'échec de parsing
raw_path = tmp_path / "data" / "corpora" / "test-corpus" / "pages" / "0001r" / "ai_raw.json"
assert raw_path.exists()
# master.json N'existe PAS (parsing a échoué)
master_path = tmp_path / "data" / "corpora" / "test-corpus" / "pages" / "0001r" / "master.json"
assert not master_path.exists()
def test_run_primary_analysis_processing_info(tmp_path):
"""ProcessingInfo contient le bon model_id et prompt_version."""
prompt_rel = "prompts/test-profile/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
profile = _make_corpus_profile(
profile_id="test-profile",
prompt_rel_path=prompt_rel,
)
model_cfg = _make_model_config()
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=profile,
model_config=model_cfg,
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert result.processing is not None
assert result.processing.model_id == "gemini-2.0-flash"
assert result.processing.model_display_name == "Gemini 2.0 Flash"
assert result.processing.prompt_version == prompt_rel
def test_run_primary_analysis_image_dict(tmp_path):
"""Le dict image du PageMaster reprend les données de ImageDerivativeInfo."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
image_info = _make_image_info()
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=image_info,
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert result.image.master == image_info.original_url
# L'analyzer stocke désormais les dimensions originales (pas celles du dérivé)
assert result.image.width == image_info.original_width
assert result.image.height == image_info.original_height
def test_run_primary_analysis_regions_in_layout(tmp_path):
"""Les régions valides de la réponse IA sont dans layout du PageMaster."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert len(result.layout["regions"]) == 2
def test_run_primary_analysis_prompt_rendered_with_profile(tmp_path):
"""Le prompt envoyé à l'IA contient les valeurs du profil substituées."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
tpl = tmp_path / prompt_rel
tpl.parent.mkdir(parents=True, exist_ok=True)
tpl.write_text("Profil: {{profile_label}} | Script: {{script_type}}")
deriv_path = _setup_derivative(tmp_path)
mock_provider = _make_mock_provider(_valid_ai_json())
profile = _make_corpus_profile(prompt_rel_path=prompt_rel)
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=profile,
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
# Vérifier que generate_content a été appelé avec le prompt rendu
call_args = mock_provider.generate_content.call_args
prompt_sent = call_args.kwargs.get("prompt") or call_args.args[1]
assert "Manuscrit médiéval enluminé" in prompt_sent
assert "caroline" in prompt_sent
assert "{{profile_label}}" not in prompt_sent
def test_run_primary_analysis_prompt_not_found_raises(tmp_path):
"""FileNotFoundError si le template de prompt n'existe pas."""
deriv_path = _setup_derivative(tmp_path)
profile = _make_corpus_profile(prompt_rel_path="prompts/nonexistent/prompt.txt")
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
with pytest.raises(FileNotFoundError):
run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=profile,
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
def test_run_primary_analysis_ocr_in_result(tmp_path):
"""Le résultat OCR est bien présent dans le PageMaster."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert result.ocr is not None
assert result.ocr.diplomatic_text == "Incipit liber beati Ieronimi"
assert result.ocr.language == "la"
def test_run_primary_analysis_editorial_status_machine_draft(tmp_path):
"""Le statut éditorial initial est machine_draft."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert result.editorial.status.value == "machine_draft"
def test_run_primary_analysis_master_json_content(tmp_path):
"""Le master.json écrit sur disque est un JSON valide avec schema_version."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
master_path = tmp_path / "data" / "corpora" / "test-corpus" / "pages" / "0001r" / "master.json"
content = json.loads(master_path.read_text(encoding="utf-8"))
assert content["schema_version"] == "1.0"
assert content["page_id"] == "test-corpus-0001r"
def test_run_primary_analysis_invalid_region_skipped(tmp_path):
"""Une région invalide dans la réponse IA est ignorée sans lever d'exception."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
deriv_path = _setup_derivative(tmp_path)
response_with_bad_region = json.dumps({
"layout": {"regions": [
{"id": "r_good", "type": "text_block", "bbox": [0, 0, 100, 100], "confidence": 0.9},
{"id": "r_bad", "type": "text_block", "bbox": [-1, 0, 100, 100], "confidence": 0.9},
]},
"ocr": {},
})
mock_provider = _make_mock_provider(response_with_bad_region)
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_path=deriv_path,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-corpus-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert len(result.layout["regions"]) == 1
assert result.layout["regions"][0]["id"] == "r_good"
# ---------------------------------------------------------------------------
# Mode IIIF natif — bytes en mémoire
# ---------------------------------------------------------------------------
from app.schemas.image import ImageSourceInfo
def _make_image_source_info() -> ImageSourceInfo:
return ImageSourceInfo(
original_url="https://gallica.bnf.fr/iiif/ark:/12148/btv1b8432314s/f29/full/max/0/default.jpg",
iiif_service_url="https://gallica.bnf.fr/iiif/ark:/12148/btv1b8432314s/f29",
manifest_url="https://gallica.bnf.fr/iiif/ark:/12148/btv1b8432314s/manifest.json",
is_iiif=True,
original_width=3543,
original_height=4724,
)
def test_run_primary_analysis_iiif_bytes_mode(tmp_path):
"""Mode IIIF natif : passe des bytes directement, pas de chemin fichier."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
jpeg_bytes = _make_jpeg_bytes(200, 300)
mock_provider = _make_mock_provider(_valid_ai_json())
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_bytes=jpeg_bytes,
derivative_width=200,
derivative_height=300,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-iiif-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=_make_image_source_info(),
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
assert result.image.iiif_service_url == "https://gallica.bnf.fr/iiif/ark:/12148/btv1b8432314s/f29"
assert result.image.manifest_url is not None
assert result.image.derivative_web is None
assert result.image.width == 3543 # dimensions originales, pas dérivé
assert result.image.height == 4724
def test_run_primary_analysis_iiif_bbox_scaling(tmp_path):
"""Les bbox sont mises à l'échelle du dérivé vers le canvas original."""
prompt_rel = "prompts/medieval-illuminated/primary_v1.txt"
_setup_prompt_file(tmp_path, prompt_rel)
# Image source : 4000x6000 original, dérivé 1000x1500
source_info = ImageSourceInfo(
original_url="https://example.com/img",
iiif_service_url="https://example.com/img",
is_iiif=True,
original_width=4000,
original_height=6000,
)
# Réponse IA avec bbox dans l'espace du dérivé (1000x1500)
ai_response = json.dumps({
"layout": {"regions": [
{"id": "r1", "type": "text_block", "bbox": [100, 200, 500, 300], "confidence": 0.9},
]},
"ocr": {"diplomatic_text": "test", "language": "la", "confidence": 0.8},
})
mock_provider = _make_mock_provider(ai_response)
with patch("app.services.ai.analyzer.get_provider", return_value=mock_provider):
result = run_primary_analysis(
derivative_image_bytes=_make_jpeg_bytes(100, 150),
derivative_width=1000,
derivative_height=1500,
corpus_profile=_make_corpus_profile(prompt_rel_path=prompt_rel),
model_config=_make_model_config(),
page_id="test-scale-0001r",
manuscript_id="ms-test",
corpus_slug="test-corpus",
folio_label="0001r",
sequence=1,
image_info=source_info,
base_data_dir=tmp_path / "data",
project_root=tmp_path,
)
# Scale factor : 4000/1000 = 4.0, 6000/1500 = 4.0
bbox = result.layout["regions"][0]["bbox"]
assert bbox == [400, 800, 2000, 1200] # 100*4, 200*4, 500*4, 300*4
|