File size: 13,094 Bytes
ed52286
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
0341500
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
ed52286
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
0341500
 
ed52286
 
 
 
0341500
 
 
 
 
ed52286
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
0341500
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
"""
Tests des endpoints /api/v1/jobs et /api/v1/corpora/{id}/run (Sprint 4 — Session B).

Vérifie :
- POST /api/v1/corpora/{id}/run → 202 + jobs_created + job_ids
- POST /api/v1/pages/{id}/run   → 202 + job unique
- GET  /api/v1/jobs/{job_id}    → 200 ou 404
- POST /api/v1/jobs/{job_id}/retry → 200 (FAILED) ou 409 (autre statut)
- Isolation : corpus/page inexistants → 404
"""
# 1. stdlib
import uuid
from datetime import datetime, timezone

# 2. third-party
import pytest

# 3. local
from app.models.corpus import CorpusModel, ManuscriptModel, PageModel
from app.models.job import JobModel
from tests.conftest_api import async_client, db_session  # noqa: F401

_NOW = datetime.now(timezone.utc)


# ---------------------------------------------------------------------------
# Helpers — création de données de test
# ---------------------------------------------------------------------------

async def _make_corpus(db, slug="test-c"):
    corpus = CorpusModel(
        id=str(uuid.uuid4()), slug=slug, title="Test", profile_id="medieval-illuminated",
        created_at=_NOW, updated_at=_NOW,
    )
    db.add(corpus)
    await db.commit()
    await db.refresh(corpus)
    return corpus


async def _make_manuscript(db, corpus_id):
    ms = ManuscriptModel(
        id=str(uuid.uuid4()), corpus_id=corpus_id, title="MS", total_pages=0,
    )
    db.add(ms)
    await db.commit()
    await db.refresh(ms)
    return ms


async def _make_page(db, ms_id, folio="f001r", seq=1):
    page = PageModel(
        id=str(uuid.uuid4()), manuscript_id=ms_id, folio_label=folio,
        sequence=seq, processing_status="INGESTED",
    )
    db.add(page)
    await db.commit()
    await db.refresh(page)
    return page


async def _make_failed_job(db, corpus_id, page_id=None):
    """Crée un job en état FAILED pour tester retry."""
    job = JobModel(
        id=str(uuid.uuid4()),
        corpus_id=corpus_id,
        page_id=page_id,
        status="failed",
        error_message="Simulated failure",
        created_at=_NOW,
    )
    db.add(job)
    await db.commit()
    await db.refresh(job)
    return job


async def _make_job(db, corpus_id, page_id=None, status="pending"):
    """Crée un job avec un statut arbitraire."""
    job = JobModel(
        id=str(uuid.uuid4()),
        corpus_id=corpus_id,
        page_id=page_id,
        status=status,
        error_message="err" if status == "failed" else None,
        created_at=_NOW,
    )
    db.add(job)
    await db.commit()
    await db.refresh(job)
    return job


# ---------------------------------------------------------------------------
# POST /api/v1/corpora/{id}/run
# ---------------------------------------------------------------------------

@pytest.mark.asyncio
async def test_run_corpus_not_found(async_client):
    response = await async_client.post("/api/v1/corpora/nonexistent/run")
    assert response.status_code == 404


@pytest.mark.asyncio
async def test_run_corpus_no_pages(async_client, db_session):
    """Corpus sans pages → 202, jobs_created = 0."""
    corpus = await _make_corpus(db_session)
    response = await async_client.post(f"/api/v1/corpora/{corpus.id}/run")
    assert response.status_code == 202
    data = response.json()
    assert data["jobs_created"] == 0
    assert data["job_ids"] == []
    assert data["corpus_id"] == corpus.id


@pytest.mark.asyncio
async def test_run_corpus_creates_jobs_per_page(async_client, db_session):
    """Corpus avec 3 pages → 3 jobs créés."""
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    for i in range(3):
        await _make_page(db_session, ms.id, folio=f"f{i+1:03d}r", seq=i + 1)

    response = await async_client.post(f"/api/v1/corpora/{corpus.id}/run")
    assert response.status_code == 202
    data = response.json()
    assert data["jobs_created"] == 3
    assert len(data["job_ids"]) == 3


@pytest.mark.asyncio
async def test_run_corpus_job_ids_are_unique(async_client, db_session):
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    for i in range(2):
        await _make_page(db_session, ms.id, folio=f"f{i+1:03d}r", seq=i + 1)

    data = (await async_client.post(f"/api/v1/corpora/{corpus.id}/run")).json()
    assert len(set(data["job_ids"])) == 2  # all unique


@pytest.mark.asyncio
async def test_run_corpus_jobs_are_pending(async_client, db_session):
    """Les jobs créés par corpus.run ont le statut 'pending'."""
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    await _make_page(db_session, ms.id)

    run_data = (await async_client.post(f"/api/v1/corpora/{corpus.id}/run")).json()
    job_id = run_data["job_ids"][0]

    job_data = (await async_client.get(f"/api/v1/jobs/{job_id}")).json()
    assert job_data["status"] == "pending"


# ---------------------------------------------------------------------------
# POST /api/v1/pages/{id}/run
# ---------------------------------------------------------------------------

@pytest.mark.asyncio
async def test_run_page_not_found(async_client):
    response = await async_client.post("/api/v1/pages/nonexistent/run")
    assert response.status_code == 404


@pytest.mark.asyncio
async def test_run_page_creates_job(async_client, db_session):
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)

    response = await async_client.post(f"/api/v1/pages/{page.id}/run")
    assert response.status_code == 202


@pytest.mark.asyncio
async def test_run_page_job_fields(async_client, db_session):
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)

    data = (await async_client.post(f"/api/v1/pages/{page.id}/run")).json()
    assert data["page_id"] == page.id
    assert data["corpus_id"] == corpus.id
    assert data["status"] == "pending"
    assert data["started_at"] is None
    assert data["finished_at"] is None
    assert data["error_message"] is None


@pytest.mark.asyncio
async def test_run_page_job_id_is_uuid(async_client, db_session):
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)

    data = (await async_client.post(f"/api/v1/pages/{page.id}/run")).json()
    assert len(data["id"]) == 36


@pytest.mark.asyncio
async def test_run_page_duplicate_blocked(async_client, db_session):
    """Lancer run sur la même page deux fois → 409 sur la seconde tentative."""
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)

    r1 = await async_client.post(f"/api/v1/pages/{page.id}/run")
    assert r1.status_code == 202

    r2 = await async_client.post(f"/api/v1/pages/{page.id}/run")
    assert r2.status_code == 409


# ---------------------------------------------------------------------------
# GET /api/v1/jobs/{job_id}
# ---------------------------------------------------------------------------

@pytest.mark.asyncio
async def test_get_job_not_found(async_client):
    response = await async_client.get("/api/v1/jobs/nonexistent")
    assert response.status_code == 404


@pytest.mark.asyncio
async def test_get_job_ok(async_client, db_session):
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)

    run_data = (await async_client.post(f"/api/v1/pages/{page.id}/run")).json()
    job_id = run_data["id"]

    response = await async_client.get(f"/api/v1/jobs/{job_id}")
    assert response.status_code == 200
    assert response.json()["id"] == job_id


@pytest.mark.asyncio
async def test_get_job_fields(async_client, db_session):
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)

    run_data = (await async_client.post(f"/api/v1/pages/{page.id}/run")).json()
    data = (await async_client.get(f"/api/v1/jobs/{run_data['id']}")).json()

    assert "status" in data
    assert "corpus_id" in data
    assert "page_id" in data
    assert "created_at" in data


# ---------------------------------------------------------------------------
# POST /api/v1/jobs/{job_id}/retry
# ---------------------------------------------------------------------------

@pytest.mark.asyncio
async def test_retry_job_not_found(async_client):
    response = await async_client.post("/api/v1/jobs/nonexistent/retry")
    assert response.status_code == 404


@pytest.mark.asyncio
async def test_retry_pending_job_409(async_client, db_session):
    """Un job en état 'pending' ne peut pas être relancé."""
    corpus = await _make_corpus(db_session)
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)

    job_data = (await async_client.post(f"/api/v1/pages/{page.id}/run")).json()
    response = await async_client.post(f"/api/v1/jobs/{job_data['id']}/retry")
    assert response.status_code == 409


@pytest.mark.asyncio
async def test_retry_failed_job_ok(async_client, db_session):
    """Un job en état 'failed' peut être relancé → status passe à 'pending'."""
    corpus = await _make_corpus(db_session)
    job = await _make_failed_job(db_session, corpus.id)

    response = await async_client.post(f"/api/v1/jobs/{job.id}/retry")
    assert response.status_code == 200
    data = response.json()
    assert data["status"] == "pending"


@pytest.mark.asyncio
async def test_retry_failed_job_clears_error(async_client, db_session):
    corpus = await _make_corpus(db_session)
    job = await _make_failed_job(db_session, corpus.id)

    data = (await async_client.post(f"/api/v1/jobs/{job.id}/retry")).json()
    assert data["error_message"] is None
    assert data["started_at"] is None
    assert data["finished_at"] is None


@pytest.mark.asyncio
async def test_retry_failed_job_is_retrievable(async_client, db_session):
    """Après retry, GET /jobs/{id} reflète le nouveau statut."""
    corpus = await _make_corpus(db_session)
    job = await _make_failed_job(db_session, corpus.id)

    await async_client.post(f"/api/v1/jobs/{job.id}/retry")
    data = (await async_client.get(f"/api/v1/jobs/{job.id}")).json()
    assert data["status"] == "pending"


# ---------------------------------------------------------------------------
# Rate-limiting guards — duplicate pipeline runs
# ---------------------------------------------------------------------------

@pytest.mark.asyncio
async def test_run_corpus_rejects_if_active_jobs(async_client, db_session):
    """409 si le corpus a déjà un job pending/claimed/running."""
    corpus = await _make_corpus(db_session, slug="guard-c1")
    ms = await _make_manuscript(db_session, corpus.id)
    await _make_page(db_session, ms.id)
    # Injecter un job pending directement en base
    await _make_job(db_session, corpus.id, status="pending")

    response = await async_client.post(f"/api/v1/corpora/{corpus.id}/run")
    assert response.status_code == 409
    assert "déjà en cours" in response.json()["detail"]


@pytest.mark.asyncio
async def test_run_page_rejects_if_active_job(async_client, db_session):
    """409 si la page a déjà un job running."""
    corpus = await _make_corpus(db_session, slug="guard-p1")
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)
    # Injecter un job running directement en base
    await _make_job(db_session, corpus.id, page_id=page.id, status="running")

    response = await async_client.post(f"/api/v1/pages/{page.id}/run")
    assert response.status_code == 409
    assert "déjà en cours" in response.json()["detail"]


@pytest.mark.asyncio
async def test_run_corpus_allows_after_all_done(async_client, db_session):
    """202 si tous les jobs existants du corpus sont terminés (done)."""
    corpus = await _make_corpus(db_session, slug="guard-c2")
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)
    # Injecter des jobs terminés
    await _make_job(db_session, corpus.id, page_id=page.id, status="done")
    await _make_job(db_session, corpus.id, page_id=page.id, status="done")

    response = await async_client.post(f"/api/v1/corpora/{corpus.id}/run")
    assert response.status_code == 202


@pytest.mark.asyncio
async def test_run_page_allows_after_failed(async_client, db_session):
    """202 si le seul job existant pour la page est failed."""
    corpus = await _make_corpus(db_session, slug="guard-p2")
    ms = await _make_manuscript(db_session, corpus.id)
    page = await _make_page(db_session, ms.id)
    # Injecter un job échoué
    await _make_job(db_session, corpus.id, page_id=page.id, status="failed")

    response = await async_client.post(f"/api/v1/pages/{page.id}/run")
    assert response.status_code == 202