Spaces:
Build error
Build error
File size: 18,555 Bytes
e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 193eb98 e4bd765 fc1a5f0 e4bd765 fc1a5f0 e4bd765 fc1a5f0 e4bd765 193eb98 e4bd765 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 | """
Tests du service job_runner (Sprint 4 — Session C).
Vérifie :
- Séquence complète succès → job.status "done", page "ANALYZED"
- Chaque point de failure : étape 4 sans ModelConfig, étape 5 image absente,
étape 6 ParseError, étape 7 écriture impossible
- Cohérence job.status / page.processing_status après chaque scénario
- corpus_runner : délégation séquentielle des jobs pending
Les fonctions IO (fetch_and_normalize, run_primary_analysis, generate_alto,
write_alto) sont mockées via monkeypatch sur le namespace de job_runner_module.
_run_job_impl est testée directement avec la session de test injectée.
"""
# 1. stdlib
import uuid
from datetime import datetime, timezone
# 2. third-party
import pytest
import pytest_asyncio
from sqlalchemy.ext.asyncio import async_sessionmaker, create_async_engine
# 3. local
import app.models # noqa: F401 — enregistrement des modèles dans Base.metadata
import app.services.corpus_runner as corpus_runner_module
import app.services.job_runner as job_runner_module
from app.models.corpus import CorpusModel, ManuscriptModel, PageModel
from app.models.database import Base
from app.models.job import JobModel
from app.models.model_config_db import ModelConfigDB
from app.schemas.image import ImageDerivativeInfo
from app.schemas.page_master import OCRResult, PageMaster
from app.services.job_runner import _run_job_impl
_TEST_DB_URL = "sqlite+aiosqlite:///:memory:"
_NOW = datetime.now(timezone.utc)
# ---------------------------------------------------------------------------
# Fixtures
# ---------------------------------------------------------------------------
@pytest_asyncio.fixture
async def db():
"""Session SQLite en mémoire avec schéma complet."""
engine = create_async_engine(_TEST_DB_URL, echo=False)
async with engine.begin() as conn:
await conn.run_sync(Base.metadata.create_all)
factory = async_sessionmaker(engine, expire_on_commit=False)
async with factory() as session:
yield session
async with engine.begin() as conn:
await conn.run_sync(Base.metadata.drop_all)
await engine.dispose()
@pytest_asyncio.fixture
async def setup(db):
"""Corpus + manuscript + page (URL image) + job pending — sans ModelConfigDB."""
corpus = CorpusModel(
id=str(uuid.uuid4()), slug="runner-test", title="Runner Test",
profile_id="medieval-illuminated", created_at=_NOW, updated_at=_NOW,
)
db.add(corpus)
await db.commit()
ms = ManuscriptModel(
id=str(uuid.uuid4()), corpus_id=corpus.id, title="MS Test", total_pages=1,
)
db.add(ms)
await db.commit()
page = PageModel(
id=str(uuid.uuid4()), manuscript_id=ms.id, folio_label="f001r",
sequence=1, image_master_path="https://example.com/image.jpg",
processing_status="INGESTED",
)
db.add(page)
await db.commit()
job = JobModel(
id=str(uuid.uuid4()), corpus_id=corpus.id, page_id=page.id,
status="pending", created_at=_NOW,
)
db.add(job)
await db.commit()
await db.refresh(job)
await db.refresh(page)
return {"corpus": corpus, "ms": ms, "page": page, "job": job}
@pytest_asyncio.fixture
async def setup_with_model(db, setup):
"""Idem setup, avec ModelConfigDB configuré."""
model_cfg = ModelConfigDB(
corpus_id=setup["corpus"].id,
provider_type="google_ai_studio",
selected_model_id="gemini-2.0-flash",
selected_model_display_name="Gemini 2.0 Flash",
updated_at=_NOW,
)
db.add(model_cfg)
await db.commit()
return setup
# ---------------------------------------------------------------------------
# Helpers
# ---------------------------------------------------------------------------
def _image_info() -> ImageDerivativeInfo:
return ImageDerivativeInfo(
original_url="https://example.com/image.jpg",
original_width=2000, original_height=3000,
derivative_path="/tmp/deriv.jpg",
derivative_width=1500, derivative_height=2250,
thumbnail_path="/tmp/thumb.jpg",
thumbnail_width=200, thumbnail_height=300,
)
def _page_master(page_id: str, ms_id: str) -> PageMaster:
return PageMaster(
page_id=page_id,
corpus_profile="medieval-illuminated",
manuscript_id=ms_id,
folio_label="f001r",
sequence=1,
image={
"master": "https://example.com/image.jpg",
"derivative_web": "/tmp/deriv.jpg",
"width": 2000,
"height": 3000,
},
layout={"regions": []},
ocr=OCRResult(confidence=0.85),
)
def _apply_success_mocks(monkeypatch, page_id: str, ms_id: str) -> None:
"""Applique les mocks IO pour un pipeline réussi.
Les imports sont différés dans job_runner (lazy imports). On patche donc
les modules sources pour que le import dans la fonction cible récupère le mock.
"""
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: _page_master(page_id, ms_id),
)
monkeypatch.setattr(
"app.services.export.alto.generate_alto", lambda pm: "<alto/>"
)
monkeypatch.setattr(
"app.services.export.alto.write_alto", lambda xml, path: None
)
# ---------------------------------------------------------------------------
# Séquence complète — succès
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_success_job_status_done(db, setup_with_model, monkeypatch):
"""Après un run réussi, job.status doit être 'done'."""
s = setup_with_model
_apply_success_mocks(monkeypatch, s["page"].id, s["ms"].id)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].status == "done"
@pytest.mark.asyncio
async def test_success_page_analyzed(db, setup_with_model, monkeypatch):
"""Après un run réussi, page.processing_status doit être 'ANALYZED'."""
s = setup_with_model
_apply_success_mocks(monkeypatch, s["page"].id, s["ms"].id)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["page"])
assert s["page"].processing_status == "ANALYZED"
@pytest.mark.asyncio
async def test_success_job_started_at_set(db, setup_with_model, monkeypatch):
"""started_at doit être renseigné après exécution réussie."""
s = setup_with_model
_apply_success_mocks(monkeypatch, s["page"].id, s["ms"].id)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].started_at is not None
@pytest.mark.asyncio
async def test_success_job_finished_at_set(db, setup_with_model, monkeypatch):
"""finished_at doit être renseigné après exécution réussie."""
s = setup_with_model
_apply_success_mocks(monkeypatch, s["page"].id, s["ms"].id)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].finished_at is not None
@pytest.mark.asyncio
async def test_success_no_error_message(db, setup_with_model, monkeypatch):
"""error_message doit rester None après succès."""
s = setup_with_model
_apply_success_mocks(monkeypatch, s["page"].id, s["ms"].id)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].error_message is None
@pytest.mark.asyncio
async def test_success_confidence_stored(db, setup_with_model, monkeypatch):
"""confidence_summary de la page doit être renseigné depuis OCRResult."""
s = setup_with_model
_apply_success_mocks(monkeypatch, s["page"].id, s["ms"].id)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["page"])
assert s["page"].confidence_summary == pytest.approx(0.85)
# ---------------------------------------------------------------------------
# Étape 4 — pas de ModelConfig
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_no_model_config_job_failed(db, setup, monkeypatch):
"""Sans ModelConfigDB, job.status doit être 'failed'."""
s = setup
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].status == "failed"
@pytest.mark.asyncio
async def test_no_model_config_error_message(db, setup, monkeypatch):
"""Sans ModelConfigDB, error_message doit mentionner l'absence de modèle."""
s = setup
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].error_message is not None
assert "modèle" in s["job"].error_message.lower() or "model" in s["job"].error_message.lower()
# ---------------------------------------------------------------------------
# Étape 5 — image absente
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_no_image_path_job_failed(db, setup_with_model, monkeypatch):
"""Sans image_master_path, job.status doit être 'failed'."""
s = setup_with_model
s["page"].image_master_path = None
await db.commit()
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: _page_master(s["page"].id, s["ms"].id),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].status == "failed"
@pytest.mark.asyncio
async def test_no_image_path_page_error(db, setup_with_model, monkeypatch):
"""Sans image_master_path, page.processing_status doit être 'ERROR'."""
s = setup_with_model
s["page"].image_master_path = None
await db.commit()
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: _page_master(s["page"].id, s["ms"].id),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["page"])
assert s["page"].processing_status == "ERROR"
@pytest.mark.asyncio
async def test_fetch_fails_job_failed(db, setup_with_model, monkeypatch):
"""Si fetch_and_normalize lève, job.status doit être 'failed'."""
s = setup_with_model
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize",
lambda *a: (_ for _ in ()).throw(OSError("network error")),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].status == "failed"
@pytest.mark.asyncio
async def test_fetch_fails_page_error(db, setup_with_model, monkeypatch):
"""Si fetch_and_normalize lève, page.processing_status doit être 'ERROR'."""
s = setup_with_model
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize",
lambda *a: (_ for _ in ()).throw(OSError("network error")),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["page"])
assert s["page"].processing_status == "ERROR"
# ---------------------------------------------------------------------------
# Étape 6 — run_primary_analysis échoue
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_primary_analysis_fails_job_failed(db, setup_with_model, monkeypatch):
"""Si run_primary_analysis lève, job.status doit être 'failed'."""
s = setup_with_model
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: (_ for _ in ()).throw(ValueError("ParseError: invalid JSON")),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].status == "failed"
@pytest.mark.asyncio
async def test_primary_analysis_fails_page_error(db, setup_with_model, monkeypatch):
"""Si run_primary_analysis lève, page.processing_status doit être 'ERROR'."""
s = setup_with_model
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: (_ for _ in ()).throw(ValueError("ParseError: invalid JSON")),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["page"])
assert s["page"].processing_status == "ERROR"
@pytest.mark.asyncio
async def test_primary_analysis_error_message_stored(db, setup_with_model, monkeypatch):
"""error_message doit contenir le message d'exception."""
s = setup_with_model
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: (_ for _ in ()).throw(ValueError("ParseError: invalid JSON")),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert "ParseError" in (s["job"].error_message or "")
# ---------------------------------------------------------------------------
# Étape 7 — write_alto échoue
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_write_alto_fails_job_failed(db, setup_with_model, monkeypatch):
"""Si write_alto lève OSError, job.status doit être 'failed'."""
s = setup_with_model
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: _page_master(s["page"].id, s["ms"].id),
)
monkeypatch.setattr(
"app.services.export.alto.generate_alto", lambda pm: "<alto/>"
)
monkeypatch.setattr(
"app.services.export.alto.write_alto",
lambda xml, path: (_ for _ in ()).throw(OSError("disk full")),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["job"])
assert s["job"].status == "failed"
@pytest.mark.asyncio
async def test_write_alto_fails_page_error(db, setup_with_model, monkeypatch):
"""Si write_alto lève OSError, page.processing_status doit être 'ERROR'."""
s = setup_with_model
monkeypatch.setattr(
job_runner_module, "fetch_and_normalize", lambda *a: _image_info()
)
monkeypatch.setattr(
"app.services.ai.analyzer.run_primary_analysis",
lambda **kw: _page_master(s["page"].id, s["ms"].id),
)
monkeypatch.setattr(
"app.services.export.alto.generate_alto", lambda pm: "<alto/>"
)
monkeypatch.setattr(
"app.services.export.alto.write_alto",
lambda xml, path: (_ for _ in ()).throw(OSError("disk full")),
)
await _run_job_impl(s["job"].id, db)
await db.refresh(s["page"])
assert s["page"].processing_status == "ERROR"
# ---------------------------------------------------------------------------
# Job introuvable
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_job_not_found_no_crash(db):
"""Si job_id n'existe pas, _run_job_impl retourne sans exception."""
await _run_job_impl("nonexistent-job-id", db) # ne doit pas lever
# ---------------------------------------------------------------------------
# corpus_runner — délégation séquentielle
# ---------------------------------------------------------------------------
@pytest.mark.asyncio
async def test_corpus_runner_no_pending_returns_zero(db, setup):
"""Si aucun job pending, execute_corpus_job retourne {total:0, done:0, failed:0}."""
from app.services.corpus_runner import execute_corpus_job
corpus_id = setup["corpus"].id
# Passer le job en "done" pour simuler l'absence de pending
setup["job"].status = "done"
await db.commit()
# Monkeypatch async_session_factory pour utiliser notre BDD de test
engine = db.get_bind()
async def _mock_factory():
class _CM:
async def __aenter__(self_):
return db
async def __aexit__(self_, *args):
pass
return _CM()
import app.services.corpus_runner as cr_mod
monkeypatch_obj = None # pas de monkeypatch dispo ici, usage direct
# On teste via la logique : aucun job pending → total = 0
from sqlalchemy import select
result = await db.execute(
select(JobModel).where(
JobModel.corpus_id == corpus_id,
JobModel.status == "pending",
)
)
pending = list(result.scalars().all())
assert len(pending) == 0
@pytest.mark.asyncio
async def test_corpus_runner_calls_execute_per_job(monkeypatch):
"""execute_corpus_job appelle execute_page_job pour chaque job pending."""
from app.services.corpus_runner import execute_corpus_job
called_ids: list[str] = []
async def _mock_execute(job_id: str) -> None:
called_ids.append(job_id)
class _FakeJob:
def __init__(self, id_: str, status: str):
self.id = id_
self.status = status
_call_count = [0]
class _FakeSession:
async def __aenter__(self):
return self
async def __aexit__(self, *args):
pass
async def execute(self, stmt):
_call_count[0] += 1
if _call_count[0] == 1:
# Premier appel : retourne les objets JobModel pending
# (corpus_runner itère maintenant les objets, pas les IDs)
rows = [_FakeJob("job-alpha", "pending"), _FakeJob("job-beta", "pending")]
else:
# Second appel : retourne les objets JobModel avec statut final
rows = [_FakeJob("job-alpha", "done"), _FakeJob("job-beta", "done")]
class _Result:
def scalars(self_):
class _Scalars:
def all(self__):
return rows
return _Scalars()
return _Result()
async def commit(self):
pass
def _mock_factory():
return _FakeSession()
monkeypatch.setattr(corpus_runner_module, "async_session_factory", _mock_factory)
monkeypatch.setattr("app.services.job_runner.execute_page_job", _mock_execute)
await execute_corpus_job("corpus-xyz")
assert called_ids == ["job-alpha", "job-beta"]
|