fix saving bug

app.py

@@ -7,6 +7,7 @@ side-by-side with shuffled anonymous labels, and collects preference ordering.
 """
 
 import json
+import logging
 import os
 import random
 import threading
@@ -17,6 +18,12 @@ from typing import Any, Dict, List, Optional, Tuple
 import gradio as gr
 from huggingface_hub import CommitScheduler, snapshot_download
 
+logging.getLogger("huggingface_hub._commit_scheduler").setLevel(logging.DEBUG)
+logging.basicConfig(
+    format="%(asctime)s [%(name)s] %(levelname)s: %(message)s",
+    level=logging.INFO,
+)
+
 # ============================================================================
 # Configuration
 # ============================================================================
@@ -157,11 +164,6 @@ def get_reference_portraits(story_id: str) -> List[Tuple[str, str]]:
 _save_lock = threading.Lock()
 
 
-def _get_lock():
-    """Return the scheduler lock if available, otherwise use the local lock."""
-    return scheduler.lock if scheduler is not None else _save_lock
-
-
 # ============================================================================
 # Group Management
 # ============================================================================
@@ -247,13 +249,25 @@ def create_group_config(group_id: str) -> Dict[str, Any]:
         "method_display_map": method_display_map,
     }
 
-    with _get_lock():
+    with _save_lock:
         with open(group_dir / "mapping.json", "w", encoding="utf-8") as f:
             json.dump(config, f, indent=2, ensure_ascii=False)
 
     return config
 
 
+def _on_push_done(future):
+    """Callback to surface push results/errors from the background thread."""
+    try:
+        result = future.result()
+        if result:
+            print(f"[CommitScheduler] Push succeeded: {result.commit_url}")
+        else:
+            print("[CommitScheduler] Push skipped: no changed files detected")
+    except Exception as e:
+        print(f"[CommitScheduler] Push FAILED: {e}")
+
+
 def save_ranking_result(
     group_id: str,
     story_id: str,
@@ -263,7 +277,6 @@ def save_ranking_result(
     comment: str,
 ) -> str:
     """Save a preference ranking result to JSON. Returns a status message."""
-    print(f"Saving result to {group_id}, {story_id}, {evaluator_id}, {method_display_map}, {ranking}, {comment}")
     group_dir = Path(OUTPUT_DIR) / f"group_{group_id}"
     story_dir = group_dir / story_id
     filename = f"{story_id}_{evaluator_id}.json"
@@ -279,12 +292,20 @@ def save_ranking_result(
     }
 
     filepath = story_dir / filename
-    with _get_lock():
+    with _save_lock:
         story_dir.mkdir(parents=True, exist_ok=True)
         with open(filepath, "w", encoding="utf-8") as f:
-            print(f"Saving result to {filepath}. Result data: {result_data}")
             json.dump(result_data, f, indent=4, ensure_ascii=False)
 
+    print(f"[Save] Written {filepath}")
+
+    if scheduler is not None:
+        print("[CommitScheduler] Triggering immediate push after save ...")
+        future = scheduler.trigger()
+        future.add_done_callback(_on_push_done)
+    else:
+        print("[CommitScheduler] WARNING: scheduler is None — RESULTS_REPO_ID not set?")
+
     return f"Saved to {filepath}"