Refactor grab_contest_data function to improve position handling

- Updated the logic for checking player ID and position counts to use actual positions, enhancing accuracy in data validation.
- Simplified the combination of player positions and IDs for clearer output formatting.
- These changes contribute to ongoing efforts to enhance data integrity and improve user experience within the application.

global_func/grab_contest_data.py

@@ -14,16 +14,19 @@ def grab_contest_data(sport, contest_name, contest_id_map, contest_date):
         # Remove the leading colon and split by the remaining colons
         player_ids = lineup_hash.lstrip(':').split(':')
         
+        # Get the actual positions needed for this lineup
+        actual_positions = positions[:len(player_ids)]
+        
         # Check if the number of IDs matches the number of positions
-        if len(player_ids) != len(positions):
-            print(f"Warning: Mismatch for hash {lineup_hash}. IDs: {len(player_ids)}, Positions: {len(positions)}")
+        if len(player_ids) != len(actual_positions):
+            print(f"Warning: Mismatch for hash {lineup_hash}. IDs: {len(player_ids)}, Positions: {len(actual_positions)}")
             return lineup_hash
 
-        # Map each player ID to their name and combine with position
-        mapped_parts = [pos + pid_map.get(pid, pid) for pos, pid in zip(positions, player_ids)]
+        # Combine positions and player IDs
+        combined_parts = [pos + pid_map.get(pid, pid) for pos, pid in zip(actual_positions, player_ids)]
         
         # Join them into a single string
-        return "".join(mapped_parts)
+        return "".join(combined_parts)
 
     lineups_json = requests.get(lineups_url).json()
     data_json = requests.get(data_url).json()