Refactor sport and game type handling in app.py for consistency

- Updated the code to use local variables for sport and game type selections, ensuring consistent access across different components.
- This change enhances code readability and prepares for future improvements in user interaction and data management.

app.py

@@ -185,10 +185,10 @@ if selected_tab == 'Data Load':
         sport_options, date_options = st.columns(2)
         parse_type = 'Manual'
         with sport_options:
-            sport_select = st.selectbox("Select Sport", ['MLB', 'MMA', 'GOLF', 'NBA', 'NHL', 'WNBA', 'NAS'], key='sport_select')
-            type_var = st.selectbox("Select Game Type", ['Classic', 'Showdown'], key='type_var')
+            sport_init = st.selectbox("Select Sport", ['MLB', 'MMA', 'GOLF', 'NBA', 'NHL', 'WNBA', 'NAS'], key='sport_select')
+            type_init = st.selectbox("Select Game Type", ['Classic', 'Showdown'], key='type_var')
             try:
-                contest_names, curr_info = grab_contest_names(db, st.session_state['sport_select'], st.session_state['type_var'])
+                contest_names, curr_info = grab_contest_names(db, sport_init, type_init)
             except:
                 st.error("No contests found for this sport and/or game type")
                 st.stop()
@@ -212,8 +212,8 @@ if selected_tab == 'Data Load':
                 del st.session_state['Contest_file']
             if 'Contest_file' not in st.session_state:
                 if st.button('Load Contest Data', key='load_contest_data'):
-                    st.session_state['player_info'], st.session_state['info_maps'] = grab_contest_player_info(db, st.session_state['sport_select'], st.session_state['type_var'], date_select, contest_name_var, contest_id_map)
-                    st.session_state['Contest_file'] = grab_contest_data(st.session_state['sport_select'], contest_name_var, contest_id_map, date_select, date_select2)
+                    st.session_state['player_info'], st.session_state['info_maps'] = grab_contest_player_info(db, sport_init, type_init, date_select, contest_name_var, contest_id_map)
+                    st.session_state['Contest_file'] = grab_contest_data(sport_init, contest_name_var, contest_id_map, date_select, date_select2)
             else:
                 pass
     with contest_upload:
@@ -225,7 +225,7 @@ if selected_tab == 'Data Load':
                 del st.session_state['Contest_file']
             if 'Contest_file' not in st.session_state:
                 st.session_state['Contest_upload'] = st.file_uploader("Upload Contest File (CSV or Excel)", type=['csv', 'xlsx', 'xls'])
-                st.session_state['player_info'], st.session_state['info_maps'] = grab_contest_player_info(db, st.session_state['sport_select'], st.session_state['type_var'], date_select, contest_name_var, contest_id_map)
+                st.session_state['player_info'], st.session_state['info_maps'] = grab_contest_player_info(db, sport_init, type_init, date_select, contest_name_var, contest_id_map)
                 try:
                     st.session_state['Contest_file'] = pd.read_csv(st.session_state['Contest_upload'])
                 except:
@@ -261,7 +261,7 @@ if selected_tab == 'Data Load':
             
 
     if 'Contest_file' in st.session_state:
-        st.session_state['Contest'], st.session_state['ownership_df'], st.session_state['actual_df'], st.session_state['entry_list'], check_lineups = load_contest_file(st.session_state['Contest_file'], st.session_state['type_var'], st.session_state['player_info'], st.session_state['sport_select'], st.session_state['portfolio_df'])
+        st.session_state['Contest'], st.session_state['ownership_df'], st.session_state['actual_df'], st.session_state['entry_list'], check_lineups = load_contest_file(st.session_state['Contest_file'], type_init, st.session_state['player_info'], sport_init, st.session_state['portfolio_df'])
         st.session_state['Contest'] = st.session_state['Contest'].dropna(how='all')
         st.session_state['Contest'] = st.session_state['Contest'].reset_index(drop=True)
         if st.session_state['Contest'] is not None:
@@ -272,7 +272,7 @@ if selected_tab == 'Data Load':
                 st.warning("If you have confirmed that the data is correct, you can send the CSV to the database to enrich Paydirt's sources and help us create actionable tools and algorithms >>")
             with upload_col:
                 if st.button('Send file to Database?', key='export_contest_file'):
-                    return_message = export_contest_file(db, st.session_state['sport_select'], st.session_state['type_var'], date_select, contest_id_map[contest_name_var], st.session_state['Contest_file'])
+                    return_message = export_contest_file(db, sport_init, type_init, date_select, contest_id_map[contest_name_var], st.session_state['Contest_file'])
             with message_col:
                 try:
                     st.info(return_message)
@@ -292,8 +292,7 @@ if selected_tab == 'Data Load':
         st.session_state['salary_dict'] = st.session_state['info_maps']['salary_dict']
         st.session_state['team_dict'] = st.session_state['info_maps']['team_dict']
         st.session_state['pos_dict'] = st.session_state['info_maps']['position_dict']
-
-elif selected_tab == 'Contest Analysis':
+    
     excluded_cols = ['BaseName', 'EntryCount']
     exclude_stacks = ['BaseName', 'EntryCount', 'SP', 'SP1', 'SP2', 'P1', 'P2']
     if 'Contest' in st.session_state and 'display_contest_info' not in st.session_state:
@@ -467,6 +466,10 @@ elif selected_tab == 'Contest Analysis':
         st.session_state['unique_players'] = pd.unique(st.session_state['display_contest_info'][st.session_state['player_columns']].values.ravel('K'))
         st.session_state['unique_players'] = [p for p in st.session_state['unique_players'] if p != 'nan']
 
+if selected_tab == 'Contest Analysis':
+    st.session_state['sport_select'] = sport_init
+    st.session_state['type_var'] = type_init
+    
     if 'display_contest_info' in st.session_state:
         with st.expander("Info and filters"):
             st.info("Note that any filtering here needs to be reset manually, i.e. if you parse down the specific users and want to reset the table, just backtrack your filtering by setting it back to 'All'")