James McCool commited on
Commit
456243b
·
1 Parent(s): ad0e07a

Update reassess_finish_percentile calculation in reassess_edge.py to adjust ownership impact by changing the divisor for own_diff from 2 to 200, improving accuracy in finish_percentile adjustments.

Browse files
Files changed (1) hide show
  1. global_func/reassess_edge.py +2 -2
global_func/reassess_edge.py CHANGED
@@ -47,7 +47,7 @@ def calculate_weighted_ownership_single_row(row_ownerships):
47
  def reassess_finish_percentile(row: pd.Series) -> float:
48
  own_diff = float(row['own_diff'])
49
  median_diff = float(row['median_diff'])
50
- finish_percentile = row['Finish_percentile'] + (own_diff / 2) - (median_diff / 100)
51
 
52
  return finish_percentile
53
 
@@ -118,6 +118,6 @@ def reassess_edge(refactored_frame: pd.DataFrame, original_frame: pd.DataFrame,
118
  refactored_df.loc[lineups, 'Weighted Own'] = calculate_weighted_ownership_single_row(refactored_df.loc[lineups, own_columns])
119
  refactored_df.loc[lineups, 'Geomean'] = np.power((refactored_df.loc[lineups, own_columns] * 100).product(), 1 / len(own_columns))
120
 
121
- # refactored_df = refactored_df.drop(columns=['salary_diff', 'median_diff', 'own_diff', 'player_0_own', 'Edge'] + own_columns)
122
 
123
  return refactored_df
 
47
  def reassess_finish_percentile(row: pd.Series) -> float:
48
  own_diff = float(row['own_diff'])
49
  median_diff = float(row['median_diff'])
50
+ finish_percentile = row['Finish_percentile'] + (own_diff / 200) - (median_diff / 100)
51
 
52
  return finish_percentile
53
 
 
118
  refactored_df.loc[lineups, 'Weighted Own'] = calculate_weighted_ownership_single_row(refactored_df.loc[lineups, own_columns])
119
  refactored_df.loc[lineups, 'Geomean'] = np.power((refactored_df.loc[lineups, own_columns] * 100).product(), 1 / len(own_columns))
120
 
121
+ refactored_df = refactored_df.drop(columns=['salary_diff', 'median_diff', 'own_diff', 'player_0_own', 'Edge'] + own_columns)
122
 
123
  return refactored_df