Refactor stacking logic in 'app.py' by replacing hardcoded exclusions with a dynamic stack column dictionary for various sports, improving maintainability and clarity in player stacking calculations.

app.py

@@ -30,7 +30,13 @@ from global_func.reassess_edge import reassess_edge
 
 freq_format = {'Finish_percentile': '{:.2%}', 'Lineup Edge': '{:.2%}', 'Win%': '{:.2%}'}
 stacking_sports = ['MLB', 'NHL', 'NFL', 'LOL', 'NCAAF']
-exclude_stacks = ['BaseName', 'EntryCount', 'SP', 'SP1', 'SP2', 'P1', 'P2', 'RB1', 'RB2', 'DST', 'G']
+stack_column_dict = {
+    'MLB': ['C', 'C/1B', '1B', '2B', '3B', 'SS', 'OF1', 'OF2', 'OF3'],
+    'NHL': ['C', 'W', 'D'],
+    'NFL': ['QB', 'WR1', 'WR2', 'WR3', 'FLEX'],
+    'LOL': ['TOP', 'JNG', 'MID', 'ADC', 'SUP', 'TEAM'],
+    'NCAAF': ['QB', 'WR1', 'WR2', 'WR3', 'FLEX', 'SFLEX'],
+}
 player_wrong_names_mlb = ['Enrique Hernandez', 'Joseph Cantillo', 'Mike Soroka', 'Jakob Bauers', 'Temi Fágbénlé']
 player_right_names_mlb = ['Kike Hernandez', 'Joey Cantillo', 'Michael Soroka', 'Jake Bauers', 'Temi Fagbenle']
 
@@ -441,22 +447,21 @@ if selected_tab == 'Data Load':
             # Update projections with matched names
             projections['player_names'] = projections['player_names'].map(lambda x: projections_match_dict.get(x, x))
             st.session_state['projections_df'] = projections
-            st.session_state['stack_columns'] = [col for col in st.session_state['portfolio'].columns if col not in exclude_stacks]
 
             if sport_var in stacking_sports:
                 team_dict = dict(zip(st.session_state['projections_df']['player_names'], st.session_state['projections_df']['team']))
                 st.session_state['portfolio']['Stack'] = st.session_state['portfolio'].apply(
                     lambda row: Counter(
-                        team_dict.get(player, '') for player in row[st.session_state['stack_columns']]
+                        team_dict.get(player, '') for player in row[stack_column_dict[sport_var]]
                         if team_dict.get(player, '') != ''
-                    ).most_common(1)[0][0] if any(team_dict.get(player, '') for player in row[st.session_state['stack_columns']]) else '',
+                    ).most_common(1)[0][0] if any(team_dict.get(player, '') for player in row[stack_column_dict[sport_var]]) else '',
                     axis=1
                 )
                 st.session_state['portfolio']['Size'] = st.session_state['portfolio'].apply(
                     lambda row: Counter(
-                        team_dict.get(player, '') for player in row[st.session_state['stack_columns']]
+                        team_dict.get(player, '') for player in row[stack_column_dict[sport_var]]
                         if team_dict.get(player, '') != ''
-                    ).most_common(1)[0][1] if any(team_dict.get(player, '') for player in row[st.session_state['stack_columns']]) else 0,
+                    ).most_common(1)[0][1] if any(team_dict.get(player, '') for player in row[stack_column_dict[sport_var]]) else 0,
                     axis=1
                 )
                 st.session_state['stack_dict'] = dict(zip(st.session_state['portfolio'].index, st.session_state['portfolio']['Stack']))