Spaces:
Sleeping
Sleeping
James McCool
commited on
Commit
·
d12afa6
1
Parent(s):
9fa6f26
Refactor reassess_finish_percentile function in reassess_edge.py to remove unnecessary parameters, streamlining the calculation of finish_percentile. Update references in reassess_edge function to align with the new function signature, enhancing code clarity and maintainability.
Browse files
global_func/reassess_edge.py
CHANGED
|
@@ -44,7 +44,7 @@ def calculate_weighted_ownership_single_row(row_ownerships):
|
|
| 44 |
# Convert back to percentage form
|
| 45 |
return weighted * 10000
|
| 46 |
|
| 47 |
-
def reassess_finish_percentile(row: pd.Series
|
| 48 |
own_diff = float(row['own_diff'])
|
| 49 |
median_diff = float(row['median_diff'])
|
| 50 |
finish_percentile = row['Finish_percentile'] + (own_diff / 2) - (median_diff / 100)
|
|
@@ -112,7 +112,7 @@ def reassess_edge(refactored_frame: pd.DataFrame, original_frame: pd.DataFrame,
|
|
| 112 |
|
| 113 |
for lineups in change_mask.index:
|
| 114 |
refactored_df.loc[lineups, 'Dupes'] = reassess_dupes(refactored_df.loc[lineups, :], salary_max)
|
| 115 |
-
refactored_df.loc[lineups, 'Finish_percentile'] = reassess_finish_percentile(refactored_df.loc[lineups, :]
|
| 116 |
refactored_df.loc[lineups, 'Win%'] = refactored_df.loc[lineups, 'Win%']
|
| 117 |
refactored_df.loc[lineups, 'Edge'] = reassess_lineup_edge(refactored_df.loc[lineups, :], Contest_Size)
|
| 118 |
refactored_df.loc[lineups, 'Weighted Own'] = calculate_weighted_ownership_single_row(refactored_df.loc[lineups, own_columns])
|
|
|
|
| 44 |
# Convert back to percentage form
|
| 45 |
return weighted * 10000
|
| 46 |
|
| 47 |
+
def reassess_finish_percentile(row: pd.Series) -> float:
|
| 48 |
own_diff = float(row['own_diff'])
|
| 49 |
median_diff = float(row['median_diff'])
|
| 50 |
finish_percentile = row['Finish_percentile'] + (own_diff / 2) - (median_diff / 100)
|
|
|
|
| 112 |
|
| 113 |
for lineups in change_mask.index:
|
| 114 |
refactored_df.loc[lineups, 'Dupes'] = reassess_dupes(refactored_df.loc[lineups, :], salary_max)
|
| 115 |
+
refactored_df.loc[lineups, 'Finish_percentile'] = reassess_finish_percentile(refactored_df.loc[lineups, :])
|
| 116 |
refactored_df.loc[lineups, 'Win%'] = refactored_df.loc[lineups, 'Win%']
|
| 117 |
refactored_df.loc[lineups, 'Edge'] = reassess_lineup_edge(refactored_df.loc[lineups, :], Contest_Size)
|
| 118 |
refactored_df.loc[lineups, 'Weighted Own'] = calculate_weighted_ownership_single_row(refactored_df.loc[lineups, own_columns])
|