Refactor NHL lineup generation in streamlit_app.py by removing redundant variable initializations and updating player name mappings. Adjust path handling in nhl_functions.py to ensure correct binary execution from project root.

src/sports/nhl_functions.py

@@ -96,12 +96,15 @@ def run_go_classic_lineup_generator(site="DK", sport="NHL"):
         start_time = time.time()
         
         # Determine the path to the Go binary (from /app/func directory)
-        app_dir = os.path.dirname(os.path.abspath(__file__))  # Now at /app/func
+        # __file__ is at src/sports/nhl_functions.py, so we need to go up to project root
+        current_dir = os.path.dirname(os.path.abspath(__file__))  # src/sports/
+        project_root = os.path.dirname(os.path.dirname(current_dir))  # Go up to project root
+        func_dir = os.path.join(project_root, "func")
         
         if site == "DK":
-            go_binary = os.path.join(app_dir, "dk_nhl_go", "NHL_seed_frames")
+            go_binary = os.path.join(func_dir, "dk_nhl_go", "NHL_seed_frames")
         else:
-            go_binary = os.path.join(app_dir, "fd_nhl_go", "NHL_seed_frames")
+            go_binary = os.path.join(func_dir, "fd_nhl_go", "NHL_seed_frames")
         
         st.write(f"Looking for binary at: {go_binary}")
         
@@ -111,7 +114,7 @@ def run_go_classic_lineup_generator(site="DK", sport="NHL"):
             capture_output=True,
             text=True,
             check=True,
-            cwd=app_dir  # Run from /app directory
+            cwd=project_root  # Run from project root
         )
         
         end_time = time.time()
@@ -135,7 +138,7 @@ def run_go_classic_lineup_generator(site="DK", sport="NHL"):
         st.write(f"Error: Go binary not found at {go_binary}")
         st.write(f"FileNotFoundError: {e}")
         st.write(f"Current working directory: {os.getcwd()}")
-        st.write(f"App directory: {app_dir}")
+        st.write(f"App directory: {func_dir}")
         return False
     except Exception as e:
         st.write(f"Unexpected error: {e}")

src/streamlit_app.py

@@ -67,27 +67,6 @@ if st.button(f"{sport_icons[selected_sport]} Generate {selected_sport} Lineups",
     
     # Route to sport-specific pipeline
     if selected_sport == "NHL":
-        nan_value = float("NaN")
-        sim_teams = []
-        cut_slate = 0
-        total_sims = 1000
-        model_version = 1
-
-        sh = gc.open_by_url(NHL_Master_hold)
-        worksheet = sh.worksheet('Slate_Info')
-        slate_info = DataFrame(worksheet.get_all_records())
-        slate_info = slate_info.replace('', np_nan)
-        slate_options = ['Main Slate', 'Secondary Slate', 'Late Slate']
-
-        dk_player_hold = DataFrame(columns=['Player', 'Position', 'Team', 'Opp', 'Salary', 'Floor', 'Median', 'Ceiling', 'Top_finish', 'Top_5_finish', 'Top_10_finish', '20+%', '2x%', '3x%', '4x%', 'Own', 'Small Field Own%', 'Large Field Own%', 'Cash Own%', 'CPT_Own', 'Site', 'Type', 'Slate', 'player_id'])
-        dk_stacks_hold = DataFrame(columns=['Player', 'SK1', 'SK2', 'SK3', 'Salary', 'Floor', 'Median', 'Ceiling', 'Top_finish', 'Top_5_finish', 'Top_10_finish', '50+%', '2x%', '3x%', '4x%', 'Own', 'Site', 'Type', 'Slate'])
-        dk_pp_stacks_hold = DataFrame(columns=['Player', 'SK1', 'SK2', 'SK3', 'SK4', 'SK5', 'Salary', 'Floor', 'Median', 'Ceiling', 'Top_finish', 'Top_5_finish', 'Top_10_finish', '75+%', '2x%', '3x%', '4x%', 'Own', 'Site', 'Type', 'Slate'])
-        fd_player_hold = DataFrame(columns=['Player', 'Position', 'Team', 'Opp', 'Salary', 'Floor', 'Median', 'Ceiling', 'Top_finish', 'Top_5_finish', 'Top_10_finish', '20+%', '2x%', '3x%', '4x%', 'Own', 'Small Field Own%', 'Large Field Own%', 'Cash Own%', 'CPT_Own', 'Site', 'Type', 'Slate', 'player_id'])
-        fd_stacks_hold = DataFrame(columns=['Player', 'SK1', 'SK2', 'SK3', 'Salary', 'Floor', 'Median', 'Ceiling', 'Top_finish', 'Top_5_finish', 'Top_10_finish', '50+%', '2x%', '3x%', '4x%', 'Own', 'Site', 'Type', 'Slate'])
-        fd_pp_stacks_hold = DataFrame(columns=['Player', 'SK1', 'SK2', 'SK3', 'SK4', 'SK5', 'Salary', 'Floor', 'Median', 'Ceiling', 'Top_finish', 'Top_5_finish', 'Top_10_finish', '75+%', '2x%', '3x%', '4x%', 'Own', 'Site', 'Type', 'Slate'])
-
-        wrong_names = ['Arseniy Gritsyuk', 'Benjamin Kindel', 'Christopher Tanev', 'Fredrick Gaudreau', 'Jack Hughes', 'Joshua Mahura', 'Maxim Shabanov', 'Mikey Eyssimont', 'Nate Bastian', 'Zachary Aston-Reese', 'Zachary Bolduc', 'Jacob Middleton', 'Mitchell Marner', 'Maxwell Crozier']
-        right_names = ['Arseny Gritsyuk', 'Ben Kindel', 'Chris Tanev', 'Freddy Gaudreau', 'Jack Hughes', 'Josh Mahura', 'Max Shabanov', 'Michael Eyssimont', 'Nathan Bastian', 'Zach Aston-Reese', 'Zack Bolduc', 'Jake Middleton', 'Mitch Marner', 'Max Crozier']
 
         st.write("Starting prop betting table generation...")
         build_prop_betting_table(nhl_db)