Modifying generator_agent.py to follow the examples and make the output as requested.

ai_messaging_system_v2/Messaging_system/agents/generator_agent.py

@@ -270,21 +270,17 @@ You should follow the instructions provided and use the examples (if available)
 {feedback_section}
 """
         elif has_examples:
-            # Only examples, no instructions
+            # Only examples, no instructions - use strict selection approach
             context = f"""
-Your task is to modify provided examples to output ONE personalized 'header' and 'message' as a push notification for a student learning {self.core_config.get_instrument()}.
+**Task**: Select ONE header and ONE message from the options below for a {self.core_config.get_instrument()} student.
 
-**IMPORTANT**: Carefully analyze the example messages provided below to understand our brand's:
-- Vocabulary, word choices, phrases
-- Writing style and tone for header and message
-- Voice and personality
-- Sentence structure and rhythm for header and message
-- Character, feel, and emojis
-
-Stick to the provided push notification examples. Select one 'header' and one 'message'. Modify the example slightly to make it more personalized giving the instructions and provide a modified personalized 'header' and 'message' as the output.
-
-**Character Limits**: header < {self.core_config.config_file["header_limit"]} and message < {self.core_config.config_file["message_limit"]} characters.
+**Rules**:
+1. SELECT from examples - do NOT create new content
+2. PRESERVE all emojis exactly as shown
+3. Personalize ONLY by: provided recommendation, adding user's name or using their other personalized info. 
+4. Keep the EXACT tone, style, and sentence structure
 
+**Limits**: header < {self.core_config.config_file["header_limit"]}, message < {self.core_config.config_file["message_limit"]} chars
 {feedback_section}
 """
         else:
@@ -308,8 +304,8 @@ Your task is to generate a personalized 'header' and 'message' as a push notific
             # Both: examples demonstrate style/voice
             header = "### **Example Messages (demonstrating our brand's voice and style):**"
         elif has_examples and not has_instructions:
-            # Only examples: analyze these to understand brand
-            header = "### **Example Messages:**\nStudy these examples, and stick to the vocabulary and style. Select one of them, Modify the 'header' and 'message' slightly to make it more personalized giving the instructions and provide one modified personalized 'header' and 'message' as the output."
+            # Only examples: frame as available options for strict selection
+            header = "### **Available Options (select one header + one message):**"
         else:
             header = "### **Example Messages:**"
 
@@ -394,39 +390,30 @@ User name is: {name} ;
             return ""
 
         instructions = f"""
-### **Content Recommendation Guidelines:**
-
-Below is the content we want to recommend to the user:
+### **Content Recommendation:**
 
 {recommendation_info}
 
-When incorporating this content:
-1. **Title Usage**: Refer to the content naturally - paraphrase or describe it, don't quote verbatim. Avoid promotional tone.
-2. **Content Type**: Mention the type (course, workout, etc.) only if it flows naturally.
-3. **Artist/Instructor**: If the full name is available, mention it casually if appropriate. If only first name, do NOT include it. NEVER assume or hallucinate names.
-4. **Tone**: Keep it light, supportive, engaging, and personal.
-5. **Time Reference**: NEVER use time-related words ("new," "recent," "latest") or imply recency.
+**CRITICAL - Articulate Value**: Don't just mention the content. Explain WHY it matters:
+- What skill will they develop?
+- What will they be able to DO after taking it?
+
+BAD: "Try the Fills workout - it's great for technique"
+GOOD: "Master those tricky fills that make songs come alive"
 
-Make the recommendation feel personalized and casually relevant, not generic or marketing-like.
+**Rules**:
+1. Paraphrase content naturally - never quote verbatim
+2. Create desire to click - focus on benefit, not feature
+3. NEVER use time words (new, recent, latest)
+4. If artist full name available, mention casually. If only first name, omit.
 """
         return instructions.strip()
 
     def _get_output_instructions(self) -> str:
         """Get output format instructions."""
         instructions = f"""
-### **Output Format:**
-
-Return a valid JSON object with this exact structure:
-
-{{
-  "header": "your generated header",
-  "message": "your generated message"
-}}
-
-**Remember**:
-- header < {self.core_config.config_file["header_limit"]} characters
-- message < {self.core_config.config_file["message_limit"]} characters
-- Valid JSON format
+### **Output (JSON)**:
+{{"header": "<{self.core_config.config_file["header_limit"]} chars", "message": "<{self.core_config.config_file["message_limit"]} chars"}}
 """
         return instructions.strip()
 
@@ -449,13 +436,12 @@ You are an expert at creating personalized, engaging push notifications for {sel
 
 **Critical Rules:**
 - NEVER use time-related words ("new," "recent," "latest," etc.) or imply recency
+- PRESERVE all emojis from selected examples - copy them exactly
 - Stay within character limits: header < {self.core_config.config_file["header_limit"]}, message < {self.core_config.config_file["message_limit"]}
 - Return valid JSON with "header" and "message" keys
 
-**Avoid these phrases and similar variations:**
+**Avoid these phrases:**
 {banned_phrases}
-
-**Also avoid these phrases:**
 {jargon_list}
 
 **Tone**: Supportive, engaging, personal - never pushy or promotional.

ai_messaging_system_v2/Previous_codes/PromptGenerator.py

@@ -0,0 +1,288 @@
+"""
+THis class generate proper prompts for the messaging system
+"""
+import pandas as pd
+from tqdm import tqdm
+
+
+class PromptGenerator:
+
+    def __init__(self, Core):
+        self.Core = Core
+
+    # --------------------------------------------------------------
+    # --------------------------------------------------------------
+    def generate_prompts(self, stage=1):
+        """
+        generates a personalized message for each student
+        :return:
+        """
+
+        # engine = PromptEngine(self.Core)
+        self.Core.users_df = self.Core.users_df.drop_duplicates(subset=['user_id'])
+
+        # if we have personalized information about them, we generate a personalized prompt
+        for idx, row in tqdm(self.Core.users_df.iterrows(), desc="generating prompts"):
+            # check if we have enough information to generate a personalized message
+            if stage == 1:
+                prompt = self.generate_personalized_prompt(user=row)
+            else:
+                prompt = self.generate_follow_up_prompt(user=row)
+
+            self.Core.users_df.at[idx, "prompt"] = prompt
+            self.Core.users_df.at[idx, "source"] = "AI-generated"
+
+        return self.Core
+
+
+    # --------------------------------------------------------------
+    def safe_get(self, value):
+        return str(value) if pd.notna(value) else "Not available"
+
+    # ==============================================================
+    def get_user_profile(self, user):
+        """
+        getting personalized information about users (e.g. preferences)
+        :param user:
+        :return:
+        """
+        if self.Core.personalization:
+            user_info = f"""
+
+### **Use below information from the user to **modify** the selected header and message (without any change in style, tune and content) and make the final output more personalized if applicable.
+Use these only to *flavour* the existing header and message. Never add new sentences just to stuff profile data.
+
+- The user is a {str(self.Core.get_instrument())} student.
+- {self.safe_get(self.Core.segment_info)}
+- User profile --> Only use **indirectly** if it can improve personalization (Don't use their preferred genre or styles directly in the message:
+{self.safe_get(user.get("user_info"))}
+"""
+            # birth_day_instructions = self.birth_day_instructions(user)
+            # if birth_day_instructions is not None:
+            #     user_info += "\n" + birth_day_instructions
+            ## eliminate:
+            # - first name: {self.safe_get(user.get("first_name"))} --> Only use if is available and the first name is a **valid name**
+
+        else:
+
+            user_info = f"""
+### **Use below Information to select the best header and message from available options:**
+Do not **change** or **modify** or **add to** the selected option and **use the original selected header and message without ANY change**
+
+Here is the information about the user:
+- The user is a {str(self.Core.get_instrument())} student.
+- {self.safe_get(self.Core.segment_info)}
+- User_profile: 
+{self.safe_get(user.get("user_info"))}
+"""
+            return user_info
+
+        ## deleted from profile
+        # first name: {self.safe_get(user.get("first_name"))}
+        #  Weeks since Last interaction:{self.safe_get(user.get("weeks_since_last_interaction"))}
+        # {self.safe_get(additional_info)}
+        # ** User
+        # profile: **
+        #
+        # {self.safe_get(user.get("user_info"))}
+
+        return user_info
+
+    # --------------------------------------------------------------
+    def birth_day_instructions(self, user):
+        # Birthday reminder
+        if pd.notna(user["birthday_reminder"]) and user["birthday_reminder"] not in [None, [], {}]:
+            instructions = f"""
+- **Include a short message to remind them that their birthday is coming up.**: {str(user["birthday_reminder"])} Days until their birthday.
+        """
+            return instructions
+        else:
+            return None
+
+    def generate_personalized_prompt(self, user):
+        """
+        generate a personalized prompt by putting the information from the user into a template prompt
+        :return: Personalized prompt (string)
+        """
+        input_context = self.input_context()
+        user_info = self.get_user_profile(user=user)
+
+        recommendation_instructions = self.recommendations_instructions(user)
+
+        example_output = self.example_output()
+
+        output_instructions = self.output_instruction()
+
+        prompt = f"""
+{input_context}
+
+{example_output}
+
+{user_info}
+
+{recommendation_instructions}
+
+{output_instructions}
+    """
+
+        return prompt
+
+    # --------------------------------------------------------------
+    # --------------------------------------------------------------
+    def input_context(self):
+        """
+        :return: input instructions as a string
+        """
+
+        if self.Core.personalization:
+            context = f"""
+Your task is to select the best 'header' and a 'message' for a {self.Core.get_instrument()} student as a push notification. 
+Based on the user instructions, you might need to **modify the selected option** very minimal and slightly to improve personalization if capable.
+**Important Note**: header < {self.Core.config_file["header_limit"]} and message < {self.Core.config_file["message_limit"]} characters.
+"""
+
+        else:
+            context = f"""
+Your task is to select the best 'header' and a 'message' for a {self.Core.get_instrument()} student as a push notification. 
+DO NOT **change** or **modify** or **add to** the selected option in any shape or form. **Use the exact original selected header and message without ANY change**
+"""
+
+        return context
+
+
+    # --------------------------------------------------------------
+    # --------------------------------------------------------------
+    def recommendations_instructions(self, user):
+        """
+        instructions about target recommendation for the user
+        :param user:
+        :return:
+        """
+
+
+        instructions_for_recsys = f"""
+### ** Recommendation Personalization Guidelines **
+
+Below is the content we want to recommend to the user:
+
+→ Recommended Content Details:
+{user["recommendation_info"]}
+
+When incorporating this content into the message and header, follow these guidelines to keep the header and message friendly, relevant, and casual (not too scripted):
+
+1. **Title Usage**:
+   - Refer to the **CONTENT_TITLE** or content details naturally in the message — paraphrase or describe it, but do *not* quote it or use it verbatim.
+   - Avoid making it feel like a promotion; frame it as something that *might interest* or *help* the user.
+
+2. **Content Type Context**:
+   - Mention the **CONTENT_TYPE** (e.g., course, workout) only if it flows naturally in the message.
+
+
+3. **Artist/Instructor Name**:
+   - If the full name of the **ARTIST** is available, mention it casually if appropriate (e.g., "led by Jordan Mitchell").
+   - If only the first name is known, do *not* include it in the message at all.
+   - **DO NOT ASSUME or HALLUCINATE Artist name based on previous messages**, only refer to Recommended Content Details provided.
+
+4. **Tone & Style**:
+   - Keep the tone light, supportive, and personal — like a helpful suggestion from a friend.
+   - Avoid sounding pushy, overly promotional, or marketing pitch.
+
+5. **Flexibility**:
+   - You don’t need to include all elements every time. Prioritize what feels most relevant and natural based on the context.
+
+6. **Time Reference**:
+   - NEVER use time-related words (“new,” “recent,” “latest,” etc.) and Never imply recency of the content in any way.
+   
+Goal: Make the recommendation feel personalized and casually relevant — not generic or copy-pasted.
+"""
+
+        if self.Core.personalization and self.Core.involve_recsys_result:
+            return instructions_for_recsys
+        else:
+            return ""
+
+    # --------------------------------------------------------------
+    # --------------------------------------------------------------
+    def output_instruction(self):
+        """
+        :return: output instructions as a string
+        """
+
+        general_instructions = f"""
+- Ensure that the output is a valid JSON following above structure.
+        """
+
+        instructions = f"""
+### **Output instructions**:
+- header < {self.Core.config_file["header_limit"]} and message < {self.Core.config_file["message_limit"]} characters.
+
+**Expected output structure:**
+
+{{
+  "header": "final header considering instructions",
+  "message": "final message considering instructions",
+}}
+
+{general_instructions}
+    """
+
+        return instructions
+
+    # --------------------------------------------------------------
+    # --------------------------------------------------------------
+    def example_output(self):
+        """
+        returns an example output (1-shot) to guide the LLM
+        :return: example output
+        """
+
+        if self.Core.sample_example is None:
+
+            return ""
+
+        else:
+            # one shot prompting
+            example = f"""
+Below are the available options to select the header and message for the push notification: 
+
+### **Available options:**
+{self.Core.sample_example}
+    """
+
+            return example
+
+    # =============================================================
+    def generate_follow_up_prompt(self, user):
+        """
+        Creates a prompt to feed to the LLM, incorporating 3 previously generated messages.
+
+        :param previous_messages: A list of dicts, each containing 'header' and 'message'.
+        :return: A user-facing prompt string instructing the model to produce a new message.
+        """
+        previous_text_str = str(user["previous_messages"])
+        user_info = self.get_user_profile(user=user)
+        input_context = self.input_context()
+        recommendation_instructions = self.recommendations_instructions(user)
+        output_instructions = self.output_instruction()
+        examples = self.example_output()
+
+        # Craft the prompt
+        prompt = f"""
+We have previously sent these push notifications to the user and The user has not re-engaged yet:
+
+** Previous messages **
+{previous_text_str}
+
+{input_context}
+- The new selection should be different from previous headers and messages and we should not have similar words and phrases from previous sends.
+
+{examples}
+
+{user_info}
+
+{recommendation_instructions}
+
+{output_instructions}
+"""
+
+        return prompt