-changing subsequent messages similar to initial messages and change prompting

.idea/AI_Message_Generator.iml

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module type="PYTHON_MODULE" version="4">
+  <component name="NewModuleRootManager">
+    <content url="file://$MODULE_DIR$" />
+    <orderEntry type="jdk" jdkName="Python 3.9" jdkType="Python SDK" />
+    <orderEntry type="sourceFolder" forTests="false" />
+  </component>
+</module>

Messaging_system/MultiMessage.py

@@ -1,7 +1,7 @@
 import json
 import time
 from openai import OpenAI
-
+from Messaging_system.PromptGenerator import PromptGenerator
 from Messaging_system.PromptEng import PromptEngine
 from Messaging_system.protection_layer import ProtectionLayer
 import openai
@@ -16,6 +16,7 @@ class MultiMessage:
         self.Core = CoreConfig
         self.llm = LLM(CoreConfig)
         self.engine = PromptEngine(self.Core)
+        self.promptGen = PromptGenerator(self.Core)
 
     # --------------------------------------------------------------
     def generate_multi_messages(self, user):
@@ -56,7 +57,7 @@ class MultiMessage:
         # Already have the first message, so generate the next (n-1) messages
         for step in range(1, total_to_generate + 1):
             # 2) Generate the next message referencing all so-far messages
-            next_msg_raw = self.generate_next_messages(message_sequence, step+1)
+            next_msg_raw = self.generate_next_messages(message_sequence, step+1, user)
             if not next_msg_raw:
                 print(f"Could not generate the message for step {step}. Stopping.")
                 break
@@ -93,7 +94,7 @@ class MultiMessage:
         return json.dumps(final_structure, ensure_ascii=False)
 
     # --------------------------------------------------------------
-    def generate_next_messages(self, previous_messages, step):
+    def generate_next_messages(self, previous_messages, step, user):
         """
         Uses only the last two previously generated messages to produce the next message.
         Returns a *raw* dictionary (header, message, etc.) from the LLM.
@@ -109,7 +110,7 @@ class MultiMessage:
             context = previous_messages
 
         # 1) Build a prompt that includes only those last two messages
-        prompt = self.generate_prompt(context, step)
+        prompt = self.generate_prompt(context, step, user)
 
         # new_prompt = self.engine.prompt_engineering(prompt)
 
@@ -128,29 +129,28 @@ class MultiMessage:
         if self.Core.subsequent_examples is not None:
 
             instructions = f"""
-        # ** Example **
-        Below are some acceptable examples of the voice we want. Create a header and message that follow the same style, tone, vocabulary, and characteristics.
-        Mimic the example style as much as possible and make it personalized using provided information.
-           
+# ** Example **
+Below are some acceptable examples of the voice we want. Create a header and message that follow the same style, tone, vocabulary, and characteristics.
+Mimic the example style as much as possible and make it personalized using provided information.
+   
 
-        ### **Good Examples:**
-        
-            {self.Core.subsequent_examples[step]} 
-        """
+### **Good Examples:**
+
+    {self.Core.subsequent_examples[step]} 
+"""
             return instructions
         else:
             return ""
 
     # --------------------------------------------------------------
-    def generate_prompt(self, previous_messages, step):
+    def generate_prompt(self, previous_messages, step, user):
         """
         Creates a prompt to feed to the LLM, incorporating 3 previously generated messages.
 
         :param previous_messages: A list of dicts, each containing 'header' and 'message'.
         :return: A user-facing prompt string instructing the model to produce a new message.
         """
-        # Build a textual summary of previous messages
-        # ──► NEW: keep at most the last three messages
+        # Build a textual summary of previous messages - last three
         recent_messages = previous_messages[-3:]
 
         previous_text = []
@@ -162,10 +162,10 @@ class MultiMessage:
         # Combine into a single string
         previous_text_str = "\n\n".join(previous_text)
 
-        # Provide constraints for our next push notification
-        header_limit = self.Core.config_file.get("header_limit", 50)
-        message_limit = self.Core.config_file.get("message_limit", 200)
-
+        user_info = self.promptGen.get_user_profile(user=user)
+        input_context = self.promptGen.input_context()
+        output_instructions = self.output_instruction()
+        general_specifications = self.general_specifications()
 
         examples = self.get_examples(step)
 
@@ -173,48 +173,74 @@ class MultiMessage:
         # Craft the prompt
         prompt = f"""
 We have previously sent these push notifications to the user and The user has not re-engaged yet:
-User info:
-{self.Core.segment_info}
 
 ** Previous messages **
 {previous_text_str}
 
+
 **Objective**  
-Write the *next* follow up personalized push notification following the instructions. 
-You are texting a friend and it should feel like a friendly encouraging nudge. Your task is to write a 'header' and a 'message' as a push notification for a {self.Core.get_instrument()} student that sounds like natural everyday speech: friendly, concise, no jargon, and following the instructions.
-Write a SUPER CASUAL and NATURAL push notification, as if you are chatting over coffee. Avoid odd phrasings. 
-The user is a {str(self.Core.get_instrument())} student.
-
-# **General instructions**:
-
- - Start directly with the message content without greetings or closing phrases (every word counts).
- - Follow the Good examples to mimic the style and vocabulary.
- - Use {self.Core.get_emoji()}  only if it sharpens impact. Don't use Emoji if we already had it in our previous message.**
- - "message" and "header" **MUST NOT** contain similar or close words and phrases, and make sure there is no grammar problem.
- - New header and message **MUST BE** clearly different from all earlier headers & messages in terms of vocabulary and phrases (They must not be similar) 
- 
-
-# **Tune, Style and specific instructions**: 
--  The message and header should sound natural and friendly, like something that people would normally say in daily conversations. This is the most important part of the notification. It should sound like everyday natural speech: friendly conversation.        
+Write the *next* follow up personalized push notification following the instructions and what we know about the user.
+{input_context}
+
+{user_info}
+
+### ** General Specifications: **
+
+{general_specifications}
+
+# **specific instructions**:         
 - {self.Core.subsequence_messages[step]} 
 
 {examples}
 
+{output_instructions}
+"""
+
+        return prompt
+    # ===========================================================================
+    def general_specifications(self):
+        """
+        general_specifications
+        :return: instructions
+        """
+
+        instructions = """
+- Start directly with the message content without greetings or closing phrases.
+- Avoid using same or similar words so close together in "message" and "header", and make sure there is no grammar problem.
+- The message, vocabulary and sentences **MUST** sound like a natural conversation: something that people normally say in daily conversations.
+        
+        """
+        return instructions
+
+    # =============================================================================
+
+    def output_instruction(self):
+        """
+        :return: output instructions as a string
+        """
+
+        # Provide constraints for our next push notification
+        header_limit = self.Core.config_file.get("header_limit", 50)
+        message_limit = self.Core.config_file.get("message_limit", 200)
 
-# Constraints:
-- "header" must be fewer than {header_limit} characters. 
-- "message" must be fewer than {message_limit} characters.
-- Output must be valid JSON with exactly two keys: "header" and "message".
+        general_instructions = f"""
+- The "header" must be less than {header_limit} character. 
+- The "message" must be less than {message_limit} character.
+- Preserve special characters and emojis in the message, you are **ONLY ALLOWED**allowed to use {self.Core.get_emoji()} emoji if needed, ONLY ONCE, and ONLY at the end of header or message).
+- Ensure that the output is a valid JSON and not include any text outside the JSON code block.
+"""
 
+        instructions = f"""
+Expected output structure:
 
-Return only JSON of the form:
 {{
-  "header": "...",
-  "message": "..."
+  "header": "Generated title",
+  "message": "Generated message",
 }}
-""".strip()
 
-        return prompt
+{general_instructions}
+"""
+        return instructions
 
     # --------------------------------------------------------------
     def parsing_output_message(self, message, user):

Messaging_system/PromptGenerator.py

@@ -43,12 +43,16 @@ class PromptGenerator:
         # additional_info = self.user_additional_info(user)
 
         user_info = f"""
-       ### **User Information:**
+### **User Information:**
 
-       Here is the information about the user:
-       The user is a {str(self.Core.get_instrument())} student.
-       
-       {self.safe_get(self.Core.segment_info)}
+Here is the information about the user:
+- The user is a {str(self.Core.get_instrument())} student.
+- {self.safe_get(self.Core.segment_info)}
+- first name: {self.safe_get(user.get("first_name"))}
+
+**user_profile** 
+
+{self.safe_get(user.get("user_info"))}
        
        """
 
@@ -94,15 +98,15 @@ class PromptGenerator:
         # eliminate {task_instructions} and  {recommendations_instructions}
 
         prompt = f"""
-    {input_context}
-    
-    {user_info}
-    
-    {cta}
-    
-    {general_instructions}
-    
-    {output_instructions}
+{input_context}
+
+{user_info}
+
+{cta}
+
+{general_instructions}
+
+{output_instructions}
     """
 
         return prompt
@@ -115,7 +119,12 @@ class PromptGenerator:
         """
 
         context = f"""
-        Your task is to write a 'header' and a 'message' as a push notification for a {self.Core.get_instrument()} student that sounds like everyday natural speech: friendly, short, no jargon by following the instructions.
+Your task is to write a 'header' and a 'message' as a push notification for a {self.Core.get_instrument()} student that sounds like everyday natural speech: friendly, short, no jargon by following the instructions.
+The output should sound like something that a {self.Core.get_instrument()} instructor would realistically say to a student in a daily conversation.
+
+** Examples of actual phrases an instructor might say:**
+
+{self.Core.brand_voice}
         """
 
         return context
@@ -130,9 +139,9 @@ class PromptGenerator:
 
         instructions = f"""
 
-    ### **Main instructions**
-    
-    {self.Core.CTA} \n
+### **Main instructions**
+
+{self.Core.CTA} \n
     """
 
         return instructions
@@ -292,12 +301,12 @@ class PromptGenerator:
 
         if self.Core.platform == "push":
             instructions = f""" 
-    ### ** General Specifications: **
+### ** General Specifications: **
 
-    - Start directly with the message content without greetings or closing phrases.
-    - Avoid using same or similar words so close together in "message" and "header", and make sure there is no grammar problem.
-    - The message, vocabulary and sentences **MUST** sound like a natural conversation: something that people normally say in daily conversations.
-    - {message_style}
+- Start directly with the message content without greetings or closing phrases.
+- Avoid using same or similar words so close together in "message" and "header", and make sure there is no grammar problem.
+- The message, vocabulary and sentences **MUST** sound like a natural conversation: something that people normally say in daily conversations.
+- {message_style}
 
     """
 
@@ -345,28 +354,28 @@ class PromptGenerator:
 
         example_output = self.example_output()
         general_instructions = f"""
-    - The "header" must be less than 30 character. 
-    - The "message" must be less than 100 character.
-    - Preserve special characters and emojis in the message, you are **ONLY ALLOWED**allowed to use {self.Core.get_emoji()} emoji if needed, ONLY ONCE, and ONLY at the end of header or message).
-    - Ensure that the output is a valid JSON and not include any text outside the JSON code block.
+- The "header" must be less than 30 character. 
+- The "message" must be less than 100 character.
+- Preserve special characters and emojis in the message, you are **ONLY ALLOWED**allowed to use {self.Core.get_emoji()} emoji if needed, ONLY ONCE, and ONLY at the end of header or message).
+- Ensure that the output is a valid JSON and not include any text outside the JSON code block.
         """
 
         instructions = f"""
-    Expected output structure:
+Expected output structure:
 
-    {{
-      "header": "Generated title",
-      "message": "Generated message",
-    }}
+{{
+  "header": "Generated title",
+  "message": "Generated message",
+}}
 
-    {general_instructions}
+{general_instructions}
     """
 
         output_instructions = f"""
-    ### **Output instructions**:
+### **Output instructions**:
 
-    {example_output}
-    {instructions}
+{example_output}
+{instructions}
         """
 
         return output_instructions