Spaces:
Sleeping
Sleeping
File size: 20,122 Bytes
d982819 066aee2 d982819 066aee2 e65039f 066aee2 d982819 e65039f d982819 066aee2 d982819 066aee2 d982819 066aee2 e65039f 066aee2 d982819 066aee2 e65039f 066aee2 d982819 e65039f d982819 e65039f d982819 066aee2 d982819 066aee2 d982819 e65039f d982819 e65039f d982819 e65039f d982819 e65039f d982819 e65039f d982819 8850a07 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 e65039f d982819 e65039f d982819 e65039f d982819 e65039f d982819 066aee2 e65039f 066aee2 d982819 066aee2 d982819 066aee2 e65039f 066aee2 d982819 e65039f d982819 e65039f d982819 e65039f d982819 066aee2 d982819 e65039f d982819 066aee2 e65039f 066aee2 d982819 e65039f d982819 e65039f d982819 066aee2 d982819 066aee2 e65039f 066aee2 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 066aee2 d982819 e65039f d982819 b5ca852 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 | #include "Orderbook.h"
#include <numeric>
#include <algorithm>
#include <chrono>
#include <ctime>
#include <stdexcept>
// ─────────────────────────────────────────────────────────────────────────────
// Constructor / Destructor
// ─────────────────────────────────────────────────────────────────────────────
Orderbook::Orderbook()
: pruneThread_([this] { PruneGoodForDayOrders(); })
{}
Orderbook::~Orderbook() {
shutdown_.store(true, std::memory_order_release);
shutdownCV_.notify_one();
pruneThread_.join();
}
// ─────────────────────────────────────────────────────────────────────────────
// GFD pruning thread
// ─────────────────────────────────────────────────────────────────────────────
void Orderbook::PruneGoodForDayOrders() {
using namespace std::chrono;
while (true) {
const auto now = system_clock::now();
const auto now_t = system_clock::to_time_t(now);
std::tm parts{};
#ifdef _WIN32
localtime_s(&parts, &now_t);
#else
localtime_r(&now_t, &parts);
#endif
if (parts.tm_hour >= 16) parts.tm_mday += 1;
parts.tm_hour = 16; parts.tm_min = 0; parts.tm_sec = 0;
auto next = system_clock::from_time_t(mktime(&parts));
auto till = next - now + milliseconds(100);
{
std::unique_lock lk{ordersMutex_};
if (shutdown_.load(std::memory_order_acquire) ||
shutdownCV_.wait_for(lk, till) == std::cv_status::no_timeout)
return;
}
OrderIds ids;
{
std::scoped_lock lk{ordersMutex_};
for (const auto& [id, entry] : orders_)
if (entry.order->GetOrderType() == OrderType::GoodForDay)
ids.push_back(id);
}
CancelOrdersInternal(ids);
}
}
// ─────────────────────────────────────────────────────────────────────────────
// AddOrder
// ─────────────────────────────────────────────────────────────────────────────
Trades Orderbook::AddOrder(OrderPointer order) {
std::scoped_lock lk{ordersMutex_};
return AddOrderInternal(order);
}
// ─────────────────────────────────────────────────────────────────────────────
// AddOrderInternal — called with mutex already held
// ─────────────────────────────────────────────────────────────────────────────
Trades Orderbook::AddOrderInternal(OrderPointer order) {
stats_.totalOrders.fetch_add(1, std::memory_order_relaxed);
stats_.seqNum.fetch_add(1, std::memory_order_relaxed);
if (orders_.contains(order->GetOrderId()))
return {};
// PostOnly: reject if crosses spread
if (order->GetOrderType() == OrderType::PostOnly) {
if (CanMatch(order->GetSide(), order->GetPrice())) {
order->SetStatus(OrderStatus::Rejected);
return {};
}
}
// StopLimit: park if not yet triggered
if (order->GetOrderType() == OrderType::StopLimit) {
Price lastTrade = stats_.lastTradePrice.load(std::memory_order_relaxed);
bool triggered = false;
if (order->GetSide() == Side::Buy && lastTrade >= order->GetStopPrice()) triggered = true;
if (order->GetSide() == Side::Sell && lastTrade <= order->GetStopPrice()) triggered = true;
if (!triggered) {
if (order->GetSide() == Side::Buy)
stopBuys_.emplace(order->GetStopPrice(), order);
else
stopSells_.emplace(order->GetStopPrice(), order);
return {};
}
order = std::make_shared<Order>(
OrderType::GoodTillCancel,
order->GetOrderId(), order->GetSide(), order->GetPrice(),
order->GetRemainingQuantity());
}
// Market order: use worst available price
if (order->GetOrderType() == OrderType::Market) {
if (order->GetSide() == Side::Buy && !asks_.empty()) {
const auto& [worstAsk, _] = *asks_.rbegin();
order->ToGoodTillCancel(worstAsk);
} else if (order->GetSide() == Side::Sell && !bids_.empty()) {
const auto& [worstBid, _] = *bids_.rbegin();
order->ToGoodTillCancel(worstBid);
} else {
return {};
}
}
// FAK / IOC: reject if no match available
if (order->GetOrderType() == OrderType::FillAndKill ||
order->GetOrderType() == OrderType::ImmediateOrCancel) {
if (!CanMatch(order->GetSide(), order->GetPrice()))
return {};
}
// FOK: reject if cannot fully fill
if (order->GetOrderType() == OrderType::FillOrKill) {
if (!CanFullyFill(order->GetSide(), order->GetPrice(), order->GetInitialQuantity()))
return {};
}
// Insert into price level
OrderPointers::iterator it;
if (order->GetSide() == Side::Buy) {
auto& level = bids_[order->GetPrice()];
level.push_back(order);
it = std::prev(level.end());
} else {
auto& level = asks_[order->GetPrice()];
level.push_back(order);
it = std::prev(level.end());
}
orders_[order->GetOrderId()] = {order, it};
OnOrderAdded(order);
if (onAdded_) onAdded_(*order);
// Get trades from the matching engine
Trades trades = MatchOrders();
// O(1) FAK/IOC cleanup (replaces the O(N) sweep)
if (order->GetOrderType() == OrderType::FillAndKill ||
order->GetOrderType() == OrderType::ImmediateOrCancel) {
// If the order is still in the book after matching, cancel the remainder
if (orders_.contains(order->GetOrderId())) {
CancelOrderInternal(order->GetOrderId());
}
}
return trades;
}
// ─────────────────────────────────────────────────────────────────────────────
// CancelOrder
// ─────────────────────────────────────────────────────────────────────────────
void Orderbook::CancelOrder(OrderId orderId) {
std::scoped_lock lk{ordersMutex_};
CancelOrderInternal(orderId);
}
void Orderbook::CancelOrdersInternal(const OrderIds& ids) {
std::scoped_lock lk{ordersMutex_};
for (auto id : ids) CancelOrderInternal(id);
}
// BUG FIX #4: Replaced .at() with .find() to avoid std::out_of_range crash
// when orders_ and bids_/asks_ are in inconsistent state. .at() would throw
// and leave mutex locked. Now we safely skip missing price levels.
void Orderbook::CancelOrderInternal(OrderId orderId) {
if (!orders_.contains(orderId)) return;
const auto [order, it] = orders_.at(orderId);
orders_.erase(orderId);
if (order->GetSide() == Side::Sell) {
auto price = order->GetPrice();
auto levelIt = asks_.find(price);
if (levelIt != asks_.end()) {
levelIt->second.erase(it);
if (levelIt->second.empty()) asks_.erase(levelIt);
}
} else {
auto price = order->GetPrice();
auto levelIt = bids_.find(price);
if (levelIt != bids_.end()) {
levelIt->second.erase(it);
if (levelIt->second.empty()) bids_.erase(levelIt);
}
}
order->Cancel();
OnOrderCancelled(order);
if (onCancelled_) onCancelled_(*order);
stats_.totalCancels.fetch_add(1, std::memory_order_relaxed);
}
// ─────────────────────────────────────────────────────────────────────────────
// ModifyOrder
// ─────────────────────────────────────────────────────────────────────────────
Trades Orderbook::ModifyOrder(OrderModify mod) {
std::scoped_lock lk{ordersMutex_};
if (!orders_.contains(mod.GetOrderId())) return {};
OrderType type = orders_.at(mod.GetOrderId()).order->GetOrderType();
CancelOrderInternal(mod.GetOrderId());
return AddOrderInternal(mod.ToOrderPointer(type));
}
// ─────────────────────────────────────────────────────────────────────────────
// MatchOrders
//
// BUG FIX #2: Iterator invalidation fixed — structured bindings (auto&) on
// map iterators dangled when bids_.erase(bidPrice) was called inside the loop.
// Now we copy Price values and use find() after erasure is safe.
//
// BUG FIX #3: Stop injection deferred — CheckAndTriggerStops now only pushes
// to pendingStops_. After the main matching loop exits, we drain pendingStops_
// and inject via AddOrderInternal. This breaks the recursive call chain:
// AddOrderInternal → MatchOrders → CheckAndTriggerStops → AddOrderInternal
// which could stack-overflow on stop-order chains.
// ─────────────────────────────────────────────────────────────────────────────
Trades Orderbook::MatchOrders() {
Trades trades;
trades.reserve(32);
while (!bids_.empty() && !asks_.empty()) {
// BUG FIX #2: Copy price values — do NOT hold references across erasure
auto bidIt = bids_.begin();
auto askIt = asks_.begin();
Price bidPrice = bidIt->first;
Price askPrice = askIt->first;
auto& bidLevel = bidIt->second;
auto& askLevel = askIt->second;
if (bidPrice < askPrice) break;
while (!bidLevel.empty() && !askLevel.empty()) {
auto bid = bidLevel.front();
auto ask = askLevel.front();
Quantity qty = std::min(bid->GetRemainingQuantity(),
ask->GetRemainingQuantity());
bid->Fill(qty);
ask->Fill(qty);
if (bid->IsFilled()) {
bidLevel.pop_front();
orders_.erase(bid->GetOrderId());
}
if (ask->IsFilled()) {
askLevel.pop_front();
orders_.erase(ask->GetOrderId());
}
auto ts = std::chrono::steady_clock::now().time_since_epoch().count();
Trade trade{
TradeInfo{bid->GetOrderId(), bid->GetPrice(), qty},
TradeInfo{ask->GetOrderId(), ask->GetPrice(), qty},
ts
};
trades.push_back(trade);
OnOrderMatched(bid->GetPrice(), qty, bid->IsFilled());
OnOrderMatched(ask->GetPrice(), qty, ask->IsFilled());
stats_.totalTrades.fetch_add(1, std::memory_order_relaxed);
stats_.totalVolume.fetch_add(qty, std::memory_order_relaxed);
stats_.lastTradePrice.store(ask->GetPrice(), std::memory_order_relaxed);
stats_.lastTradeQty.store(qty, std::memory_order_relaxed);
if (onTrade_) onTrade_(trade);
// BUG FIX #3: Only COLLECTS stops into pendingStops_, does NOT inject yet
CheckAndTriggerStops(ask->GetPrice());
}
if (bidLevel.empty()) bids_.erase(bidPrice);
if (askLevel.empty()) asks_.erase(askPrice);
}
// BUG FIX #3: Drain pendingStops_ AFTER matching is fully complete.
// Swap first so that any stops triggered by injected orders go into
// a fresh pendingStops_ and are processed in next AddOrderInternal call,
// not recursively here.
std::vector<OrderPointer> stops;
std::swap(stops, pendingStops_);
for (auto& o : stops) {
auto limitOrder = std::make_shared<Order>(
OrderType::GoodTillCancel,
o->GetOrderId(), o->GetSide(), o->GetPrice(),
o->GetRemainingQuantity());
AddOrderInternal(limitOrder);
}
return trades;
}
// ─────────────────────────────────────────────────────────────────────────────
// BUG FIX #3: CheckAndTriggerStops — only collects into pendingStops_.
// No longer calls AddOrderInternal directly, breaking the recursion chain.
// ─────────────────────────────────────────────────────────────────────────────
void Orderbook::CheckAndTriggerStops(Price lastTrade) {
for (auto it = stopBuys_.begin(); it != stopBuys_.end(); ) {
if (lastTrade >= it->first) {
pendingStops_.push_back(it->second);
it = stopBuys_.erase(it);
} else ++it;
}
for (auto it = stopSells_.begin(); it != stopSells_.end(); ) {
if (lastTrade <= it->first) {
pendingStops_.push_back(it->second);
it = stopSells_.erase(it);
} else ++it;
}
}
// ─────────────────────────────────────────────────────────────────────────────
// CanMatch / CanFullyFill
// ─────────────────────────────────────────────────────────────────────────────
bool Orderbook::CanMatch(Side side, Price price) const {
if (side == Side::Buy) {
if (asks_.empty()) return false;
return price >= asks_.begin()->first;
} else {
if (bids_.empty()) return false;
return price <= bids_.begin()->first;
}
}
bool Orderbook::CanFullyFill(Side side, Price price, Quantity qty) const {
if (!CanMatch(side, price)) return false;
Quantity avail = 0;
if (side == Side::Buy) {
for (const auto& [lvlPrice, level] : asks_) {
if (lvlPrice > price) break;
for (const auto& o : level) avail += o->GetRemainingQuantity();
if (avail >= qty) return true;
}
} else {
for (const auto& [lvlPrice, level] : bids_) {
if (lvlPrice < price) break;
for (const auto& o : level) avail += o->GetRemainingQuantity();
if (avail >= qty) return true;
}
}
return false;
}
// ─────────────────────────────────────────────────────────────────────────────
// Level data tracking
// ─────────────────────────────────────────────────────────────────────────────
void Orderbook::UpdateLevelData(Price price, Quantity qty, LevelData::Action action) {
auto& d = levelData_[price];
switch (action) {
case LevelData::Action::Add:
d.quantity += qty; ++d.count; break;
case LevelData::Action::Remove:
if (d.quantity >= qty) d.quantity -= qty; else d.quantity = 0;
if (d.count > 0) --d.count;
break;
case LevelData::Action::Match:
if (d.quantity >= qty) d.quantity -= qty; else d.quantity = 0;
break;
}
if (d.count == 0) levelData_.erase(price);
}
void Orderbook::OnOrderAdded(OrderPointer order) {
UpdateLevelData(order->GetPrice(), order->GetInitialQuantity(), LevelData::Action::Add);
}
void Orderbook::OnOrderCancelled(OrderPointer order) {
UpdateLevelData(order->GetPrice(), order->GetRemainingQuantity(), LevelData::Action::Remove);
}
void Orderbook::OnOrderMatched(Price price, Quantity qty, bool fullyFilled) {
UpdateLevelData(price, qty,
fullyFilled ? LevelData::Action::Remove : LevelData::Action::Match);
}
// ─────────────────────────────────────────────────────────────────────────────
// Query methods
// ─────────────────────────────────────────────────────────────────────────────
std::size_t Orderbook::Size() const {
std::scoped_lock lk{ordersMutex_};
return orders_.size();
}
bool Orderbook::HasOrder(OrderId id) const {
std::scoped_lock lk{ordersMutex_};
return orders_.contains(id);
}
Price Orderbook::BestBid() const {
std::scoped_lock lk{ordersMutex_};
if (bids_.empty()) return Constants::InvalidPrice;
return bids_.begin()->first;
}
Price Orderbook::BestAsk() const {
std::scoped_lock lk{ordersMutex_};
if (asks_.empty()) return Constants::InvalidPrice;
return asks_.begin()->first;
}
Price Orderbook::MidPrice() const {
auto bid = BestBid(), ask = BestAsk();
if (bid == Constants::InvalidPrice || ask == Constants::InvalidPrice)
return Constants::InvalidPrice;
return (bid + ask) / 2;
}
Price Orderbook::Spread() const {
auto bid = BestBid(), ask = BestAsk();
if (bid == Constants::InvalidPrice || ask == Constants::InvalidPrice)
return 0;
return ask - bid;
}
OrderbookSnapshot Orderbook::GetSnapshot() const {
std::scoped_lock lk{ordersMutex_};
OrderbookSnapshot snap;
snap.seqNum = stats_.seqNum.load();
snap.timestampNs = std::chrono::steady_clock::now().time_since_epoch().count();
snap.lastTradePrice = stats_.lastTradePrice.load();
snap.lastTradeQty = stats_.lastTradeQty.load();
snap.totalVolume = stats_.totalVolume.load();
snap.tradeCount = stats_.totalTrades.load();
snap.bids.reserve(std::min(bids_.size(), size_t(20)));
snap.asks.reserve(std::min(asks_.size(), size_t(20)));
auto calcLevel = [](Price price, const OrderPointers& orders) -> LevelInfo {
Quantity qty = 0;
for (const auto& o : orders) qty += o->GetRemainingQuantity();
return {price, qty, (uint32_t)orders.size()};
};
int depth = 0;
for (const auto& [price, orders] : bids_) {
snap.bids.push_back(calcLevel(price, orders));
if (++depth >= 20) break;
}
depth = 0;
for (const auto& [price, orders] : asks_) {
snap.asks.push_back(calcLevel(price, orders));
if (++depth >= 20) break;
}
return snap;
} |