Update src/app.py

src/app.py

@@ -556,7 +556,7 @@ with tab2:
 with tab3:
     st.header("⚓ Qualification Board Simulator")
     
-    # 1. MODE SELECTION
+    # 1. MODE SELECTION & RESET LOGIC
     col_mode, col_streak = st.columns([3, 1])
     with col_mode:
         quiz_mode = st.radio(
@@ -564,14 +564,27 @@ with tab3:
             ["⚡ Acronym Lightning Round", "📖 Document Deep Dive"],
             horizontal=True
         )
+
+    # Initialize Session State Variables if missing
+    if "last_quiz_mode" not in st.session_state:
+        st.session_state.last_quiz_mode = quiz_mode
+        
+    if "quiz_trigger" not in st.session_state:
+        st.session_state.quiz_trigger = False
+
+    # GHOST IMAGE FIX: Detect Mode Switch
+    # If the user toggled the radio button since the last run, wipe the state.
+    if st.session_state.last_quiz_mode != quiz_mode:
+        st.session_state.quiz_state["active"] = False
+        st.session_state.quiz_state["question_data"] = None
+        st.session_state.quiz_state["feedback"] = None
+        st.session_state.quiz_state["generated_question_text"] = ""
+        st.session_state.last_quiz_mode = quiz_mode
+        st.rerun() # Force a clean refresh immediately
     
-    # Initialize State
+    # Initialize Engine & Shortcut to State
     quiz = QuizEngine()
     qs = st.session_state.quiz_state
-    
-    # NEW: Trigger State for "Next Question" chaining
-    if "quiz_trigger" not in st.session_state:
-        st.session_state.quiz_trigger = False
 
     # Display Streak
     with col_streak:
@@ -580,7 +593,7 @@ with tab3:
 
     st.divider()
 
-    # --- GENERATION FUNCTION (Reused for Button AND Auto-Trigger) ---
+    # --- GENERATION FUNCTION ---
     def generate_question():
         with st.spinner("Consulting the Board..."):
             # MODE A: ACRONYMS
@@ -610,6 +623,7 @@ with tab3:
                             300, model_choice, st.session_state.get("user_openai_key")
                         )
                         
+                        # Filter out skips or empty responses
                         if "SKIP" not in question_text and len(question_text) > 10:
                             valid_question_found = True
                             qs["active"] = True
@@ -620,12 +634,11 @@ with tab3:
                 if not valid_question_found:
                     st.warning("Tried to find a good engineering question but the available text was too administrative. Try uploading denser technical notes!")
 
-    # 2. AUTO-TRIGGER CHECK
-    # If the user clicked "Next Question", this runs immediately on rerun
+    # 2. AUTO-TRIGGER (Chained Question Logic)
     if st.session_state.quiz_trigger:
-        st.session_state.quiz_trigger = False # Reset flag
+        st.session_state.quiz_trigger = False
         generate_question()
-        st.rerun() # Rerun to display the new question
+        st.rerun()
 
     # 3. MANUAL START BUTTON
     if not qs["active"]:
@@ -637,9 +650,11 @@ with tab3:
     if qs["active"]:
         st.markdown(f"### {qs['generated_question_text']}")
         
+        # Context Hint
         if "document" in qs.get("question_data", {}).get("type", ""):
             st.caption(f"Source: *{qs['question_data']['source_file']}*")
         
+        # Answer Form
         with st.form(key="quiz_response"):
             user_ans = st.text_area("Your Answer:")
             sub = st.form_submit_button("Submit Answer")
@@ -648,6 +663,7 @@ with tab3:
             with st.spinner("Grading..."):
                 data = qs["question_data"]
                 
+                # Grading Logic Branch
                 if data["type"] == "acronym":
                     prompt = quiz.construct_acronym_grading_prompt(
                         data["term"], data["correct_definition"], user_ans
@@ -664,6 +680,7 @@ with tab3:
                 
                 qs["feedback"] = grade
                 
+                # Streak Logic
                 if "GRADE:** PASS" in grade or "GRADE:** Pass" in grade:
                     qs["streak"] += 1
                 elif "GRADE:** FAIL" in grade:
@@ -671,7 +688,7 @@ with tab3:
                     
                 st.rerun()
 
-    # 5. FEEDBACK AREA
+    # 5. FEEDBACK AREA (Deduplicated)
     if qs["feedback"]:
         st.divider()
         if "PASS" in qs["feedback"]:
@@ -684,7 +701,7 @@ with tab3:
             
         st.markdown(qs["feedback"])
         
-        # Display Correct Answer
+        # Display Answer Key
         data = qs["question_data"]
         if data["type"] == "acronym":
              st.info(f"**Official Definition:** {data['correct_definition']}")
@@ -692,36 +709,9 @@ with tab3:
             with st.expander("Show Source Text (Answer Key)"):
                 st.info(data["context_text"])
         
-        # FIXED: "Next Question" now sets the trigger flag instead of just resetting state
+        # Next Question Button
         if st.button("Next Question ➡️"):
             st.session_state.quiz_trigger = True
-            qs["active"] = False
-            qs["question_data"] = None
-            qs["feedback"] = None
-            st.rerun()
-
-    # 4. FEEDBACK AREA (MERGED & FIXED)
-    if qs["feedback"]:
-        st.divider()
-        if "PASS" in qs["feedback"]:
-            st.success("✅ CORRECT")
-        else:
-            if "FAIL" in qs["feedback"]:
-                st.error("❌ INCORRECT")
-            else:
-                st.warning("⚠️ PARTIAL / COMMENTARY")
-            
-        st.markdown(qs["feedback"])
-        
-        # Display Correct Answer based on type
-        data = qs["question_data"]
-        if data["type"] == "acronym":
-             st.info(f"**Official Definition:** {data['correct_definition']}")
-        elif data["type"] == "document":
-            with st.expander("Show Source Text (Answer Key)"):
-                st.info(data["context_text"])
-        
-        if st.button("Next Question ➡️"):
             qs["active"] = False
             qs["question_data"] = None
             qs["feedback"] = None