Update app.py

app.py

@@ -17,59 +17,60 @@ META_FILE = "navy_metadata.pkl"
 
 st.set_page_config(page_title="Navy Policy Architect", layout="wide", page_icon="⚓")
 
-# --- CLOUD SYNC MANAGER (UPGRADED) ---
+# --- CLOUD SYNC MANAGER (ROBUST) ---
 class SyncManager:
     """Handles downloading/uploading the Database & Index to Hugging Face"""
     
     @staticmethod
     def get_remote_dbs():
-        """Scans the Hugging Face Repo for available .db files"""
         if not HF_TOKEN: return []
         try:
             api = HfApi(token=HF_TOKEN)
             files = api.list_repo_files(repo_id=DATASET_REPO_ID, repo_type="dataset")
-            # Filter for .db files (excluding potential system files)
             dbs = [f for f in files if f.endswith(".db")]
             return dbs
         except Exception as e:
-            print(f"Error listing DBs: {e}")
             return []
 
     @staticmethod
     def pull_data(db_filename):
-        if not HF_TOKEN: return False
+        if not HF_TOKEN: 
+            st.error("HF_TOKEN missing.")
+            return False
         try:
-            # Download Specific SQLite DB
-            if not os.path.exists(db_filename):
-                hf_hub_download(repo_id=DATASET_REPO_ID, filename=db_filename, local_dir=".", token=HF_TOKEN)
+            # FIX: Remove "if os.path.exists" check. 
+            # We ALWAYS let hf_hub_download check for updates/integrity.
+            hf_hub_download(
+                repo_id=DATASET_REPO_ID, 
+                filename=db_filename, 
+                local_dir=".", 
+                token=HF_TOKEN,
+                force_download=False # It will only download if the cloud version is newer
+            )
+            
+            # Download Index (Best effort)
+            try:
+                hf_hub_download(repo_id=DATASET_REPO_ID, filename=INDEX_FILE, local_dir=".", token=HF_TOKEN)
+                hf_hub_download(repo_id=DATASET_REPO_ID, filename=META_FILE, local_dir=".", token=HF_TOKEN)
+            except:
+                pass 
             
-            # Download FAISS Index (Note: We use one shared index for simplicity in this demo, 
-            # but ideally you'd have 'navy_index_eng.faiss', etc.)
-            if not os.path.exists(INDEX_FILE):
-                try:
-                    hf_hub_download(repo_id=DATASET_REPO_ID, filename=INDEX_FILE, local_dir=".", token=HF_TOKEN)
-                    hf_hub_download(repo_id=DATASET_REPO_ID, filename=META_FILE, local_dir=".", token=HF_TOKEN)
-                except:
-                    pass # It's okay if index doesn't exist yet
             return True
         except Exception as e:
-            st.error(f"Sync Error (Pull): {e}")
-            return False
+            # We return the actual error message so the UI can show it permanently
+            return str(e)
 
     @staticmethod
     def push_data(db_filename):
         if not HF_TOKEN: return
         api = HfApi(token=HF_TOKEN)
         try:
-            # Upload Specific SQLite DB
             api.upload_file(path_or_fileobj=db_filename, path_in_repo=db_filename, repo_id=DATASET_REPO_ID, repo_type="dataset")
-            # Upload FAISS Index
             api.upload_file(path_or_fileobj=INDEX_FILE, path_in_repo=INDEX_FILE, repo_id=DATASET_REPO_ID, repo_type="dataset")
             api.upload_file(path_or_fileobj=META_FILE, path_in_repo=META_FILE, repo_id=DATASET_REPO_ID, repo_type="dataset")
             st.toast("Cloud Sync Complete!", icon="☁️")
         except Exception as e:
             st.error(f"Sync Error (Push): {e}")
-
 # --- SIDEBAR: KNOWLEDGE BASE SELECTOR ---
 with st.sidebar:
     st.header("🗄️ Knowledge Base")
@@ -96,14 +97,27 @@ with st.sidebar:
     # --- INITIALIZATION (Dynamic based on selection) ---
     # If the DB has changed or isn't loaded, load it now
     if 'current_db_name' not in st.session_state or st.session_state.current_db_name != selected_db:
+        
+        # We use an empty container to hold the error if it happens
+        error_container = st.empty()
+        
         with st.spinner(f"Loading {selected_db} from Cloud..."):
-            SyncManager.pull_data(selected_db)
-            st.session_state.db = DatabaseManager(selected_db)
-            st.session_state.search_engine = SearchEngine() # This resets the search engine for the new DB
-            st.session_state.current_db_name = selected_db
-            st.rerun() # Refresh to ensure everything is synced
-
-    st.divider()
+            
+            # 1. Attempt the Pull
+            result = SyncManager.pull_data(selected_db)
+            
+            # 2. Check the Result
+            if result is True:
+                # Success! Initialize normally
+                st.session_state.db = DatabaseManager(selected_db)
+                st.session_state.search_engine = SearchEngine()
+                st.session_state.current_db_name = selected_db
+                st.rerun()
+            else:
+                # Failure! Show the error and STOP.
+                # Do NOT create an empty database. Do NOT rerun.
+                error_container.error(f"CRITICAL ERROR: Could not load database.\n\nDetails: {result}")
+                st.stop()
 
     # 3. Upload Section
     if "uploader_key" not in st.session_state: