Spaces:
Sleeping
Sleeping
Peter Yang commited on
Commit Β·
f9f0566
1
Parent(s): 917635f
Add summary of fixes for bilingual file and Message section issues
Browse files- FIXES_SUMMARY.md +184 -0
FIXES_SUMMARY.md
ADDED
|
@@ -0,0 +1,184 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Fixes Summary: Bilingual File and Message Section Issues
|
| 2 |
+
|
| 3 |
+
**Date**: 2025-11-12
|
| 4 |
+
**Issues Fixed**: Bilingual file persistence, Message section content, Content duplication
|
| 5 |
+
|
| 6 |
+
---
|
| 7 |
+
|
| 8 |
+
## Issues Identified
|
| 9 |
+
|
| 10 |
+
1. **Bilingual file not saved to current directory**
|
| 11 |
+
- File was created in temp directory but not copied to current directory
|
| 12 |
+
- File was lost after temp directory cleanup
|
| 13 |
+
|
| 14 |
+
2. **Message section not appearing correctly**
|
| 15 |
+
- Bilingual file path wasn't being found correctly
|
| 16 |
+
- Message section was empty or had wrong content
|
| 17 |
+
|
| 18 |
+
3. **Content duplication**
|
| 19 |
+
- PDF content was being processed as a document, causing duplication
|
| 20 |
+
- Bilingual file content was mixed with extracted PDF content
|
| 21 |
+
- Same content appeared in multiple sections
|
| 22 |
+
|
| 23 |
+
4. **Qwen2.5 not used in translate_document**
|
| 24 |
+
- `translate_document()` was creating DocumentProcessingAgent without `use_qwen_translation=True`
|
| 25 |
+
|
| 26 |
+
---
|
| 27 |
+
|
| 28 |
+
## Fixes Applied
|
| 29 |
+
|
| 30 |
+
### 1. Save Bilingual File to Current Directory β
|
| 31 |
+
|
| 32 |
+
**File**: `app.py`
|
| 33 |
+
|
| 34 |
+
**Change**:
|
| 35 |
+
```python
|
| 36 |
+
# Copy bilingual file to current directory for persistence and easy access
|
| 37 |
+
bilingual_filename = os.path.basename(bilingual_path_temp)
|
| 38 |
+
bilingual_path = bilingual_filename # Save in current directory
|
| 39 |
+
shutil.copy2(bilingual_path_temp, bilingual_path)
|
| 40 |
+
progress(0.5, desc=f"πΎ Saved bilingual translation to {bilingual_filename}...")
|
| 41 |
+
```
|
| 42 |
+
|
| 43 |
+
**Result**: Bilingual file is now saved to current directory (e.g., `test_sermon_bilingual.txt`)
|
| 44 |
+
|
| 45 |
+
---
|
| 46 |
+
|
| 47 |
+
### 2. Use Qwen2.5 in translate_document β
|
| 48 |
+
|
| 49 |
+
**File**: `app.py`
|
| 50 |
+
|
| 51 |
+
**Change**:
|
| 52 |
+
```python
|
| 53 |
+
# Initialize processor with Qwen2.5 translation enabled
|
| 54 |
+
processor = DocumentProcessingAgent(GEMMA_BACKEND_URL, use_qwen_translation=True)
|
| 55 |
+
```
|
| 56 |
+
|
| 57 |
+
**Result**: Translation now uses Qwen2.5 by default
|
| 58 |
+
|
| 59 |
+
---
|
| 60 |
+
|
| 61 |
+
### 3. Prevent PDF and Bilingual File Duplication β
|
| 62 |
+
|
| 63 |
+
**File**: `document_processing_agent.py`
|
| 64 |
+
|
| 65 |
+
**Change**:
|
| 66 |
+
```python
|
| 67 |
+
async def process_documents(self, document_paths: List[str]) -> List[DocumentContent]:
|
| 68 |
+
"""Process multiple documents and extract structured content"""
|
| 69 |
+
results = []
|
| 70 |
+
|
| 71 |
+
for doc_path in document_paths:
|
| 72 |
+
# Skip bilingual text files - they're handled separately for Message section
|
| 73 |
+
if doc_path and isinstance(doc_path, str) and doc_path.endswith('_bilingual.txt'):
|
| 74 |
+
continue
|
| 75 |
+
|
| 76 |
+
# Skip PDF files - they're only used for date extraction, not content extraction
|
| 77 |
+
# PDF content should not be processed as it causes duplication
|
| 78 |
+
if doc_path and isinstance(doc_path, str) and doc_path.lower().endswith('.pdf'):
|
| 79 |
+
continue
|
| 80 |
+
|
| 81 |
+
# ... process other documents
|
| 82 |
+
```
|
| 83 |
+
|
| 84 |
+
**Result**:
|
| 85 |
+
- PDF files are skipped during document processing (only used for date extraction)
|
| 86 |
+
- Bilingual files are skipped during document processing (handled separately)
|
| 87 |
+
- No duplication from PDF or bilingual file content
|
| 88 |
+
|
| 89 |
+
---
|
| 90 |
+
|
| 91 |
+
### 4. Message Section Uses Only Bilingual Content β
|
| 92 |
+
|
| 93 |
+
**File**: `document_processing_agent.py`
|
| 94 |
+
|
| 95 |
+
**Change**:
|
| 96 |
+
```python
|
| 97 |
+
# Replace Message section with Bilingual Document Translation
|
| 98 |
+
# Load bilingual document and format it - this is the ONLY source for Message section
|
| 99 |
+
bilingual_content = self._load_bilingual_document(document_sources)
|
| 100 |
+
messages_formatted = "Sermon message to be prepared"
|
| 101 |
+
|
| 102 |
+
if bilingual_content and bilingual_content.strip():
|
| 103 |
+
# ... format bilingual content ...
|
| 104 |
+
messages_formatted = f"""*Date: {formatted_date}*
|
| 105 |
+
|
| 106 |
+
{bilingual_text}"""
|
| 107 |
+
else:
|
| 108 |
+
# No bilingual document available - use fallback message
|
| 109 |
+
# Don't use aggregated_content.get('messages') to avoid duplication from PDF processing
|
| 110 |
+
messages_formatted = "Sermon message to be prepared"
|
| 111 |
+
```
|
| 112 |
+
|
| 113 |
+
**Result**:
|
| 114 |
+
- Message section ONLY uses bilingual file content
|
| 115 |
+
- No mixing with extracted PDF content
|
| 116 |
+
- No duplication
|
| 117 |
+
|
| 118 |
+
---
|
| 119 |
+
|
| 120 |
+
## Expected Behavior After Fixes
|
| 121 |
+
|
| 122 |
+
### File Flow
|
| 123 |
+
|
| 124 |
+
1. **DOCX Upload** β Extract content
|
| 125 |
+
2. **Translation** β Create `{docx_name}_bilingual.txt` in temp directory
|
| 126 |
+
3. **Copy to Current Directory** β Save `{docx_name}_bilingual.txt` to current directory
|
| 127 |
+
4. **Generate Program** β Use bilingual file for Message section, PDF for date only
|
| 128 |
+
|
| 129 |
+
### Message Section Content
|
| 130 |
+
|
| 131 |
+
- **Source**: Only from `{docx_name}_bilingual.txt`
|
| 132 |
+
- **Format**:
|
| 133 |
+
```
|
| 134 |
+
## Message
|
| 135 |
+
|
| 136 |
+
*Date: November 9, 2025*
|
| 137 |
+
|
| 138 |
+
[Chinese paragraph 1]
|
| 139 |
+
[English translation 1]
|
| 140 |
+
|
| 141 |
+
[Chinese paragraph 2]
|
| 142 |
+
[English translation 2]
|
| 143 |
+
...
|
| 144 |
+
```
|
| 145 |
+
|
| 146 |
+
### No Duplication
|
| 147 |
+
|
| 148 |
+
- β
PDF content not processed as document
|
| 149 |
+
- β
Bilingual file not processed as document
|
| 150 |
+
- β
Message section only uses bilingual file
|
| 151 |
+
- β
No duplicate content in other sections
|
| 152 |
+
|
| 153 |
+
---
|
| 154 |
+
|
| 155 |
+
## Testing
|
| 156 |
+
|
| 157 |
+
To verify fixes:
|
| 158 |
+
|
| 159 |
+
1. **Check bilingual file exists**:
|
| 160 |
+
```bash
|
| 161 |
+
ls -la *_bilingual.txt
|
| 162 |
+
```
|
| 163 |
+
|
| 164 |
+
2. **Check Message section**:
|
| 165 |
+
- Open generated markdown file
|
| 166 |
+
- Verify Message section contains bilingual content
|
| 167 |
+
- Verify no duplication from PDF
|
| 168 |
+
|
| 169 |
+
3. **Check no duplication**:
|
| 170 |
+
- Verify content doesn't appear multiple times
|
| 171 |
+
- Verify PDF content not in Message section
|
| 172 |
+
- Verify bilingual content only in Message section
|
| 173 |
+
|
| 174 |
+
---
|
| 175 |
+
|
| 176 |
+
## Files Modified
|
| 177 |
+
|
| 178 |
+
- `app.py` - Save bilingual file, use Qwen2.5
|
| 179 |
+
- `document_processing_agent.py` - Skip PDF/bilingual processing, Message section fix
|
| 180 |
+
|
| 181 |
+
---
|
| 182 |
+
|
| 183 |
+
**Status**: β
**All fixes applied and committed**
|
| 184 |
+
|