Update app.py

app.py

@@ -8,32 +8,43 @@ def _resolve_openai_key(user_input: str) -> str | None:
     """
     If `user_input` is an 8-digit code matching BACKDOOR_KEY (Space secret),
     return the OPENAI_KEY (Space secret). Otherwise return `user_input`.
+    Never prints or returns secrets; just resolves which to use.
     """
     user_input = (user_input or "").strip()
 
     backdoor_code = (os.getenv("BACKDOOR_KEY") or "").strip()
+    # Only treat as backdoor attempt if it's exactly 8 digits and we have a BACKDOOR_KEY.
     is_candidate_code = user_input.isdigit() and len(user_input) == 8 and backdoor_code
 
     if is_candidate_code and hmac.compare_digest(user_input, backdoor_code):
+        # Use the real key stored as a Space secret
         resolved = os.getenv("OPENAI_KEY")
-        return resolved if resolved else None
+        if not resolved:
+            # Fail safe if OPENAI_KEY isn't configured
+            return None
+        return resolved
 
+    # Fallback to whatever the user typed (normal behavior)
     return user_input if user_input else None
 
 
-def complete_text(prompt, max_tokens, temperature, top_p, seed, openai_api_key_input):
+def complete_text(prompt, max_tokens, temperature, top_p, openai_api_key_input):
     """
-    Get a plain text completion from OpenAI with optional seed.
+    Get a plain text completion from OpenAI.
+    Supports a secret 8-digit passcode in the API key field that swaps in the
+    Space secret OPENAI_KEY when it matches BACKDOOR_KEY.
     """
     resolved_key = _resolve_openai_key(openai_api_key_input)
     if not resolved_key:
-        return "⚠️ Missing or invalid API key."
+        return "⚠️ Missing or invalid API key. (Tip: set OPENAI_KEY/BACKDOOR_KEY in Space secrets, or paste a valid key.)"
 
     try:
         client = OpenAI(api_key=resolved_key)
 
-        kwargs = dict(
-            model="gpt-3.5-turbo-instruct",  # legacy instruct model
+        response_text = ""
+        stream = client.completions.create(
+            # NOTE: gpt-3.5-turbo-instruct is legacy. Consider switching to a current instruct-capable model.
+            model="gpt-3.5-turbo-instruct",
             prompt=prompt,
             max_tokens=int(max_tokens),
             temperature=float(temperature),
@@ -41,13 +52,6 @@ def complete_text(prompt, max_tokens, temperature, top_p, seed, openai_api_key_i
             stream=True,
         )
 
-        # Only pass seed if user entered one
-        if seed and str(seed).isdigit():
-            kwargs["seed"] = int(seed)
-
-        response_text = ""
-        stream = client.completions.create(**kwargs)
-
         for event in stream:
             if hasattr(event, "choices") and event.choices:
                 token = event.choices[0].text or ""
@@ -55,12 +59,15 @@ def complete_text(prompt, max_tokens, temperature, top_p, seed, openai_api_key_i
                 yield response_text
 
     except Exception as e:
-        yield f"❌ Error: {type(e).__name__}. Check model, key, or parameters."
+        # Don't leak secrets or full tracebacks to the UI.
+        yield f"❌ Error while generating completion: {type(e).__name__}. Check your model name, key, or params."
 
 
 with gr.Blocks() as demo:
     gr.Markdown("## ✍️ Text Completion Demo (OpenAI instruct)")
-    gr.Markdown("Enter a prompt, adjust decoding parameters, and watch the model complete your text.")
+    gr.Markdown(
+        "Enter a prompt, adjust decoding parameters, and watch the model complete your text."
+    )
 
     with gr.Row():
         with gr.Column(scale=2):
@@ -78,11 +85,6 @@ with gr.Blocks() as demo:
             top_p = gr.Slider(
                 minimum=0.1, maximum=1.0, value=1.0, step=0.05, label="Top-p"
             )
-            seed = gr.Textbox(
-                placeholder="Optional integer seed for reproducibility",
-                label="🎲 Seed",
-                type="text",
-            )
             api_key = gr.Textbox(
                 placeholder="sk-... Paste your OpenAI API key here (or enter 8-digit passcode)",
                 label="🔑 OpenAI API Key",
@@ -97,9 +99,10 @@ with gr.Blocks() as demo:
 
     submit.click(
         fn=complete_text,
-        inputs=[prompt, max_tokens, temperature, top_p, seed, api_key],
+        inputs=[prompt, max_tokens, temperature, top_p, api_key],
         outputs=output,
     )
 
 if __name__ == "__main__":
+    # On Spaces, server_name='0.0.0.0' helps; share=False by default.
     demo.launch()