Update app/agent/agent.py

app/agent/agent.py

@@ -14,11 +14,14 @@ class Agent:
         self.executor = Executor(llm=self.call_llm)
 
     # =====================================================
-    # LLM CALL LAYER (ROBUST)
+    # SAFE LLM CALL LAYER (NO CRASH GUARANTEE)
     # =====================================================
     def call_llm(self, messages):
 
         try:
+            if not Config.LLM_API_URL:
+                return self._fallback("missing_llm_url")
+
             res = requests.post(
                 Config.LLM_API_URL,
                 headers={
@@ -30,33 +33,37 @@ class Agent:
                     "messages": messages,
                     "temperature": 0.2
                 },
-                timeout=60
+                timeout=30
             )
 
             # HTTP check
-            res.raise_for_status()
+            if res.status_code != 200:
+                return self._fallback(f"http_{res.status_code}")
 
-            data = res.json()
+            # JSON parse safe
+            try:
+                data = res.json()
+            except Exception:
+                return self._fallback("invalid_json")
 
             # structure validation
             if not isinstance(data, dict):
-                return self._llm_fallback("invalid_response")
+                return self._fallback("invalid_structure")
 
             if "choices" not in data:
-                return self._llm_fallback("missing_choices")
+                return self._fallback("missing_choices")
 
             return data
 
         except Exception as e:
-            return self._llm_fallback(str(e))
+            return self._fallback(str(e))
 
     # =====================================================
-    # SAFE FALLBACK RESPONSE
+    # FALLBACK RESPONSE (ALWAYS SAFE)
     # =====================================================
-    def _llm_fallback(self, error_msg):
-
+    def _fallback(self, error):
         return {
-            "error": error_msg,
+            "error": error,
             "choices": [
                 {
                     "message": {
@@ -67,19 +74,39 @@ class Agent:
         }
 
     # =====================================================
-    # GOAL MODE (AUTONOMOUS)
+    # SAFE CONTENT EXTRACTION
+    # =====================================================
+    def _extract_content(self, response):
+        try:
+            return (
+                response.get("choices", [{}])[0]
+                        .get("message", {})
+                        .get("content", "")
+            )
+        except Exception:
+            return ""
+
+    # =====================================================
+    # GOAL MODE (AUTONOMOUS SAFE)
     # =====================================================
     def run_goal(self, goal: str):
 
         try:
             plan = create_plan(goal)
+
+            if not isinstance(plan, dict):
+                return {"mode": "error", "error": "invalid_plan"}
+
         except Exception as e:
             return {
                 "mode": "error",
                 "error": f"plan_failed: {str(e)}"
             }
 
-        results = self.executor.run_plan(plan)
+        try:
+            results = self.executor.run_plan(plan)
+        except Exception as e:
+            results = {"error": f"executor_failed: {str(e)}"}
 
         return {
             "mode": "goal_execution",
@@ -98,26 +125,22 @@ class Agent:
                 "role": "system",
                 "content": Config.SYSTEM_PROMPT + """
 
-You are an autonomous coding + browser + planning agent.
+You are an autonomous coding + tool execution agent.
 
-MODES:
-- TOOL MODE → STRICT JSON ONLY
-- NORMAL MODE → plain text
+OUTPUT RULES:
+- TOOL MODE → strict JSON only
+- NORMAL MODE → plain text only
 
 TOOLS:
-- run_shell(cmd)
-- write_file(path, content)
-- read_file(path)
-- list_files(path)
-- delete_file(path)
-- browser_open(url)
-- browser_click(selector)
-- browser_type(selector, text)
-- browser_screenshot(path)
-
-RULE:
-If action → JSON ONLY
-If explanation → text only
+run_shell(cmd)
+write_file(path, content)
+read_file(path)
+list_files(path)
+delete_file(path)
+browser_open(url)
+browser_click(selector)
+browser_type(selector, text)
+browser_screenshot(path)
 """
             },
             {
@@ -127,27 +150,16 @@ If explanation → text only
         ]
 
         response = self.call_llm(messages)
-
-        # =================================================
-        # SAFE CONTENT EXTRACTION
-        # =================================================
-        content = None
-
-        try:
-            content = response.get("choices", [{}])[0] \
-                             .get("message", {}) \
-                             .get("content", None)
-        except Exception:
-            content = None
+        content = self._extract_content(response)
 
         if not content:
             return {
                 "mode": "error",
-                "response": "Empty LLM response"
+                "response": "empty_llm_response"
             }
 
         # =================================================
-        # TOOL EXECUTION PATH
+        # TOOL MODE SAFE PARSE
         # =================================================
         try:
             tool_call = json.loads(content)
@@ -156,13 +168,11 @@ If explanation → text only
 
                 result = execute_tool_call(tool_call)
 
-                # SAFE HEALER CALL (NO CRASH)
+                # optional healer (NO CRASH GUARANTEE)
                 try:
                     fix = self.executor.healer.heal(user_input, result)
-
                     if isinstance(fix, dict) and "tool" in fix:
                         result = execute_tool_call(fix)
-
                 except Exception:
                     pass
 
@@ -177,7 +187,7 @@ If explanation → text only
                     "result": result
                 }
 
-        except json.JSONDecodeError:
+        except Exception:
             pass
 
         # =================================================