Spaces:

Pabloler21
/

hollow

Running on Zero

App Files Files Community

Pabloler21 Claude Fable 5 commited on 24 days ago

Commit

07067e7

1 Parent(s): 2aa7aa5

feat: client-timed idle that resets on any interaction (60s)

Browse files

Files changed (3) hide show

app.py +15 -13
styles.css +3 -0
tests/test_app.py +19 -4

app.py CHANGED Viewed

@@ -286,21 +286,19 @@ _IDLE_TIERS = [
     ["fine. ignore me. they all do, before the end.",                   # hostile
      "you think i cannot reach you out there?"],
 ]
-_IDLE_AFTER = 35.0          # seconds of silence before Hollow speaks first
 _IDLE_AFFINITY_DROP = 3     # bond lost per ignored nudge
 _IDLE_TONE_DROP = 2         # tone soured per ignored nudge
 def _on_idle(state: dict, history: list):
-    """gr.Timer tick. When the visitor has gone quiet, Hollow speaks first —
-    escalating plead -> hurt -> hostile — and each nudge lowers the bond and
-    sours the tone. Returns (state, chatbot, voice, bond); non-speaking ticks
-    return no-op updates so a streaming turn/finale is never clobbered."""
-    # never fire while a turn is in flight (the "..." pending bubble is present)
-    # or after the end — that races the chat generator and orphans the bubble
     pending = bool(history) and "hollow-typing" in str(history[-1].get("content", ""))
-    if (pending or state.get("ended") or not history
-            or time.time() - state.get("last_activity", time.time()) < _IDLE_AFTER):
         return state, gr.update(), gr.update(), gr.update()
     state = dict(state)
     i = state.get("idle_count", 0)
@@ -717,10 +715,14 @@ with gr.Blocks(title="Hollow") as demo:
         show_progress="hidden",
     )
-    idle_timer = gr.Timer(4.0)
-    idle_timer.tick(_on_idle, [state, chatbot],
-                    [state, chatbot, voice_panel, bond_panel],
-                    show_progress="hidden")
 if __name__ == "__main__":
     # head= injects the one-shot gesture listener into <head> (Gradio 6.0 moved

     ["fine. ignore me. they all do, before the end.",                   # hostile
      "you think i cannot reach you out there?"],
 ]
 _IDLE_AFFINITY_DROP = 3     # bond lost per ignored nudge
 _IDLE_TONE_DROP = 2         # tone soured per ignored nudge
 def _on_idle(state: dict, history: list):
+    """Hidden trigger click. When the visitor has gone quiet, Hollow speaks
+    first — escalating plead -> hurt -> hostile — and each nudge lowers the
+    bond and sours the tone. Timing lives in the browser (see _HEAD_JS); here
+    we only refuse to fire while a turn is streaming or after the end."""
+    # timing now lives in the browser (see _HEAD_JS); here we only refuse to
+    # fire while a turn is streaming (the "..." bubble) or after the end
     pending = bool(history) and "hollow-typing" in str(history[-1].get("content", ""))
+    if pending or state.get("ended") or not history:
         return state, gr.update(), gr.update(), gr.update()
     state = dict(state)
     i = state.get("idle_count", 0)
         show_progress="hidden",
     )
+    # idle is timed in the browser (see _HEAD_JS): after 60s of true silence
+    # the controller clicks this hidden button, which runs the same _on_idle.
+    # Mounted + CSS-hidden (NOT visible=False, which can unmount it).
+    idle_trigger = gr.Button("idle", elem_id="idle-trigger",
+                             elem_classes="idle-trigger")
+    idle_trigger.click(_on_idle, [state, chatbot],
+                       [state, chatbot, voice_panel, bond_panel],
+                       show_progress="hidden")
 if __name__ == "__main__":
     # head= injects the one-shot gesture listener into <head> (Gradio 6.0 moved

styles.css CHANGED Viewed

@@ -858,6 +858,9 @@ footer { display: none !important; }
   overflow: hidden !important;
 }
 /* voice volume — a thin carved track beside the mute glyph */
 .volume-slider {
     -webkit-appearance: none;

   overflow: hidden !important;
 }
+/* idle trigger: mounted but invisible */
+#idle-trigger, .idle-trigger { display: none !important; }
 /* voice volume — a thin carved track beside the mute glyph */
 .volume-slider {
     -webkit-appearance: none;

tests/test_app.py CHANGED Viewed

@@ -331,11 +331,11 @@ class TestIdle:
         _, hist, _, _ = app._on_idle(state, [{"role": "assistant", "content": "x"}])
         assert hist[-1]["content"] in app._IDLE_TIERS[2]   # the hostile tier
-    def test_idle_silent_returns_four_noops_when_active_or_ended(self, monkeypatch):
-        import time as _t
         monkeypatch.setattr(app, "speak", lambda text: None)
-        s1 = _state(); s1["greeted"] = True; s1["last_activity"] = _t.time()
-        out = app._on_idle(s1, [{"role": "assistant", "content": "x"}])
         assert len(out) == 4
         assert not isinstance(out[1], list)          # chatbot untouched
@@ -349,3 +349,18 @@ class TestIdle:
                 {"role": "assistant", "content": app._PENDING}]
         out = app._on_idle(state, hist)
         assert not isinstance(out[1], list)          # chatbot untouched (no race)

         _, hist, _, _ = app._on_idle(state, [{"role": "assistant", "content": "x"}])
         assert hist[-1]["content"] in app._IDLE_TIERS[2]   # the hostile tier
+    def test_idle_silent_returns_four_noops_when_pending_or_ended(self, monkeypatch):
         monkeypatch.setattr(app, "speak", lambda text: None)
+        # timing moved to client; only pending/ended guards remain on server
+        pending = _state(); pending["greeted"] = True
+        out = app._on_idle(pending, [{"role": "assistant", "content": app._PENDING}])
         assert len(out) == 4
         assert not isinstance(out[1], list)          # chatbot untouched
                 {"role": "assistant", "content": app._PENDING}]
         out = app._on_idle(state, hist)
         assert not isinstance(out[1], list)          # chatbot untouched (no race)
+    def test_idle_fires_without_server_time_gate(self, monkeypatch):
+        monkeypatch.setattr(app, "speak", lambda t: "FAKEB64")
+        state = _state()                       # fresh last_activity (would be "not idle")
+        new_state, hist, voice, bond = app._on_idle(
+            state, [{"role": "assistant", "content": "x"}])
+        assert hist[-1]["content"] in [l for tier in app._IDLE_TIERS for l in tier]
+        assert new_state["idle_count"] == 1
+    def test_idle_still_skips_when_pending_or_ended(self):
+        pend = app._on_idle(_state(), [{"role": "assistant", "content": "...hollow-typing..."}])
+        assert pend[1] == app.gr.update() or not isinstance(pend[1], list)
+        ended = _state(); ended["ended"] = True
+        out = app._on_idle(ended, [{"role": "assistant", "content": "x"}])
+        assert not isinstance(out[1], list)    # no appended line