Merge pull request #341 from Kishalll/feature/document-rename

backend/app/routes/documents.py

@@ -20,7 +20,14 @@ from sqlalchemy.orm import Session
 
 from app.database import get_db
 from app.models import User, Document
-from app.schemas import DocumentResponse, DocumentListResponse, DocumentStatusResponse, ChunkSettings, UploadUrl
+from app.schemas import (
+    DocumentResponse,
+    DocumentListResponse,
+    DocumentStatusResponse,
+    DocumentRename,
+    ChunkSettings,
+    UploadUrl,
+)
 from app.auth import get_current_user
 from app.config import get_settings
 from app.tasks import process_document
@@ -417,6 +424,34 @@ def list_documents(
     )
 
 
+@router.patch("/{document_id}", response_model=DocumentResponse)
+def rename_document(
+    document_id: str,
+    rename: DocumentRename,
+    user: User = Depends(get_current_user),
+    db: Session = Depends(get_db),
+):
+    """
+    Rename an uploaded document without changing its stored file or vector data.
+    """
+    doc = db.query(Document).filter(
+        Document.id == document_id,
+        Document.is_deleted.is_(False),
+    ).first()
+
+    if not doc:
+        raise HTTPException(status_code=404, detail="Document not found")
+
+    if str(doc.user_id) != str(user.id):
+        raise HTTPException(status_code=403, detail="You do not have permission to rename this document")
+
+    doc.original_name = rename.name
+    db.commit()
+    db.refresh(doc)
+
+    return DocumentResponse.model_validate(doc)
+
+
 @router.get("/{document_id}", response_model=DocumentResponse)
 def get_document(
     document_id: str,

backend/app/schemas.py

@@ -1,7 +1,7 @@
 """
 Pydantic schemas for API request/response validation.
 """
-from pydantic import BaseModel, EmailStr, Field
+from pydantic import BaseModel, EmailStr, Field, field_validator
 from typing import Optional, List
 from datetime import datetime
 from app.models import UserRole
@@ -125,6 +125,18 @@ class DocumentResponse(BaseModel):
         from_attributes = True
 
 
+class DocumentRename(BaseModel):
+    name: str = Field(..., min_length=1, max_length=255)
+
+    @field_validator("name")
+    @classmethod
+    def validate_name(cls, value: str) -> str:
+        stripped = value.strip()
+        if not stripped:
+            raise ValueError("Document name cannot be empty")
+        return stripped
+
+
 class DocumentStatusResponse(BaseModel):
     id: str
     status: str

backend/tests/test_documents.py

@@ -40,6 +40,66 @@ def test_upload_rejects_unsupported_extension_before_deep_validation(client, aut
     assert "not supported" in response.json()["detail"]
 
 
+def test_rename_document_updates_original_name(client, auth_headers, ready_document, db_session):
+    response = client.patch(
+        f"/api/v1/documents/{ready_document.id}",
+        headers=auth_headers,
+        json={"name": " renamed-report.pdf "},
+    )
+
+    assert response.status_code == 200
+    payload = response.json()
+    assert payload["id"] == ready_document.id
+    assert payload["original_name"] == "renamed-report.pdf"
+
+    db_session.refresh(ready_document)
+    assert ready_document.original_name == "renamed-report.pdf"
+    assert ready_document.filename == "ready.txt"
+
+
+def test_rename_document_rejects_empty_name(client, auth_headers, ready_document):
+    response = client.patch(
+        f"/api/v1/documents/{ready_document.id}",
+        headers=auth_headers,
+        json={"name": "   "},
+    )
+
+    assert response.status_code == 422
+
+
+def test_rename_document_returns_404_for_missing_document(client, auth_headers):
+    response = client.patch(
+        "/api/v1/documents/00000000-0000-0000-0000-000000000000",
+        headers=auth_headers,
+        json={"name": "missing.pdf"},
+    )
+
+    assert response.status_code == 404
+
+
+def test_rename_document_returns_403_for_other_users_document(client, auth_headers, db_session, other_user):
+    other_document = Document(
+        user_id=other_user.id,
+        filename="other.txt",
+        original_name="other.txt",
+        file_size=64,
+        status="ready",
+    )
+    db_session.add(other_document)
+    db_session.commit()
+    db_session.refresh(other_document)
+
+    response = client.patch(
+        f"/api/v1/documents/{other_document.id}",
+        headers=auth_headers,
+        json={"name": "renamed.txt"},
+    )
+
+    assert response.status_code == 403
+    db_session.refresh(other_document)
+    assert other_document.original_name == "other.txt"
+
+
 def test_ingest_document_builds_and_saves_graph(db_session, monkeypatch, tmp_path, user):
     document = Document(
         user_id=user.id,

frontend/src/app/dashboard/page.tsx

@@ -78,7 +78,15 @@ export default function DashboardPage() {
   const [connectionError, setConnectionError] = useState("");
   const [documentsLoading, setDocumentsLoading] = useState(true);
 
+  const handleDocumentRenamed = useCallback((renamedDocument: DocInfo) => {
+    setDocuments((current) =>
+      current.map((document) => (document.id === renamedDocument.id ? renamedDocument : document))
+    );
+    setActiveDoc((current) => (current?.id === renamedDocument.id ? renamedDocument : current));
+  }, []);
+
   // Auth guard
+
   useEffect(() => {
     if (initialized && !user) router.replace("/login");
   }, [user, initialized, router]);
@@ -174,6 +182,7 @@ export default function DashboardPage() {
         setPdfPage(1);
       }}
       onDocumentsChange={loadDocuments}
+      onDocumentRenamed={handleDocumentRenamed}
     />
   );
 

frontend/src/components/document/DocumentSidebar.tsx

@@ -7,6 +7,7 @@ import { api } from "@/lib/api";
 import { ScrollArea } from "@/components/ui/scroll-area";
 import { Skeleton } from "@/components/ui/skeleton";
 import { Button } from "@/components/ui/button";
+import { Input } from "@/components/ui/input";
 import { Badge } from "@/components/ui/badge";
 import { Progress } from "@/components/ui/progress";
 import {
@@ -23,6 +24,7 @@ interface Props {
   loading?: boolean;
   onSelectDoc: (doc: DocInfo) => void;
   onDocumentsChange: () => void;
+  onDocumentRenamed: (doc: DocInfo) => void;
 }
 
 function DocumentListSkeleton() {
@@ -47,13 +49,23 @@ function DocumentListSkeleton() {
   );
 }
 
-export default function DocumentSidebar({ documents = [], activeDoc, loading = false, onSelectDoc, onDocumentsChange }: Props) {
+export default function DocumentSidebar({
+  documents = [],
+  activeDoc,
+  loading = false,
+  onSelectDoc,
+  onDocumentsChange,
+  onDocumentRenamed,
+}: Props) {
   const { t } = useTranslation();
   const [uploading, setUploading] = useState(false);
   const [uploadProgress, setUploadProgress] = useState(0);
   const [uploadError, setUploadError] = useState("");
   const [deleting, setDeleting] = useState<string | null>(null);
   const [settingsDoc, setSettingsDoc] = useState<DocInfo | null>(null);
+  const [editingDocId, setEditingDocId] = useState<string | null>(null);
+  const [draftName, setDraftName] = useState("");
+  const [renamingDocId, setRenamingDocId] = useState<string | null>(null);
 
   const onDrop = useCallback(
     (acceptedFiles: File[]) => {
@@ -119,14 +131,67 @@ export default function DocumentSidebar({ documents = [], activeDoc, loading = f
     setSettingsDoc(doc); 
   };
 
+  const startRename = (doc: DocInfo, e?: React.MouseEvent) => {
+    e?.stopPropagation();
+    setEditingDocId(doc.id);
+    setDraftName(doc.original_name);
+  };
+
+  const cancelRename = () => {
+    setEditingDocId(null);
+    setDraftName("");
+  };
+
+  const submitRename = async (doc: DocInfo) => {
+    const nextName = draftName.trim();
+
+    if (!nextName) {
+      toast.error("Document name cannot be empty");
+      return;
+    }
+
+    if (nextName === doc.original_name) {
+      cancelRename();
+      return;
+    }
+
+    const optimisticDoc = { ...doc, original_name: nextName };
+    onDocumentRenamed(optimisticDoc);
+    setRenamingDocId(doc.id);
+
+    try {
+      const updatedDoc = await api.renameDocument<DocInfo>(doc.id, nextName);
+      onDocumentRenamed(updatedDoc);
+      cancelRename();
+      toast.success("Document renamed");
+    } catch (err) {
+      onDocumentRenamed(doc);
+      const message = err instanceof Error ? err.message : "Rename failed";
+      toast.error(message);
+    } finally {
+      setRenamingDocId(null);
+    }
+  };
+
+  const handleRenameKeyDown = (doc: DocInfo, e: React.KeyboardEvent<HTMLInputElement>) => {
+    if (e.key === "Enter") {
+      e.preventDefault();
+      void submitRename(doc);
+    } else if (e.key === "Escape") {
+      e.preventDefault();
+      cancelRename();
+    }
+  };
+
   const handleDocumentKeyDown = (doc: DocInfo, e: React.KeyboardEvent) => {
-    if (doc.status !== "ready") return;
+    if (editingDocId === doc.id || doc.status !== "ready") return;
     if (e.key === "Enter" || e.key === " ") {
       e.preventDefault();
       onSelectDoc(doc);
     }
   };
 
+
   const statusIcon = (status: string) => {
     switch (status) {
       case "ready":
@@ -205,28 +270,49 @@ export default function DocumentSidebar({ documents = [], activeDoc, loading = f
           </div>
         ) : (
           <div className="space-y-1 pb-3">
-            {documents.map((doc) => (
-              <div
-                key={doc.id}
-                role="button"
-                tabIndex={doc.status === "ready" ? 0 : -1}
-                aria-disabled={doc.status !== "ready"}
-                aria-current={activeDoc?.id === doc.id ? "true" : undefined}
-                aria-label={`Select document ${doc.original_name}. Status: ${doc.status}`}
-                onClick={() => doc.status === "ready" && onSelectDoc(doc)}
-                onKeyDown={(e) => handleDocumentKeyDown(doc, e)}
-                className={`w-full text-left p-2.5 rounded-lg transition-all duration-200 group
-                  ${activeDoc?.id === doc.id
-                    ? "bg-primary/15 border border-primary/30"
-                    : "hover:bg-sidebar-accent border border-transparent"}
-                  ${doc.status !== "ready" ? "opacity-60 cursor-default" : "cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2"}`}
-              >
-                <div className="flex items-start gap-2.5">
-                  {statusIcon(doc.status)}
-                  <div className="flex-1 min-w-0">
-                    <p className="text-sm font-medium truncate leading-tight">
-                      {doc.original_name}
-                    </p>
+            {documents.map((doc) => {
+              const isEditing = editingDocId === doc.id;
+              const isRenaming = renamingDocId === doc.id;
+
+              return (
+                <div
+                  key={doc.id}
+                  role="button"
+                  tabIndex={doc.status === "ready" ? 0 : -1}
+                  aria-disabled={doc.status !== "ready"}
+                  aria-current={activeDoc?.id === doc.id ? "true" : undefined}
+                  aria-label={`Select document ${doc.original_name}. Status: ${doc.status}`}
+                  onClick={() => doc.status === "ready" && !isEditing && onSelectDoc(doc)}
+                  onKeyDown={(e) => handleDocumentKeyDown(doc, e)}
+                  className={`w-full text-left p-2.5 rounded-lg transition-all duration-200 group
+                    ${activeDoc?.id === doc.id
+                      ? "bg-primary/15 border border-primary/30"
+                      : "hover:bg-sidebar-accent border border-transparent"}
+                    ${doc.status !== "ready" ? "opacity-60 cursor-default" : "cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2"}`}
+                >
+                  <div className="flex items-start gap-2.5">
+                    {statusIcon(doc.status)}
+                    <div className="flex-1 min-w-0">
+                      {isEditing ? (
+                        <Input
+                          value={draftName}
+                          onChange={(e) => setDraftName(e.target.value)}
+                          onClick={(e) => e.stopPropagation()}
+                          onKeyDown={(e) => handleRenameKeyDown(doc, e)}
+                          disabled={isRenaming}
+                          autoFocus
+                          className="h-7 px-2 text-sm font-medium"
+                        />
+                      ) : (
+                        <p
+                          className="text-sm font-medium truncate leading-tight"
+                          onDoubleClick={(e) => startRename(doc, e)}
+                          title="Double-click to rename"
+                        >
+                          {doc.original_name}
+                        </p>
+                      )}
+
                     <p className="text-xs text-muted-foreground mt-1">
                       {doc.summary || "📄 No summary available"}
                     </p>
@@ -257,8 +343,8 @@ export default function DocumentSidebar({ documents = [], activeDoc, loading = f
                         </Badge>
                       )}
                     </div>
-                  </div>
-                  <div className="flex items-center gap-1 shrink-0"> 
+                    </div>
+                    <div className="flex items-center gap-1 shrink-0">
                     {/* Action buttons (Settings and Delete) are only visible on hover and when the document is ready. The settings button is disabled if the document is not ready, and the delete button shows a loader when the document is being deleted. */} 
                     <Button
                       variant="ghost"
@@ -286,10 +372,13 @@ export default function DocumentSidebar({ documents = [], activeDoc, loading = f
                         <Trash2 className="w-3 h-3 text-destructive" />
                       )}
                     </Button>
+                    </div>
                   </div>
                 </div>
-              </div>
-            ))}
+              );
+            })}
+
+
           </div>
         )}
       </ScrollArea>

frontend/src/lib/api.ts

@@ -228,18 +228,11 @@ class ApiClient {
     return res.json();
   }
 
-  async postForm<T>(path: string, formData: FormData, options?: FetchOptions): Promise<T> {
-    const token = options?.token || this.getToken();
-    const headers: HeadersInit = {};
-    if (token) {
-      headers["Authorization"] = `Bearer ${token}`;
-    }
-    // Don't set Content-Type — browser sets multipart boundary automatically
-
+  async patch<T>(path: string, body?: unknown, options?: FetchOptions): Promise<T> {
     const res = await this.fetchWithConnectionError(`${this.baseUrl}${path}`, {
-      method: "POST",
-      headers,
-      body: formData,
+      method: "PATCH",
+      headers: this.getHeaders(options?.token),
+      body: body ? JSON.stringify(body) : undefined,
       ...options,
     });
 
@@ -247,39 +240,53 @@ class ApiClient {
     if (res.status === 401 && !options?._skipRefresh) {
       const newToken = await this.tryRefreshToken();
       if (newToken) {
-        return this.postForm<T>(path, formData, { ...options, token: newToken, _skipRefresh: true });
+        return this.patch<T>(path, body, { ...options, token: newToken, _skipRefresh: true });
       }
     }
 
     if (!res.ok) {
-      throw new Error(await this.getErrorMessage(res, res.statusText || "Upload failed"));
+      throw new Error(await this.getErrorMessage(res, res.statusText || "Request failed"));
     }
 
     return res.json();
   }
 
-  async patch<T>(path: string, body?: unknown, options?: FetchOptions): Promise<T> {
+  async renameDocument<T>(documentId: string, name: string): Promise<T> {
+    return this.patch<T>(`/api/v1/documents/${documentId}`, { name });
+  }
+
+  async postForm<T>(path: string, formData: FormData, options?: FetchOptions): Promise<T> {
+    const token = options?.token || this.getToken();
+    const headers: HeadersInit = {};
+    if (token) {
+      headers["Authorization"] = `Bearer ${token}`;
+    }
+    // Don't set Content-Type — browser sets multipart boundary automatically
+
     const res = await this.fetchWithConnectionError(`${this.baseUrl}${path}`, {
-      method: "PATCH",
-      headers: this.getHeaders(options?.token),
-      body: body ? JSON.stringify(body) : undefined,
+      method: "POST",
+      headers,
+      body: formData,
       ...options,
     });
 
+    // Auto-refresh on 401
     if (res.status === 401 && !options?._skipRefresh) {
       const newToken = await this.tryRefreshToken();
       if (newToken) {
-        return this.patch<T>(path, body, { ...options, token: newToken, _skipRefresh: true });
+        return this.postForm<T>(path, formData, { ...options, token: newToken, _skipRefresh: true });
       }
     }
 
     if (!res.ok) {
-      throw new Error(await this.getErrorMessage(res, res.statusText || "Request failed"));
+      throw new Error(await this.getErrorMessage(res, res.statusText || "Upload failed"));
     }
 
     return res.json();
   }
 
+
+
   async delete<T>(path: string, options?: FetchOptions): Promise<T> {
     const res = await this.fetchWithConnectionError(`${this.baseUrl}${path}`, {
       method: "DELETE",