Update app.py

app.py

@@ -138,7 +138,8 @@ class AttendanceSystem:
     def _load_local_worker_data(self):
         try:
             if os.path.exists("data/workers.pkl"):
-                with open("data/workers.pkl", "rb") as f: data = pickle.load(f)
+                with open("data/workers.pkl", "rb") as f: 
+                    data = pickle.load(f)
                 self.known_face_embeddings = data.get("embeddings", [])
                 self.known_face_names = data.get("names", [])
                 self.known_face_ids = data.get("ids", [])
@@ -149,8 +150,14 @@ class AttendanceSystem:
 
     def save_local_worker_data(self):
         try:
-            worker_data = {"embeddings": self.known_face_embeddings, "names": self.known_face_names, "ids": self.known_face_ids, "next_id": self.next_worker_id}
-            with open("data/workers.pkl", "wb") as f: pickle.dump(worker_data, f)
+            worker_data = {
+                "embeddings": self.known_face_embeddings, 
+                "names": self.known_face_names, 
+                "ids": self.known_face_ids, 
+                "next_id": self.next_worker_id
+            }
+            with open("data/workers.pkl", "wb") as f: 
+                pickle.dump(worker_data, f)
         except Exception as e:
             logger.error(f"❌ Error saving local worker data: {e}")
     
@@ -235,9 +242,15 @@ class AttendanceSystem:
         caption = self._get_image_caption(face_pil)
         if self.sf:
             try:
-                worker_record = self.sf.Worker__c.create({'Name': name, 'Worker_ID__c': worker_id, 'Face_Embedding__c': json.dumps(embedding), 'Image_Caption__c': caption})
+                worker_record = self.sf.Worker__c.create({
+                    'Name': name, 
+                    'Worker_ID__c': worker_id, 
+                    'Face_Embedding__c': json.dumps(embedding), 
+                    'Image_Caption__c': caption
+                })
                 image_url = self._upload_image_to_salesforce(face_pil, worker_record['id'], worker_id)
-                if image_url: self.sf.Worker__c.update(worker_record['id'], {'Image_URL__c': image_url})
+                if image_url: 
+                    self.sf.Worker__c.update(worker_record['id'], {'Image_URL__c': image_url})
                 logger.info(f"✅ Worker {worker_id} synced to Salesforce.")
             except Exception as e:
                 logger.error(f"❌ Salesforce sync error for {worker_id}: {e}")
@@ -251,9 +264,13 @@ class AttendanceSystem:
         for known_embedding in self.known_face_embeddings:
             # Use euclidean distance as primary method
             euclidean_dist = np.linalg.norm(embedding_array - known_embedding)
-            # Also check cosine similarity for additional validation
-            # If distance is low, consider it duplicate
-            if euclidean_dist < threshold:
+            
+            # Calculate cosine similarity for additional validation
+            dot_product = np.dot(embedding_array, known_embedding)
+            norm_a = np.linalg.norm(embedding_array)
+            norm_b = np.linalg.norm(known_embedding)
+            cosine_sim = dot_product / (norm_a * norm_b) if (norm_a * norm_b) != 0 else 0
+            
             # Consider it duplicate if distance is small OR similarity is very high
             if euclidean_dist < threshold or cosine_sim > 0.85:
                 return True
@@ -377,6 +394,10 @@ class AttendanceSystem:
                 
                 color, worker_id, worker_name = (0, 0, 255), None, "Unknown"
                 
+                # Create a buffer key for this face location
+                buffer_key = f"{x}_{y}_{w}_{h}"
+                current_time = time.time()
+                
                 if self.known_face_embeddings:
                     # Find best match using euclidean distance
                     match_index, match_distance = self._find_best_match(embedding_array)
@@ -387,6 +408,15 @@ class AttendanceSystem:
                     if match_index != -1 and match_distance < 10.0:
                         worker_id = self.known_face_ids[match_index]
                         worker_name = self.known_face_names[match_index]
+                        color = (0, 255, 0)  # Green for recognized
+                        
+                        # Use buffer for consistent detections
+                        if buffer_key not in self.face_recognition_buffer:
+                            self.face_recognition_buffer[buffer_key] = {'count': 1, 'last_time': current_time, 'worker_id': worker_id}
+                        else:
+                            self.face_recognition_buffer[buffer_key]['count'] += 1
+                            self.face_recognition_buffer[buffer_key]['last_time'] = current_time
+                        
                         # Mark attendance after consistent detections
                         if self.face_recognition_buffer[buffer_key]['count'] >= self.buffer_threshold:
                             if self.mark_attendance(worker_id, worker_name):
@@ -407,13 +437,10 @@ class AttendanceSystem:
                             if new_worker:
                                 worker_id, worker_name = new_worker[0], new_worker[1]
                                 color = (0, 255, 0)  # Change to green after successful registration
-                                color = (0, 255, 0)  # Change to green after successful registration
                                 if self.mark_attendance(worker_id, worker_name):
                                     self.last_recognition_time[worker_id] = time.time()
                             else:
                                 print("    -> Auto-registration skipped (duplicate or session limit)")
-                            else:
-                                print("    -> Auto-registration skipped (duplicate or session limit)")
                         else:
                             print("    -> Distance too close to existing faces, skipping auto-registration.")
                 else:
@@ -424,13 +451,10 @@ class AttendanceSystem:
                     if new_worker:
                         worker_id, worker_name = new_worker[0], new_worker[1]
                         color = (0, 255, 0)  # Change to green after successful registration
-                        color = (0, 255, 0)  # Change to green after successful registration
                         if self.mark_attendance(worker_id, worker_name):
                             self.last_recognition_time[worker_id] = time.time()
                     else:
                         print("    -> Auto-registration failed")
-                    else:
-                        print("    -> Auto-registration failed")
                 
                 # Clean old buffer entries
                 current_time = time.time()
@@ -457,9 +481,11 @@ class AttendanceSystem:
             return
         while self.is_processing.is_set():
             ret, frame = video_capture.read()
-            if not ret: break
+            if not ret: 
+                break
             processed_frame = self.process_frame(frame)
-            if not self.frame_queue.full(): self.frame_queue.put(processed_frame)
+            if not self.frame_queue.full(): 
+                self.frame_queue.put(processed_frame)
             self.last_processed_frame = processed_frame # Continuously update last frame
             time.sleep(0.05)
         self.final_log = self.session_log.copy() # Save the final log
@@ -467,7 +493,8 @@ class AttendanceSystem:
         self.is_processing.clear()
 
     def start_processing(self, source) -> str:
-        if self.is_processing.is_set(): return "⚠️ Processing is already active."
+        if self.is_processing.is_set(): 
+            return "⚠️ Processing is already active."
         # Reset states for the new session
         self.session_log.clear()
         self.last_recognition_time.clear()
@@ -495,7 +522,8 @@ class AttendanceSystem:
 
     # --- Helper & Reporting ---
     def _get_image_caption(self, image: Image.Image) -> str:
-        if not HF_API_TOKEN: return "Hugging Face API token not configured."
+        if not HF_API_TOKEN: 
+            return "Hugging Face API token not configured."
         try:
             buffered = BytesIO()
             image.save(buffered, format="JPEG")
@@ -510,27 +538,37 @@ class AttendanceSystem:
             return "Caption generation failed."
 
     def _upload_image_to_salesforce(self, image: Image.Image, record_id: str, worker_id: str) -> Optional[str]:
-        if not self.sf: return None
+        if not self.sf: 
+            return None
         try:
             buffered = BytesIO()
             image.save(buffered, format="JPEG")
             encoded_image = base64.b64encode(buffered.getvalue()).decode('utf-8')
-            cv = self.sf.ContentVersion.create({'Title': f'Image_{worker_id}', 'PathOnClient': f'{worker_id}.jpg', 'VersionData': encoded_image, 'FirstPublishLocationId': record_id})
+            cv = self.sf.ContentVersion.create({
+                'Title': f'Image_{worker_id}', 
+                'PathOnClient': f'{worker_id}.jpg', 
+                'VersionData': encoded_image, 
+                'FirstPublishLocationId': record_id
+            })
             return f"/{cv['id']}" # Relative URL
         except Exception as e:
             logger.error(f"Salesforce image upload error: {e}")
             return None
 
     def get_registered_workers_info(self) -> str:
-        if not self.sf: return "❌ Salesforce not connected."
+        if not self.sf: 
+            return "❌ Salesforce not connected."
         try:
             records = self.sf.query_all("SELECT Name, Worker_ID__c FROM Worker__c ORDER BY Name")['records']
-            if not records: return "No workers registered."
+            if not records: 
+                return "No workers registered."
             return f"**👥 Registered Workers ({len(records)})**\n" + "\n".join([f"- **{w['Name']}** (ID: {w['Worker_ID__c']})" for w in records])
-        except Exception as e: return f"Error: {e}"
+        except Exception as e: 
+            return f"Error: {e}"
         
 # --- GRADIO UI ---
 attendance_system = AttendanceSystem()
+
 def create_interface():
     with gr.Blocks(theme=gr.themes.Soft(), title="Attendance System") as demo:
         gr.Markdown("# 🎯 Advanced Face Recognition Attendance System")
@@ -571,11 +609,15 @@ def create_interface():
                         refresh_workers_btn = gr.Button("🔄 Refresh List")
 
         # --- Event Handlers ---
-        def on_tab_select(evt: gr.SelectData): return evt.index
+        def on_tab_select(evt: gr.SelectData): 
+            return evt.index
+        
         video_tabs.select(fn=on_tab_select, inputs=None, outputs=[selected_tab_index])
+        
         def start_wrapper(tab_index, cam_src, vid_path):
             source = cam_src if tab_index == 0 else vid_path
             return "Please provide an input source." if source is None else attendance_system.start_processing(source)
+        
         start_btn.click(fn=start_wrapper, inputs=[selected_tab_index, camera_source, video_file], outputs=[status_box])
         stop_btn.click(fn=attendance_system.stop_processing, inputs=None, outputs=[status_box])
         register_btn.click(fn=attendance_system.register_worker_manual, inputs=[register_image, register_name], outputs=[register_output, registered_workers_info])
@@ -585,15 +627,18 @@ def create_interface():
             while True:
                 if attendance_system.error_message:
                     yield None, attendance_system.error_message
-                    time.sleep(2); attendance_system.error_message = None
+                    time.sleep(2)
+                    attendance_system.error_message = None
                     continue
                 if attendance_system.is_processing.is_set():
                     frame, log_md = None, "\n".join(reversed(attendance_system.session_log)) or "Processing..."
                     try:
                         if not attendance_system.frame_queue.empty():
                             frame = attendance_system.frame_queue.get_nowait()
-                            if frame is not None: frame = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB)
-                    except queue.Empty: pass
+                            if frame is not None: 
+                                frame = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB)
+                    except queue.Empty: 
+                        pass
                     yield frame, log_md
                 else:
                     if attendance_system.last_processed_frame is not None: