Update tests/test_violation_log.py

tests/test_violation_log.py

@@ -1,47 +1,51 @@
 import pytest
 import os
-import tempfile
 import json
-from unittest.mock import patch
-import sys
+from app import save_snapshot, log_violation
 import numpy as np
 import cv2
+import tempfile
 
-# Add the parent directory to the path to import app
-sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+def test_save_snapshot():
+    """Test snapshot saving functionality"""
+    # Create a test frame
+    frame = np.zeros((640, 640, 3), dtype=np.uint8)
+    snapshot_path = save_snapshot(frame)
+    
+    assert os.path.exists(snapshot_path), "Snapshot file should exist"
+    assert snapshot_path.endswith('.jpg'), "Snapshot should be a JPG file"
+    
+    # Clean up
+    if os.path.exists(snapshot_path):
+        os.remove(snapshot_path)
 
 def test_log_violation():
     """Test violation logging functionality"""
-    # Create a temporary directory for testing
-    with tempfile.TemporaryDirectory() as temp_dir:
-        # Mock the log file path
-        log_file_path = os.path.join(temp_dir, "violation_logs.json")
-        
-        # Create a test frame
-        frame = np.zeros((640, 640, 3), dtype=np.uint8)
-        
-        # Create test violation data
-        violation_data = {
-            'site_id': "SITE001",
-            'camera_id': "CAM001",
-            'violation_type': "No Helmet",
-            'timestamp': "2025-01-01T12:00:00+05:30",
-            'snapshot_url': "/tmp/snapshots/test_snapshot.jpg",
-            'severity': "Critical"
-        }
-        
-        # Test logging
-        with patch('pathlib.Path') as mock_path:
-            mock_path.return_value.exists.return_value = False
-            # Since we can't easily import and test the actual function,
-            # we'll test the concept by writing directly
-            with open(log_file_path, 'w') as f:
-                json.dump([violation_data], f)
-            
-            assert os.path.exists(log_file_path), "Violation logs file not found"
-            
-            # Verify content
-            with open(log_file_path, 'r') as f:
-                logs = json.load(f)
-                assert len(logs) == 1
-                assert logs[0]['violation_type'] == "No Helmet"
+    frame = np.zeros((640, 640, 3), dtype=np.uint8)
+    snapshot_path = save_snapshot(frame)
+    
+    violation_data = {
+        'site_id': "Site1",
+        'camera_id': "Camera1",
+        'violation_type': "No Helmet",
+        'timestamp': "2025-06-07T09:23:00Z",
+        'snapshot_url': snapshot_path,
+        'severity': "Critical"
+    }
+    
+    log_violation(violation_data)
+    
+    # Check if log file exists
+    log_file = "/tmp/snapshots/violation_logs.json"
+    assert os.path.exists(log_file), "Violation logs file should exist"
+    
+    # Check if violation was logged
+    with open(log_file, 'r') as f:
+        logs = json.load(f)
+    
+    assert len(logs) > 0, "At least one violation should be logged"
+    assert logs[-1]['violation_type'] == "No Helmet", "Latest violation should match"
+    
+    # Clean up
+    if os.path.exists(snapshot_path):
+        os.remove(snapshot_path)