fixing samples

app.py

@@ -359,6 +359,12 @@ button.theme-toggle[data-mode="light"] .theme-icon-moon { display: block !import
     color: var(--pruna-tab-selected) !important;
     background: transparent !important;
 }
+.main-tabs .tab-container > button:disabled,
+.main-tabs .tab-container > button[disabled] {
+    opacity: 0.4 !important;
+    color: var(--pruna-text-muted) !important;
+    cursor: not-allowed !important;
+}
 .main-tabs .tab-container > button.selected::after,
 .main-tabs .tab-container > button[aria-selected="true"]::after {
     background: var(--pruna-accent-bright) !important;
@@ -1478,6 +1484,11 @@ button.theme-toggle[data-mode="light"] .theme-icon-moon { display: block !import
     max-width: 100% !important;
     min-width: 0 !important;
     overflow-x: hidden !important;
+    border: none !important;
+    background: transparent !important;
+    box-shadow: none !important;
+    padding: 0 !important;
+    margin: 0 !important;
 }
 .compare-row { display: grid; gap: 12px; min-width: 0; width: 100%; }
 .compare-prompt-text { overflow-wrap: anywhere; }
@@ -1514,12 +1525,17 @@ button.theme-toggle[data-mode="light"] .theme-icon-moon { display: block !import
     border: 1px solid var(--pruna-border);
     background: var(--pruna-bg-elevated);
 }
-.compare-empty {
-    padding: 18px;
-    border: 1px dashed color-mix(in oklab, var(--pruna-border) 60%, transparent);
-    border-radius: 12px;
+.compare-empty,
+.pareto-note-copy {
+    margin: 0;
+    padding: 14px 16px;
+    background: var(--pruna-callout-bg, var(--pruna-bg-card));
+    border: 1px dashed color-mix(in oklab, var(--pruna-border) 70%, transparent);
+    border-radius: 10px;
     color: var(--pruna-text-muted);
-    text-align: center;
+    font-size: 0.95rem;
+    line-height: 1.5;
+    text-align: left;
 }
 
 /*
@@ -1694,16 +1710,6 @@ footer, .footer { display: none !important; }
     padding: 0 !important;
     margin: 0 0 12px !important;
 }
-.pareto-note-copy {
-    margin: 0;
-    padding: 14px 16px;
-    background: var(--pruna-callout-bg, var(--pruna-bg-card));
-    border: 1px dashed color-mix(in oklab, var(--pruna-border) 70%, transparent);
-    border-radius: 10px;
-    color: var(--pruna-text-muted);
-    font-size: 0.95rem;
-    line-height: 1.5;
-}
 .pareto-metric-block {
     padding-bottom: 0.5rem;
     border-bottom: 1px solid var(--pruna-hairline);

ui.py

@@ -208,15 +208,15 @@ def _dataset_choices(datasets, *, require_samples=False):
     ]
 
 
-def _coerce_sample_dataset(datasets, dataset_id):
-    """Prefer datasets that have compare-sample artifacts."""
+def _dataset_has_samples(datasets, dataset_id):
     dataset = _item(datasets, dataset_id)
-    if dataset and dataset.get("samples"):
-        return dataset["id"]
-    for candidate in datasets:
-        if candidate.get("samples"):
-            return candidate["id"]
-    return dataset_id
+    return bool(dataset and dataset.get("samples"))
+
+
+def _dataset_has_pareto(datasets, dataset_id):
+    dataset = _item(datasets, dataset_id)
+    columns = getattr(dataset.get("data") if dataset else None, "columns", [])
+    return _PARETO_PRICE_COLUMN in columns or _PARETO_TIME_COLUMN in columns
 
 
 ALL_METRICS_ID = "__all__"
@@ -857,21 +857,11 @@ def _pareto_pair(data, score_column):
 def _pareto_dataset_message(data):
     has_price = data is not None and _PARETO_PRICE_COLUMN in data.columns
     has_time = data is not None and _PARETO_TIME_COLUMN in data.columns
-    if has_price and has_time:
+    if has_price or has_time:
         return None
-    if not has_price and not has_time:
-        return (
-            "Price per image and min generation time aren't available for "
-            "this dataset, so these plots can't be drawn."
-        )
-    if not has_price:
-        return (
-            "Price per image isn't available for this dataset, so only min "
-            "generation time vs score is shown."
-        )
     return (
-        "Min generation time isn't available for this dataset, so only "
-        "price vs score is shown."
+        "Price per image and min generation time aren't available for "
+        "this dataset, so these plots can't be drawn."
     )
 
 
@@ -879,6 +869,16 @@ def _pareto_slot_note(price_fig, price_message, time_fig, time_message, data):
     has_price = data is not None and _PARETO_PRICE_COLUMN in data.columns
     has_time = data is not None and _PARETO_TIME_COLUMN in data.columns
     notes = []
+    if has_price and not has_time:
+        notes.append(
+            "Min generation time isn't available for this dataset, so only "
+            "price vs score is shown."
+        )
+    elif has_time and not has_price:
+        notes.append(
+            "Price per image isn't available for this dataset, so only min "
+            "generation time vs score is shown."
+        )
     if price_fig is None and has_price:
         notes.append(price_message)
     if time_fig is None and has_time:
@@ -941,7 +941,9 @@ def _pareto_slot_updates(data, score_columns):
 
 def _samples_html(samples, selected_models, num_prompts, seed=0):
     if not samples:
-        return ""
+        return _pareto_unavailable_html(
+            "Samples aren't available for this dataset."
+        )
     models = list(selected_models or [])
     available = samples.get("models") or []
     models = [model for model in models if model in samples.get("images", {})]
@@ -1100,13 +1102,7 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
     initial_data = initial["data"]
     initial_columns = initial["columns"]
     initial_score_columns = initial["score_columns"]
-    sample_dataset_id = _coerce_sample_dataset(datasets, default_dataset_id)
-    if sample_dataset_id == default_dataset_id:
-        initial_samples = initial.get("samples")
-    else:
-        initial_samples = resolve_view(
-            datasets, metrics, sample_dataset_id, None
-        ).get("samples")
+    initial_samples = initial.get("samples")
     with gr.Column(elem_classes="workspace-shell"):
         with gr.Column(elem_classes="workspace-filters") as filters_host:
             gr.Markdown(
@@ -1119,7 +1115,7 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
             dataset_dd, metric_dd, models_dd = _filter_row(
                 datasets, metrics, default_dataset_id, None
             )
-        with gr.Tabs(elem_classes="main-tabs"):
+        with gr.Tabs(elem_classes="main-tabs") as main_tabs:
             with gr.TabItem("Leaderboards", id=TAB_LEADERBOARDS) as lb_tab:
                 lb_note = gr.Markdown(
                     _leaderboard_intro_markdown(initial.get("note")),
@@ -1178,7 +1174,11 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
                     elem_classes="ranking-table-host",
                 )
 
-            with gr.TabItem("Pareto Plots", id=TAB_PARETO) as pp_tab:
+            with gr.TabItem(
+                "Pareto Plots",
+                id=TAB_PARETO,
+                interactive=_dataset_has_pareto(datasets, default_dataset_id),
+            ) as pp_tab:
                 gr.Markdown(
                     "<p class='view-help'>"
                     "Score against price and generation time. Green points are on the "
@@ -1203,12 +1203,6 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
                             "",
                             elem_classes="pareto-metric-title",
                         )
-                        slot_note = gr.HTML(
-                            "",
-                            padding=False,
-                            visible=False,
-                            elem_classes="pareto-note",
-                        )
                         with gr.Row(
                             equal_height=True,
                             elem_classes="pareto-layout",
@@ -1241,6 +1235,12 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
                                     show_label=False,
                                     elem_classes="pareto-plot",
                                 )
+                        slot_note = gr.HTML(
+                            "",
+                            padding=False,
+                            visible=False,
+                            elem_classes="pareto-note",
+                        )
                     pareto_slots.append(
                         (
                             slot_group,
@@ -1254,7 +1254,11 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
                         )
                     )
 
-            with gr.TabItem("Samples", id=TAB_SAMPLES) as sm_tab:
+            with gr.TabItem(
+                "Samples",
+                id=TAB_SAMPLES,
+                interactive=_dataset_has_samples(datasets, default_dataset_id),
+            ) as sm_tab:
                 with gr.Column(visible=bool(initial_samples)) as samples_panel:
                     gr.Markdown(
                         f"<p class='view-help'>"
@@ -1472,18 +1476,10 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
         else:
             pareto_updates = _pareto_skip_updates()
         if include_samples:
-            sample_dataset_id = _coerce_sample_dataset(datasets, dataset_id)
-            sample_view = resolve_view(datasets, metrics, sample_dataset_id, None)
-            samples = sample_view.get("samples") if sample_view else None
-            sample_models = [
-                model
-                for model in (models or [])
-                if model
-                in _model_choice_values(_model_choices(datasets, sample_dataset_id))
-            ]
+            samples = view.get("samples")
             samples_html = _samples_html(
                 samples,
-                sample_models,
+                models,
                 int(num_prompts or DEFAULT_COMPARE_PROMPTS),
                 int(seed or 0),
             )
@@ -1526,7 +1522,14 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
             == _selection_key(dataset_id, metric_id, models)
         ):
             return _skip_all(len(dataset_outputs))
-        flags = _content_flags(tab)
+        can_pareto = _dataset_has_pareto(datasets, dataset_id)
+        can_samples = _dataset_has_samples(datasets, dataset_id)
+        selected_tab = tab
+        if tab == TAB_SAMPLES and not can_samples:
+            selected_tab = TAB_LEADERBOARDS
+        elif tab == TAB_PARETO and not can_pareto:
+            selected_tab = TAB_LEADERBOARDS
+        flags = _content_flags(selected_tab)
         view = resolve_view(datasets, metrics, dataset_id, metric_id)
         extras = _leaderboard_extras(
             view["data"], platform_value, owner_value, optimized_value
@@ -1548,7 +1551,7 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
                 "owner": extras[4],
                 "optimized": extras[5],
             }
-            if tab == TAB_LEADERBOARDS
+            if selected_tab == TAB_LEADERBOARDS
             else {}
         )
         new_state = _commit_state(
@@ -1556,7 +1559,7 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
             dataset_id,
             metric_id,
             models,
-            tab,
+            selected_tab,
             flags,
             extras=extras_payload,
         )
@@ -1568,6 +1571,11 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
             extras[1],
             extras[2],
             *views,
+            gr.update(interactive=can_pareto),
+            gr.update(interactive=can_samples),
+            gr.update(selected=selected_tab)
+            if selected_tab != tab
+            else gr.skip(),
             new_state,
         )
 
@@ -1808,7 +1816,6 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
         )
 
     def on_samples_controls(dataset_id, models, num_prompts, seed):
-        dataset_id = _coerce_sample_dataset(datasets, dataset_id)
         view = resolve_view(datasets, metrics, dataset_id, None)
         return _samples_html(
             view.get("samples") if view else None,
@@ -1818,7 +1825,6 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
         )
 
     def on_shuffle(dataset_id, models, num_prompts, seed):
-        dataset_id = _coerce_sample_dataset(datasets, dataset_id)
         next_seed = int(seed or 0) + 1
         view = resolve_view(datasets, metrics, dataset_id, None)
         return next_seed, _samples_html(
@@ -1914,6 +1920,9 @@ def render_image_workspace(datasets, metrics, default_dataset_id, default_metric
         owner,
         optimized,
         *view_outputs,
+        pp_tab,
+        sm_tab,
+        main_tabs,
         view_state,
     ]
     dataset_dd.change(