Upload app.py

app.py

@@ -508,7 +508,8 @@ def _empty_ws(msg=""):
             None, False, None,
             "", None, gr.Column(visible=False), None,
             None,
-            "", None, "", None, gr.Column(visible=False), None)
+            "", None, "", None, gr.Column(visible=False), None,
+            gr.Column(visible=True), gr.Column(visible=True))
 
 
 def fetch_next(username):
@@ -568,6 +569,9 @@ def fetch_next(username):
         show_flip_single = flip_reg is not None and overlap and show_fit
         show_flip_dual = (not overlap) and show_fit and (
             flip_reg is not None or flip_ai is not None)
+        # Fit-specific flip sub-section visibility (initial load: both visible)
+        show_flip_reg_sub = True
+        show_flip_ai_sub = True
 
         # Single flip info
         flip_info = ""
@@ -602,7 +606,9 @@ def fetch_next(username):
                 flip_reg if overlap else None,
                 exp_data,
                 flip_reg_info, None, flip_ai_info, None,
-                gr.Column(visible=show_flip_dual), dual_state)
+                gr.Column(visible=show_flip_dual), dual_state,
+                gr.Column(visible=show_flip_reg_sub),
+                gr.Column(visible=show_flip_ai_sub))
     except Exception as e:
         print(f"fetch_next render error: {e}\n{traceback.format_exc()}")
         return _empty_ws(f"❌ Render failed: {e}")
@@ -756,21 +762,24 @@ def update_workspace_state(data_val, fit_s_val, fit_reg_val, fit_ai_val,
     """Centralized state recalculation. Called when user changes any rating.
     Recomputes flip points, redraws plot, recalculates all visibility.
 
-    Visibility rule:
-      - Explicit "Bad (0)" → hide fit + flip sections
-      - None (cleared) or Borderline/Perfect → show fit + flip sections
+    Visibility rules:
+      - Explicit "Bad (0)" on DATA → hide ALL fit + flip sections
+      - Explicit "Bad (0)" on a FIT → hide only THAT fit's flip section
+      - None (cleared) or Borderline/Perfect → show sections
     Flip-point gating:
-      - Uses effective data quality (user > model) for computation
+      - Uses effective quality (user > model) for computation
 
-    Outputs 13 items: (plot, fs_col, fd_col,
+    Outputs 15 items: (plot, fs_col, fd_col,
       flip_info, flip_tag, flip_col, flip_state,
       flip_reg_info, flip_reg_tag, flip_ai_info, flip_ai_tag,
-      flip_dual_col, flip_dual_state)
+      flip_dual_col, flip_dual_state,
+      flip_reg_sub, flip_ai_sub)
     """
     _empty = (None,
               gr.Column(visible=True), gr.Column(visible=False),
               "", None, gr.Column(visible=False), None,
-              "", None, "", None, gr.Column(visible=False), None)
+              "", None, "", None, gr.Column(visible=False), None,
+              gr.Column(visible=True), gr.Column(visible=True))
     if exp_data is None:
         return _empty
 
@@ -781,9 +790,14 @@ def update_workspace_state(data_val, fit_s_val, fit_reg_val, fit_ai_val,
     mc = (model_preds or {}).get('model_classes', {})
 
     # ── UI VISIBILITY: only explicit "Bad" hides sections ──
-    # None (cleared) always shows → lets user see everything and decide
     ui_show = data_val != 'Bad (0)'
 
+    # ── Fit-specific UI visibility for flip sections ──
+    # Explicit "Bad" on a fit hides only THAT fit's flip section
+    fit_s_ui_ok = fit_s_val != 'Bad (0)'
+    fit_reg_ui_ok = fit_reg_val != 'Bad (0)'
+    fit_ai_ui_ok = fit_ai_val != 'Bad (0)'
+
     # ── FLIP-POINT GATING: uses effective quality for computation ──
     if data_val is not None:
         eff_data = RATING_MAP.get(data_val, -1)
@@ -813,12 +827,18 @@ def update_workspace_state(data_val, fit_s_val, fit_reg_val, fit_ai_val,
     fig = create_plot(raw_data, fname, reg_params, ai_params, overlap,
                       flip_reg=flip_reg, flip_ai=flip_ai)
 
-    # ── Section visibility (ui_show controls all downstream sections) ──
+    # ── Section visibility ──
     show_fit_single = overlap and ui_show
     show_fit_dual = (not overlap) and ui_show
-    show_flip_single = flip_reg is not None and overlap and ui_show
-    show_flip_dual = (not overlap) and ui_show and (
-        flip_reg is not None or flip_ai is not None)
+
+    # Single flip: visible only if data OK AND fit not Bad
+    show_flip_single = (flip_reg is not None and overlap
+                        and ui_show and fit_s_ui_ok)
+
+    # Dual flip: outer container visible if at least one sub-section is active
+    show_flip_reg_sub = (flip_reg is not None and ui_show and fit_reg_ui_ok)
+    show_flip_ai_sub = (flip_ai is not None and ui_show and fit_ai_ui_ok)
+    show_flip_dual = (not overlap) and (show_flip_reg_sub or show_flip_ai_sub)
 
     # ── Info strings ──
     flip_info = ""
@@ -830,13 +850,13 @@ def update_workspace_state(data_val, fit_s_val, fit_reg_val, fit_ai_val,
     flip_reg_info = ""
     flip_ai_info = ""
     if not overlap and ui_show:
-        if flip_reg:
+        if flip_reg and fit_reg_ui_ok:
             flip_reg_info = f"Reg Flip: x = {flip_reg['x']:.5f}, y = {flip_reg['y']:.4f} ({flip_reg['type']})"
-        elif data_gate and fit_gate:
+        elif data_gate and fit_gate and fit_reg_ui_ok:
             flip_reg_info = "No flip point detected."
-        if flip_ai:
+        if flip_ai and fit_ai_ui_ok:
             flip_ai_info = f"AI Flip: x = {flip_ai['x']:.5f}, y = {flip_ai['y']:.4f} ({flip_ai['type']})"
-        elif data_gate and ai_fit_gate:
+        elif data_gate and ai_fit_gate and fit_ai_ui_ok:
             flip_ai_info = "No flip point detected."
 
     dual_state = {'reg': flip_reg, 'ai': flip_ai} if not overlap else None
@@ -849,7 +869,9 @@ def update_workspace_state(data_val, fit_s_val, fit_reg_val, fit_ai_val,
             flip_reg if overlap else None,
             flip_reg_info, None, flip_ai_info, None,
             gr.Column(visible=show_flip_dual),
-            dual_state)
+            dual_state,
+            gr.Column(visible=show_flip_reg_sub),
+            gr.Column(visible=show_flip_ai_sub))
 
 
 # ═════════════════════════════════════════════════════════════════════════
@@ -1228,7 +1250,7 @@ def build_ui():
                 with gr.Column(visible=False) as ws_flip_dual_col:
                     gr.Markdown("### 🎯 Flip-Point Detection (Diverging Fits)")
                     with gr.Row():
-                        with gr.Column():
+                        with gr.Column(visible=True) as ws_flip_reg_sub:
                             gr.Markdown("#### 🟦 Regular Fit Flip")
                             ws_flip_reg_info = gr.Textbox(
                                 label="Regular Flip", interactive=False, lines=1)
@@ -1236,7 +1258,7 @@ def build_ui():
                                 choices=["✅ Correct", "❌ Wrong"], value=None,
                                 label="Regular flip correct?",
                                 elem_classes=["rating-radio"])
-                        with gr.Column():
+                        with gr.Column(visible=True) as ws_flip_ai_sub:
                             gr.Markdown("#### 🟩 AI Fit Flip")
                             ws_flip_ai_info = gr.Textbox(
                                 label="AI Flip", interactive=False, lines=1)
@@ -1258,7 +1280,8 @@ def build_ui():
                      ws_flip_info, ws_flip_tag, ws_flip_col, ws_flip_state,
                      ws_flip_reg_info, ws_flip_reg_tag,
                      ws_flip_ai_info, ws_flip_ai_tag,
-                     ws_flip_dual_col, ws_flip_dual_state])
+                     ws_flip_dual_col, ws_flip_dual_state,
+                     ws_flip_reg_sub, ws_flip_ai_sub])
 
                 # Centralized state recalculation on any rating change
                 _state_inputs = [ws_dr, ws_fs, ws_fr, ws_fa,
@@ -1267,13 +1290,14 @@ def build_ui():
                                   ws_flip_info, ws_flip_tag, ws_flip_col, ws_flip_state,
                                   ws_flip_reg_info, ws_flip_reg_tag,
                                   ws_flip_ai_info, ws_flip_ai_tag,
-                                  ws_flip_dual_col, ws_flip_dual_state]
+                                  ws_flip_dual_col, ws_flip_dual_state,
+                                  ws_flip_reg_sub, ws_flip_ai_sub]
                 ws_dr.input(update_workspace_state, _state_inputs, _state_outputs)
                 ws_fs.input(update_workspace_state, _state_inputs, _state_outputs)
                 ws_fr.input(update_workspace_state, _state_inputs, _state_outputs)
                 ws_fa.input(update_workspace_state, _state_inputs, _state_outputs)
 
-                # Output list — 29 components
+                # Output list — 31 components
                 ws_outs = [ws_status, ws_plot, ws_info, ws_ov_msg, ws_conf,
                            ws_fs_col, ws_fd_col,
                            ws_dr, ws_fs, ws_fr, ws_fa,
@@ -1283,7 +1307,8 @@ def build_ui():
                            ws_exp_data,
                            ws_flip_reg_info, ws_flip_reg_tag,
                            ws_flip_ai_info, ws_flip_ai_tag,
-                           ws_flip_dual_col, ws_flip_dual_state]
+                           ws_flip_dual_col, ws_flip_dual_state,
+                           ws_flip_reg_sub, ws_flip_ai_sub]
 
                 ws_fetch.click(fetch_next, [ws_user], ws_outs)
                 ws_submit.click(submit_feedback,