Update app.py

app.py

@@ -94,7 +94,6 @@ with st.sidebar.expander("Moving Average Parameters", expanded=False):
     ma_short_period = st.number_input('Short-term Moving Average Period', min_value=1, value=20, help="Set the period for the short-term moving average.")
     ma_long_period = st.number_input('Long-term Moving Average Period', min_value=1, value=50, help="Set the period for the long-term moving average.")
 
-
 # Place the Run Analysis button above the candlestick pattern checkboxes
 if st.sidebar.button('Run Analysis'):
     run_analysis = True
@@ -106,23 +105,30 @@ with st.sidebar.expander("Candlestick Patterns", expanded=True):
     selected_patterns = {name: st.checkbox(name, value=True) for name, func in pattern_funcs}
 
 if run_analysis:
-    data = yf.download(symbol, start=start_date, end=end_date)
-    
+    # Fetch data with yfinance adjustments
+    data = yf.download(symbol, start=start_date, end=end_date, auto_adjust=False)
+    if isinstance(data.columns, pd.MultiIndex):
+        data.columns = data.columns.get_level_values(0)
+
     if not data.empty:
-        # Calculate moving averages based on user input
+        # Calculate moving averages based on user input with NaN handling
         data[f'MA{ma_short_period}'] = talib.SMA(data['Close'], timeperiod=ma_short_period)
         data[f'MA{ma_long_period}'] = talib.SMA(data['Close'], timeperiod=ma_long_period)
         
         for pattern_name, pattern_func in pattern_funcs:
             if selected_patterns[pattern_name]:
+                # Calculate pattern with TALib and handle potential NaNs
                 data[pattern_name] = pattern_func(data['Open'], data['High'], data['Low'], data['Close'])
-                pattern_dates = data[data[pattern_name] != 0].index
+                pattern_dates = data[data[pattern_name].notna() & (data[pattern_name] != 0)].index
 
                 if len(pattern_dates) == 0:
+                    st.write(f"No {pattern_name} patterns detected for {symbol} in the selected date range.")
                     continue
 
+                # Create Plotly figure
                 fig = go.Figure()
                 
+                # Candlestick chart
                 fig.add_trace(go.Candlestick(
                     x=data.index,
                     open=data['Open'],
@@ -133,6 +139,7 @@ if run_analysis:
                     yaxis='y2'
                 ))
 
+                # Short-term moving average
                 fig.add_trace(go.Scatter(
                     x=data.index,
                     y=data[f'MA{ma_short_period}'],
@@ -142,6 +149,7 @@ if run_analysis:
                     yaxis='y2'
                 ))
 
+                # Long-term moving average
                 fig.add_trace(go.Scatter(
                     x=data.index,
                     y=data[f'MA{ma_long_period}'],
@@ -151,6 +159,7 @@ if run_analysis:
                     yaxis='y2'
                 ))
 
+                # Volume bars
                 fig.add_trace(go.Bar(
                     x=data.index,
                     y=data['Volume'],
@@ -160,9 +169,11 @@ if run_analysis:
                     opacity=0.5
                 ))
 
+                # Add vertical lines for pattern detection
                 for date in pattern_dates:
                     fig.add_vline(x=date, line=dict(color='red', width=2, dash='dash'), name=pattern_name)
 
+                # Update layout
                 fig.update_layout(
                     title=f"{symbol} Price and {pattern_name} Pattern Detection",
                     xaxis_title="Date",
@@ -170,12 +181,13 @@ if run_analysis:
                     yaxis2=dict(title='Price', overlaying='y', side='right'),
                     legend_title="Legend",
                     xaxis_rangeslider_visible=False,
-                    template='plotly_white'
+                    template='plotly_white',
+                    height=600
                 )
                 
-                st.plotly_chart(fig)
+                st.plotly_chart(fig, use_container_width=True)
     else:
-        st.write("No data found for the given ticker and date range.")
+        st.error(f"No data found for {symbol} in the given date range ({start_date} to {end_date}).")
 
 # Hide the Streamlit style
 hide_streamlit_style = """
@@ -184,4 +196,4 @@ hide_streamlit_style = """
 footer {visibility: hidden;}
 </style>
 """
-st.markdown(hide_streamlit_style, unsafe_allow_html=True)
+st.markdown(hide_streamlit_style, unsafe_allow_html=True)