File size: 4,990 Bytes
b5b9c2e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 | """Tests for model_tools.py — function call dispatch, agent-loop interception, legacy toolsets."""
import json
from unittest.mock import call, patch
import pytest
from model_tools import (
handle_function_call,
get_all_tool_names,
get_toolset_for_tool,
_AGENT_LOOP_TOOLS,
_LEGACY_TOOLSET_MAP,
TOOL_TO_TOOLSET_MAP,
)
# =========================================================================
# handle_function_call
# =========================================================================
class TestHandleFunctionCall:
def test_agent_loop_tool_returns_error(self):
for tool_name in _AGENT_LOOP_TOOLS:
result = json.loads(handle_function_call(tool_name, {}))
assert "error" in result
assert "agent loop" in result["error"].lower()
def test_unknown_tool_returns_error(self):
result = json.loads(handle_function_call("totally_fake_tool_xyz", {}))
assert "error" in result
assert "totally_fake_tool_xyz" in result["error"]
def test_exception_returns_json_error(self):
# Even if something goes wrong, should return valid JSON
result = handle_function_call("web_search", None) # None args may cause issues
parsed = json.loads(result)
assert isinstance(parsed, dict)
assert "error" in parsed
assert len(parsed["error"]) > 0
assert "error" in parsed["error"].lower() or "failed" in parsed["error"].lower()
def test_tool_hooks_receive_session_and_tool_call_ids(self):
with (
patch("model_tools.registry.dispatch", return_value='{"ok":true}'),
patch("hermes_cli.plugins.invoke_hook") as mock_invoke_hook,
):
result = handle_function_call(
"web_search",
{"q": "test"},
task_id="task-1",
tool_call_id="call-1",
session_id="session-1",
)
assert result == '{"ok":true}'
assert mock_invoke_hook.call_args_list == [
call(
"pre_tool_call",
tool_name="web_search",
args={"q": "test"},
task_id="task-1",
session_id="session-1",
tool_call_id="call-1",
),
call(
"post_tool_call",
tool_name="web_search",
args={"q": "test"},
result='{"ok":true}',
task_id="task-1",
session_id="session-1",
tool_call_id="call-1",
),
]
# =========================================================================
# Agent loop tools
# =========================================================================
class TestAgentLoopTools:
def test_expected_tools_in_set(self):
assert "todo" in _AGENT_LOOP_TOOLS
assert "memory" in _AGENT_LOOP_TOOLS
assert "session_search" in _AGENT_LOOP_TOOLS
assert "delegate_task" in _AGENT_LOOP_TOOLS
def test_no_regular_tools_in_set(self):
assert "web_search" not in _AGENT_LOOP_TOOLS
assert "terminal" not in _AGENT_LOOP_TOOLS
# =========================================================================
# Legacy toolset map
# =========================================================================
class TestLegacyToolsetMap:
def test_expected_legacy_names(self):
expected = [
"web_tools", "terminal_tools", "vision_tools", "moa_tools",
"image_tools", "skills_tools", "browser_tools", "cronjob_tools",
"rl_tools", "file_tools", "tts_tools",
]
for name in expected:
assert name in _LEGACY_TOOLSET_MAP, f"Missing legacy toolset: {name}"
def test_values_are_lists_of_strings(self):
for name, tools in _LEGACY_TOOLSET_MAP.items():
assert isinstance(tools, list), f"{name} is not a list"
for tool in tools:
assert isinstance(tool, str), f"{name} contains non-string: {tool}"
# =========================================================================
# Backward-compat wrappers
# =========================================================================
class TestBackwardCompat:
def test_get_all_tool_names_returns_list(self):
names = get_all_tool_names()
assert isinstance(names, list)
assert len(names) > 0
# Should contain well-known tools
assert "web_search" in names
assert "terminal" in names
def test_get_toolset_for_tool(self):
result = get_toolset_for_tool("web_search")
assert result is not None
assert isinstance(result, str)
def test_get_toolset_for_unknown_tool(self):
result = get_toolset_for_tool("totally_nonexistent_tool")
assert result is None
def test_tool_to_toolset_map(self):
assert isinstance(TOOL_TO_TOOLSET_MAP, dict)
assert len(TOOL_TO_TOOLSET_MAP) > 0
|