File size: 4,711 Bytes
b5b9c2e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 | """Tests for config.get() null-coalescing in tool configuration.
YAML ``null`` values (or ``~``) for a present key make ``dict.get(key, default)``
return ``None`` instead of the default — calling ``.lower()`` on that raises
``AttributeError``. These tests verify the ``or`` coalescing guards.
"""
from unittest.mock import patch
import pytest
# ── TTS tool ──────────────────────────────────────────────────────────────
class TestTTSProviderNullGuard:
"""tools/tts_tool.py — _get_provider()"""
def test_explicit_null_provider_returns_default(self):
"""YAML ``tts: {provider: null}`` should fall back to default."""
from tools.tts_tool import _get_provider, DEFAULT_PROVIDER
result = _get_provider({"provider": None})
assert result == DEFAULT_PROVIDER.lower().strip()
def test_missing_provider_returns_default(self):
"""No ``provider`` key at all should also return default."""
from tools.tts_tool import _get_provider, DEFAULT_PROVIDER
result = _get_provider({})
assert result == DEFAULT_PROVIDER.lower().strip()
def test_valid_provider_passed_through(self):
from tools.tts_tool import _get_provider
result = _get_provider({"provider": "OPENAI"})
assert result == "openai"
# ── Web tools ─────────────────────────────────────────────────────────────
class TestWebBackendNullGuard:
"""tools/web_tools.py — _get_backend()"""
@patch("tools.web_tools._load_web_config", return_value={"backend": None})
def test_explicit_null_backend_does_not_crash(self, _cfg):
"""YAML ``web: {backend: null}`` should not raise AttributeError."""
from tools.web_tools import _get_backend
# Should not raise — the exact return depends on env key fallback
result = _get_backend()
assert isinstance(result, str)
@patch("tools.web_tools._load_web_config", return_value={})
def test_missing_backend_does_not_crash(self, _cfg):
from tools.web_tools import _get_backend
result = _get_backend()
assert isinstance(result, str)
# ── MCP tool ──────────────────────────────────────────────────────────────
class TestMCPAuthNullGuard:
"""tools/mcp_tool.py — MCPServerTask.__init__() auth config line"""
def test_explicit_null_auth_does_not_crash(self):
"""YAML ``auth: null`` in MCP server config should not raise."""
# Test the expression directly — MCPServerTask.__init__ has many deps
config = {"auth": None, "timeout": 30}
auth_type = (config.get("auth") or "").lower().strip()
assert auth_type == ""
def test_missing_auth_defaults_to_empty(self):
config = {"timeout": 30}
auth_type = (config.get("auth") or "").lower().strip()
assert auth_type == ""
def test_valid_auth_passed_through(self):
config = {"auth": "OAUTH", "timeout": 30}
auth_type = (config.get("auth") or "").lower().strip()
assert auth_type == "oauth"
# ── Trajectory compressor ─────────────────────────────────────────────────
class TestTrajectoryCompressorNullGuard:
"""trajectory_compressor.py — _detect_provider() and config loading"""
def test_null_base_url_does_not_crash(self):
"""base_url=None should not crash _detect_provider()."""
from trajectory_compressor import CompressionConfig, TrajectoryCompressor
config = CompressionConfig()
config.base_url = None
compressor = TrajectoryCompressor.__new__(TrajectoryCompressor)
compressor.config = config
# Should not raise AttributeError; returns empty string (no match)
result = compressor._detect_provider()
assert result == ""
def test_config_loading_null_base_url_keeps_default(self):
"""YAML ``summarization: {base_url: null}`` should keep default."""
from trajectory_compressor import CompressionConfig
from hermes_constants import OPENROUTER_BASE_URL
config = CompressionConfig()
data = {"summarization": {"base_url": None}}
config.base_url = data["summarization"].get("base_url") or config.base_url
assert config.base_url == OPENROUTER_BASE_URL
|