Update app.py

app.py

@@ -9,6 +9,10 @@ import io
 import time
 import asyncio
 from simple_salesforce import Salesforce
+from reportlab.lib.pagesizes import letter
+from reportlab.platypus import SimpleDocTemplate, Paragraph, Spacer, Table, TableStyle
+from reportlab.lib.styles import getSampleStyleSheet
+from reportlab.lib import colors
 
 # Configure logging
 logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')
@@ -41,10 +45,6 @@ except ImportError:
 
 # Try to import reportlab
 try:
-    from reportlab.lib.pagesizes import letter
-    from reportlab.platypus import SimpleDocTemplate, Paragraph, Spacer, Table, TableStyle
-    from reportlab.lib.styles import getSampleStyleSheet
-    from reportlab.lib import colors
     reportlab_available = True
     logging.info("reportlab module successfully imported")
 except ImportError:
@@ -465,7 +465,7 @@ def generate_device_cards(df):
         return f'<p>Error generating device cards: {str(e)}</p>'
 
 # Generate PDF content
-def generate_pdf_content(summary, preview_df, anomalies, amc_reminders, insights, device_cards_html, daily_log_chart, weekly_uptime_chart, anomaly_alerts_chart, downtime_chart):
+def generate_pdf_content(summary, preview_html, anomalies, amc_reminders, insights, device_cards_html, daily_log_chart, weekly_uptime_chart, anomaly_alerts_chart, downtime_chart):
     if not reportlab_available:
         logging.warning("PDF generation disabled: reportlab not available")
         return None
@@ -475,8 +475,10 @@ def generate_pdf_content(summary, preview_df, anomalies, amc_reminders, insights
         styles = getSampleStyleSheet()
         story = []
 
+        logging.info("Starting PDF generation with summary: %s", summary)
         def safe_paragraph(text, style):
-            return Paragraph(str(text).replace('\n', '<br/>'), style) if text else Paragraph("", style)
+            cleaned_text = str(text).replace('\n', '<br/>') if text else "No data available"
+            return Paragraph(cleaned_text, style)
 
         story.append(Paragraph("LabOps Status Report", styles['Title']))
         story.append(Paragraph(f"Generated on {datetime.now().strftime('%Y-%m-%d %H:%M:%S')}", styles['Normal']))
@@ -487,6 +489,8 @@ def generate_pdf_content(summary, preview_df, anomalies, amc_reminders, insights
         story.append(Spacer(1, 12))
 
         story.append(Paragraph("Log Preview", styles['Heading2']))
+        preview_df = pd.DataFrame() if not preview_html else pd.read_html(preview_html)[0] if pd.read_html(preview_html, flavor='bs4') else pd.DataFrame()
+        logging.info("Preview DF shape: %s", preview_df.shape if not preview_df.empty else "Empty")
         if not preview_df.empty:
             data = [preview_df.columns.tolist()] + preview_df.head(5).values.tolist()
             table = Table(data)
@@ -509,7 +513,7 @@ def generate_pdf_content(summary, preview_df, anomalies, amc_reminders, insights
         story.append(Spacer(1, 12))
 
         story.append(Paragraph("Device Cards", styles['Heading2']))
-        device_cards_text = device_cards_html.replace('<div>', '').replace('</div>', '\n').replace('<h4>', '').replace('</h4>', '\n').replace('<p>', '').replace('</p>', '\n').replace('<b>', '').replace('</b>', '').replace('<span style="color: green">', '').replace('<span style="color: red">', '').replace('<span style="color: orange">', '').replace('<span style="color: gray">', '').replace('</span>', '')
+        device_cards_text = device_cards_html.replace('<div>', '').replace('</div>', '\n').replace('<h4>', '').replace('</h4>', '\n').replace('<p>', '').replace('</p>', '\n').replace('<b>', '').replace('</b>', '').replace('<span style="color: green">', '').replace('<span style="color: red">', '').replace('<span style="color: orange">', '').replace('<span style="color: gray">', '').replace('</span>', '') if device_cards_html else "No device cards available"
         story.append(safe_paragraph(device_cards_text, styles['Normal']))
         story.append(Spacer(1, 12))
 
@@ -529,13 +533,14 @@ def generate_pdf_content(summary, preview_df, anomalies, amc_reminders, insights
         if not plotly_available:
             story.append(safe_paragraph("Charts unavailable: plotly not installed.", styles['Normal']))
         else:
-            story.append(safe_paragraph("[Chart placeholders - see dashboard for visuals]", styles['Normal']))
+            chart_count = sum(1 for chart in [daily_log_chart, weekly_uptime_chart, anomaly_alerts_chart, downtime_chart] if chart is not None)
+            story.append(safe_paragraph(f"[Chart placeholders - {chart_count} charts included, see dashboard for visuals]", styles['Normal']))
 
         doc.build(story)
-        logging.info(f"PDF generated at {pdf_path}")
+        logging.info(f"PDF generated successfully at {pdf_path}")
         return pdf_path
     except Exception as e:
-        logging.error(f"Failed to generate PDF: {str(e)}. Check input data or reportlab configuration.")
+        logging.error(f"Failed to generate PDF: {str(e)}. Check input data or reportlab configuration. Input summary: {summary[:100]}...")
         return None
 
 # Main processing function
@@ -585,7 +590,6 @@ async def process_logs(file_obj, lab_site_filter, equipment_type_filter, date_ra
             filtered_df = filtered_df[filtered_df['equipment_type'] == equipment_type_filter]
         if date_range is not None:
             if isinstance(date_range, (int, float)):
-                # Convert single value to a range for a single day
                 days = int(date_range)
                 date_range = [days, days]
                 logging.info(f"Converted single value {days} to range {date_range}")
@@ -649,14 +653,17 @@ async def process_logs(file_obj, lab_site_filter, equipment_type_filter, date_ra
 # Generate PDF separately
 async def generate_pdf(summary, preview_html, usage_chart, device_cards, daily_log_chart, weekly_uptime_chart, anomaly_alerts_chart, downtime_chart, anomalies, amc_reminders, insights):
     try:
-        preview_df = pd.read_html(preview_html)[0] if preview_html else pd.DataFrame()
-        pdf_file = generate_pdf_content(summary, preview_df, anomalies, amc_reminders, insights, device_cards, daily_log_chart, weekly_uptime_chart, anomaly_alerts_chart, downtime_chart)
+        logging.info("Starting PDF generation process")
+        preview_df = pd.DataFrame() if not preview_html else pd.read_html(preview_html, flavor='bs4')[0] if pd.read_html(preview_html, flavor='bs4') else pd.DataFrame()
+        logging.info("Preview DF created with shape: %s", preview_df.shape if not preview_df.empty else "Empty")
+        pdf_file = generate_pdf_content(summary, preview_html, anomalies, amc_reminders, insights, device_cards, daily_log_chart, weekly_uptime_chart, anomaly_alerts_chart, downtime_chart)
         if pdf_file is None:
             logging.warning("PDF generation failed or disabled.")
             return "PDF generation failed. Check logs for details."
+        logging.info("PDF generated successfully at: %s", pdf_file)
         return pdf_file
     except Exception as e:
-        logging.error(f"Failed to generate PDF: {str(e)}")
+        logging.error(f"Failed to generate PDF: {str(e)}. Input summary: {summary[:100]}...")
         return f"Error generating PDF: {str(e)}"
 
 # Update filters