Update app.py

app.py

@@ -380,7 +380,7 @@
 # # ------------------------------
 # # MCQ Generation
 # # ------------------------------
-# def generate_mcqs(context, topic, subject):
+# def generate_mcqs(context, topic, subject, num_questions=5):
 #     # Check if Groq is available
 #     if not groq_client:
 #         error_msg = """ERROR: Groq API not initialized!
@@ -393,13 +393,13 @@
     
 #     # Check cache
 #     context_hash = hashlib.md5(context.encode()).hexdigest()[:8]
-#     cache_key = get_cache_key(topic, subject, context_hash)
+#     cache_key = get_cache_key(topic, subject, context_hash) + f":{num_questions}"
     
 #     if cache_key in MCQ_CACHE:
 #         print("✓ Using cached MCQs")
 #         return MCQ_CACHE[cache_key]["mcqs"], MCQ_CACHE[cache_key]["chapter"]
     
-#     print(f"🤖 Generating MCQs for {subject} - {topic}")
+#     print(f"🤖 Generating {num_questions} MCQs for {subject} - {topic}")
     
 #     # Detect the chapter from our actual chapter list
 #     chapter = detect_chapter_from_list(context, topic, subject)
@@ -416,7 +416,7 @@
 # Reference material from textbook:
 # {context[:1500]}
 
-# Generate exactly 5 multiple-choice questions based on the reference material.
+# Generate exactly {num_questions} multiple-choice questions based on the reference material.
 
 # FORMAT (follow EXACTLY):
 # Q1. [Question based on material]
@@ -433,7 +433,7 @@
 # D) [Option 4]
 # Answer: [A/B/C/D] - [Brief explanation]
 
-# Continue for Q3, Q4, Q5.
+# Continue for Q3, Q4, Q5{"..." if num_questions > 5 else ""}.
 
 # REQUIREMENTS:
 # - All questions must be answerable from the reference material
@@ -441,9 +441,12 @@
 # - Correct answer must be clearly supported by material
 # - Keep explanations brief (1-2 sentences)
 
-# Generate 5 MCQs now:"""
+# Generate {num_questions} MCQs now:"""
     
 #     try:
+#         # Adjust max_tokens based on number of questions
+#         max_tokens = min(3000, 300 * num_questions)
+        
 #         chat_completion = groq_client.chat.completions.create(
 #             messages=[
 #                 {
@@ -457,7 +460,7 @@
 #             ],
 #             model="llama-3.3-70b-versatile",
 #             temperature=0.3,
-#             max_tokens=1500,
+#             max_tokens=max_tokens,
 #             top_p=0.9
 #         )
         
@@ -685,7 +688,33 @@
 #                 <input type="text" id="topic" placeholder="e.g., Mitochondria, Chemical Bonding, Newton's Laws">
 #             </div>
             
-#             <button onclick="generateMCQs()">🚀 Generate 5 MCQs</button>
+#             <div class="form-group">
+#                 <label for="numQuestions">🔢 Number of MCQs</label>
+#                 <select id="numQuestions">
+#                     <option value="1">1 MCQ</option>
+#                     <option value="2">2 MCQs</option>
+#                     <option value="3">3 MCQs</option>
+#                     <option value="4">4 MCQs</option>
+#                     <option value="5" selected>5 MCQs</option>
+#                     <option value="6">6 MCQs</option>
+#                     <option value="7">7 MCQs</option>
+#                     <option value="8">8 MCQs</option>
+#                     <option value="9">9 MCQs</option>
+#                     <option value="10">10 MCQs</option>
+#                     <option value="11">11 MCQs</option>
+#                     <option value="12">12 MCQs</option>
+#                     <option value="13">13 MCQs</option>
+#                     <option value="14">14 MCQs</option>
+#                     <option value="15">15 MCQs</option>
+#                     <option value="16">16 MCQs</option>
+#                     <option value="17">17 MCQs</option>
+#                     <option value="18">18 MCQs</option>
+#                     <option value="19">19 MCQs</option>
+#                     <option value="20">20 MCQs</option>
+#                 </select>
+#             </div>
+            
+#             <button onclick="generateMCQs()">🚀 Generate MCQs</button>
             
 #             <div class="loading" id="loading">
 #                 <div class="spinner"></div>
@@ -715,6 +744,7 @@
 #         async function generateMCQs() {
 #             const subject = document.getElementById('subject').value;
 #             const topic = document.getElementById('topic').value.trim();
+#             const numQuestions = parseInt(document.getElementById('numQuestions').value);
             
 #             if (!topic) {
 #                 alert('⚠️ Please enter a topic!');
@@ -736,7 +766,7 @@
 #                 const response = await fetch('/generate', {
 #                     method: 'POST',
 #                     headers: {'Content-Type': 'application/json'},
-#                     body: JSON.stringify({subject, topic})
+#                     body: JSON.stringify({subject, topic, num_questions: numQuestions})
 #                 });
                 
 #                 const data = await response.json();
@@ -759,7 +789,7 @@
 #             } finally {
 #                 loading.classList.remove('show');
 #                 btn.disabled = false;
-#                 btn.textContent = '🚀 Generate 5 MCQs';
+#                 btn.textContent = '🚀 Generate MCQs';
 #             }
 #         }
         
@@ -786,6 +816,15 @@
 #         data = request.json
 #         subject = data.get("subject", "").lower()
 #         topic = data.get("topic", "")
+#         num_questions = data.get("num_questions", 5)
+        
+#         # Validate num_questions
+#         try:
+#             num_questions = int(num_questions)
+#             if num_questions < 1 or num_questions > 20:
+#                 num_questions = 5
+#         except:
+#             num_questions = 5
         
 #         if not topic:
 #             return jsonify({"error": "Topic is required"}), 400
@@ -817,7 +856,7 @@
 #         print(f"✓ Context found ({len(context)} chars)")
         
 #         # STEP 3: Generate MCQs
-#         mcqs, chapter = generate_mcqs(context, topic, subject)
+#         mcqs, chapter = generate_mcqs(context, topic, subject, num_questions)
         
 #         # Check if there was a subject mismatch
 #         if chapter is None:
@@ -850,6 +889,7 @@
 #     port = int(os.environ.get("PORT", 7860))
 #     print(f"\n🚀 Starting server on port {port}...\n")
 #     app.run(host="0.0.0.0", port=port, debug=False)
+
 import pickle
 import faiss
 from flask import Flask, request, jsonify, render_template_string
@@ -1349,7 +1389,414 @@ def clean_mcq_output(text):
             if line.startswith('Correct Answer:'):
                 line = line.replace('Correct Answer:', 'Answer:')
             
-            cleaned_lines.append(line)
+            # Split Answer and explanation onto separate lines
+            if line.startswith('Answer:'):
+                # Match pattern: Answer: X) text - explanation
+                match = re.match(r'(Answer:\s*[A-D]\))\s*(.+?)(\s*-\s*(.+))?
+
+# ------------------------------
+# HTML UI
+# ------------------------------
+HTML_TEMPLATE = """
+<!DOCTYPE html>
+<html>
+<head>
+    <title>Class 12 PCB MCQ Generator</title>
+    <style>
+        * { margin: 0; padding: 0; box-sizing: border-box; }
+        body {
+            font-family: 'Segoe UI', Tahoma, Geneva, Verdana, sans-serif;
+            background: linear-gradient(135deg, #667eea 0%, #764ba2 100%);
+            min-height: 100vh;
+            padding: 20px;
+        }
+        .container {
+            max-width: 900px;
+            margin: 0 auto;
+            background: white;
+            border-radius: 20px;
+            box-shadow: 0 20px 60px rgba(0,0,0,0.3);
+            overflow: hidden;
+        }
+        .header {
+            background: linear-gradient(135deg, #667eea 0%, #764ba2 100%);
+            color: white;
+            padding: 30px;
+            text-align: center;
+        }
+        .header h1 { font-size: 2.5em; margin-bottom: 10px; }
+        .content { padding: 40px; }
+        .form-group { margin-bottom: 25px; }
+        label {
+            display: block;
+            font-weight: 600;
+            margin-bottom: 10px;
+            color: #333;
+            font-size: 16px;
+        }
+        select, input {
+            width: 100%;
+            padding: 15px;
+            border: 2px solid #e0e0e0;
+            border-radius: 10px;
+            font-size: 16px;
+            font-family: inherit;
+            transition: border-color 0.3s;
+        }
+        select:focus, input:focus {
+            outline: none;
+            border-color: #667eea;
+        }
+        button {
+            width: 100%;
+            padding: 18px;
+            background: linear-gradient(135deg, #667eea 0%, #764ba2 100%);
+            color: white;
+            border: none;
+            border-radius: 10px;
+            font-size: 18px;
+            font-weight: 600;
+            cursor: pointer;
+            transition: all 0.3s;
+        }
+        button:hover {
+            transform: translateY(-2px);
+            box-shadow: 0 10px 20px rgba(102, 126, 234, 0.4);
+        }
+        button:disabled {
+            background: #ccc;
+            cursor: not-allowed;
+            transform: none;
+        }
+        .result {
+            margin-top: 30px;
+            padding: 25px;
+            background: #f8f9fa;
+            border-radius: 10px;
+            border-left: 4px solid #667eea;
+            display: none;
+        }
+        .result.show { display: block; }
+        .result h3 {
+            color: #667eea;
+            margin-bottom: 20px;
+            font-size: 1.4em;
+        }
+        .chapter-info {
+            background: linear-gradient(135deg, #667eea 0%, #764ba2 100%);
+            color: white;
+            padding: 15px 20px;
+            border-radius: 8px;
+            margin-bottom: 20px;
+            display: flex;
+            align-items: center;
+            gap: 10px;
+            font-size: 16px;
+        }
+        .chapter-icon {
+            font-size: 24px;
+        }
+        .chapter-text {
+            flex: 1;
+        }
+        .chapter-name {
+            font-weight: 700;
+            font-size: 18px;
+        }
+        .mcq-content {
+            background: white;
+            padding: 25px;
+            border-radius: 8px;
+            white-space: pre-wrap;
+            line-height: 1.9;
+            font-size: 15px;
+        }
+        .loading {
+            text-align: center;
+            padding: 30px;
+            display: none;
+        }
+        .loading.show { display: block; }
+        .spinner {
+            border: 4px solid #f3f3f3;
+            border-top: 4px solid #667eea;
+            border-radius: 50%;
+            width: 50px;
+            height: 50px;
+            animation: spin 1s linear infinite;
+            margin: 0 auto 15px;
+        }
+        @keyframes spin {
+            0% { transform: rotate(0deg); }
+            100% { transform: rotate(360deg); }
+        }
+        .subject-tag {
+            display: inline-block;
+            padding: 5px 15px;
+            border-radius: 20px;
+            font-size: 13px;
+            font-weight: 600;
+            margin-right: 10px;
+        }
+        .bio { background: #d4edda; color: #155724; }
+        .chem { background: #d1ecf1; color: #0c5460; }
+        .phy { background: #f8d7da; color: #721c24; }
+        .api-badge {
+            background: #17a2b8;
+            color: white;
+            padding: 5px 12px;
+            border-radius: 15px;
+            font-size: 12px;
+            margin-left: 10px;
+        }
+    </style>
+</head>
+<body>
+    <div class="container">
+        <div class="header">
+            <h1>🎓 Class 12 PCB MCQ Generator</h1>
+            <p style="font-size: 1.1em; margin-bottom: 15px;">
+                Generate practice MCQs from your textbooks 
+                <span class="api-badge">⚡ Llama 3.3 70B</span>
+            </p>
+            <div>
+                <span class="subject-tag bio">Biology</span>
+                <span class="subject-tag chem">Chemistry</span>
+                <span class="subject-tag phy">Physics</span>
+            </div>
+        </div>
+        
+        <div class="content">
+            <div class="form-group">
+                <label for="subject">📚 Select Subject</label>
+                <select id="subject">
+                    <option value="biology">Biology</option>
+                    <option value="chemistry">Chemistry</option>
+                    <option value="physics">Physics</option>
+                </select>
+            </div>
+            
+            <div class="form-group">
+                <label for="topic">✏️ Enter Topic</label>
+                <input type="text" id="topic" placeholder="e.g., Mitochondria, Chemical Bonding, Newton's Laws">
+            </div>
+            
+            <div class="form-group">
+                <label for="numQuestions">🔢 Number of MCQs</label>
+                <select id="numQuestions">
+                    <option value="1">1 MCQ</option>
+                    <option value="2">2 MCQs</option>
+                    <option value="3">3 MCQs</option>
+                    <option value="4">4 MCQs</option>
+                    <option value="5" selected>5 MCQs</option>
+                    <option value="6">6 MCQs</option>
+                    <option value="7">7 MCQs</option>
+                    <option value="8">8 MCQs</option>
+                    <option value="9">9 MCQs</option>
+                    <option value="10">10 MCQs</option>
+                    <option value="11">11 MCQs</option>
+                    <option value="12">12 MCQs</option>
+                    <option value="13">13 MCQs</option>
+                    <option value="14">14 MCQs</option>
+                    <option value="15">15 MCQs</option>
+                    <option value="16">16 MCQs</option>
+                    <option value="17">17 MCQs</option>
+                    <option value="18">18 MCQs</option>
+                    <option value="19">19 MCQs</option>
+                    <option value="20">20 MCQs</option>
+                </select>
+            </div>
+            
+            <button onclick="generateMCQs()">🚀 Generate MCQs</button>
+            
+            <div class="loading" id="loading">
+                <div class="spinner"></div>
+                <p style="color: #666; font-size: 16px;">Generating MCQs with AI...</p>
+                <p style="color: #999; font-size: 13px; margin-top: 10px;">⚡ Detecting chapter from textbook...</p>
+            </div>
+            
+            <div class="result" id="result">
+                <h3>📝 Generated MCQs:</h3>
+                
+                <div class="chapter-info" id="chapterInfo" style="display: none;">
+                    <span class="chapter-icon">📖</span>
+                    <div class="chapter-text">
+                        <div style="font-size: 13px; opacity: 0.9;">Chapter:</div>
+                        <div class="chapter-name" id="chapterName"></div>
+                    </div>
+                </div>
+                
+                <div style="background: #d4edda; padding: 12px; border-radius: 6px; margin-bottom: 15px; color: #155724; font-size: 14px;">
+                    ✓ <strong>High Quality:</strong> Generated by Llama 3.3 70B via Groq API
+                </div>
+                <div class="mcq-content" id="mcqContent"></div>
+            </div>
+        </div>
+    </div>
+    <script>
+        async function generateMCQs() {
+            const subject = document.getElementById('subject').value;
+            const topic = document.getElementById('topic').value.trim();
+            const numQuestions = parseInt(document.getElementById('numQuestions').value);
+            
+            if (!topic) {
+                alert('⚠️ Please enter a topic!');
+                return;
+            }
+            
+            const loading = document.getElementById('loading');
+            const result = document.getElementById('result');
+            const btn = document.querySelector('button');
+            const chapterInfo = document.getElementById('chapterInfo');
+            
+            loading.classList.add('show');
+            result.classList.remove('show');
+            chapterInfo.style.display = 'none';
+            btn.disabled = true;
+            btn.textContent = '⏳ Generating...';
+            
+            try {
+                const response = await fetch('/generate', {
+                    method: 'POST',
+                    headers: {'Content-Type': 'application/json'},
+                    body: JSON.stringify({subject, topic, num_questions: numQuestions})
+                });
+                
+                const data = await response.json();
+                
+                if (data.error) {
+                    alert('❌ Error: ' + data.error);
+                    return;
+                }
+                
+                // Display chapter info
+                if (data.chapter && data.chapter !== 'Unknown Chapter') {
+                    document.getElementById('chapterName').textContent = data.chapter;
+                    chapterInfo.style.display = 'flex';
+                }
+                
+                document.getElementById('mcqContent').textContent = data.mcqs;
+                result.classList.add('show');
+            } catch (error) {
+                alert('❌ Error: ' + error.message);
+            } finally {
+                loading.classList.remove('show');
+                btn.disabled = false;
+                btn.textContent = '🚀 Generate MCQs';
+            }
+        }
+        
+        document.getElementById('topic').addEventListener('keypress', function(e) {
+            if (e.key === 'Enter') {
+                generateMCQs();
+            }
+        });
+    </script>
+</body>
+</html>
+"""
+
+# ------------------------------
+# Routes
+# ------------------------------
+@app.route("/")
+def home():
+    return render_template_string(HTML_TEMPLATE)
+
+@app.route("/generate", methods=["POST"])
+def generate():
+    try:
+        data = request.json
+        subject = data.get("subject", "").lower()
+        topic = data.get("topic", "")
+        num_questions = data.get("num_questions", 5)
+        
+        # Validate num_questions
+        try:
+            num_questions = int(num_questions)
+            if num_questions < 1 or num_questions > 20:
+                num_questions = 5
+        except:
+            num_questions = 5
+        
+        if not topic:
+            return jsonify({"error": "Topic is required"}), 400
+        
+        if subject not in SUBJECTS:
+            return jsonify({"error": "Invalid subject"}), 400
+        
+        print(f"\n🔍 Validating topic for {subject}...")
+        
+        # STEP 1: Validate if topic belongs to subject (BEFORE RAG search)
+        if not validate_topic_subject(topic, subject):
+            subject_names = {
+                "biology": "Biology",
+                "chemistry": "Chemistry", 
+                "physics": "Physics"
+            }
+            error_msg = f"The topic '{topic}' does not appear to be related to {subject_names[subject]}.\n\nPlease either:\n• Enter a {subject_names[subject]}-related topic, or\n• Select the correct subject for this topic"
+            return jsonify({"error": error_msg}), 400
+        
+        print(f"✓ Topic validated for {subject}")
+        print(f"🔍 Searching {subject} for: {topic}")
+        
+        # STEP 2: RAG search
+        context = rag_search(topic, subject, k=5)
+        
+        if not context or len(context.strip()) < 50:
+            return jsonify({"error": f"No content found for: {topic}"}), 404
+        
+        print(f"✓ Context found ({len(context)} chars)")
+        
+        # STEP 3: Generate MCQs
+        mcqs, chapter = generate_mcqs(context, topic, subject, num_questions)
+        
+        # Check if there was a subject mismatch
+        if chapter is None:
+            return jsonify({"error": mcqs}), 400
+        
+        return jsonify({
+            "mcqs": mcqs, 
+            "subject": subject,
+            "chapter": chapter
+        })
+    
+    except Exception as e:
+        print(f"❌ Error: {e}")
+        import traceback
+        traceback.print_exc()
+        return jsonify({"error": str(e)}), 500
+
+@app.route("/health")
+def health():
+    return jsonify({
+        "status": "healthy",
+        "groq_available": groq_client is not None,
+        "cache_size": len(MCQ_CACHE)
+    })
+
+# ------------------------------
+# Run
+# ------------------------------
+if __name__ == "__main__":
+    port = int(os.environ.get("PORT", 7860))
+    print(f"\n🚀 Starting server on port {port}...\n")
+    app.run(host="0.0.0.0", port=port, debug=False), line)
+                if match:
+                    answer_part = match.group(1)  # "Answer: A)"
+                    option_text = match.group(2) if match.group(2) else ""  # The option text
+                    explanation = match.group(4) if match.group(4) else ""  # The explanation after -
+                    
+                    if explanation:
+                        # Put answer with option text on one line, explanation on next
+                        cleaned_lines.append(f"{answer_part} {option_text}")
+                        cleaned_lines.append(f"Explanation: {explanation}")
+                    else:
+                        cleaned_lines.append(line)
+                else:
+                    cleaned_lines.append(line)
+            else:
+                cleaned_lines.append(line)
     
     return '\n'.join(cleaned_lines)