Update server.js

server.js

@@ -24,20 +24,17 @@ const axiosInstance = axios.create({
     httpsAgent: new https.Agent({ rejectUnauthorized: false })
 });
 
-// Function to generate a unique filename
-const generateUniqueFilename = (extension = "") => {
-    return crypto.randomBytes(10).toString("hex") + extension;
-};
+// Function to generate a unique request ID
+const generateRequestId = () => crypto.randomBytes(6).toString("hex");
 
-// Function to delete a file after a delay (default: 10 minutes)
-const scheduleFileDeletion = (filePath, delay = 600000) => {
-    setTimeout(() => {
-        fs.unlink(filePath, (err) => {
-            if (!err) {
-                console.log(`✅ Deleted file: ${filePath}`);
-            }
-        });
-    }, delay);
+// Function to validate URLs
+const isValidUrl = (url) => {
+    try {
+        new URL(url);
+        return true;
+    } catch (error) {
+        return false;
+    }
 };
 
 // Function to convert MKV to MP4
@@ -45,7 +42,7 @@ const convertToMp4 = (inputPath, outputPath) => {
     return new Promise((resolve, reject) => {
         ffmpeg(inputPath)
             .output(outputPath)
-            .outputOptions(["-c:v copy", "-c:a aac", "-strict experimental"]) // Fast conversion
+            .outputOptions(["-c:v copy", "-c:a aac", "-strict experimental"])
             .on("end", () => {
                 console.log(`✅ Conversion complete: ${outputPath}`);
                 resolve(outputPath);
@@ -58,32 +55,45 @@ const convertToMp4 = (inputPath, outputPath) => {
     });
 };
 
+// Function to delete files after a delay (default: 10 minutes)
+const scheduleFileDeletion = (filePath, delay = 600000) => {
+    setTimeout(() => {
+        fs.unlink(filePath, (err) => {
+            if (!err) {
+                console.log(`✅ Deleted file: ${filePath}`);
+            }
+        });
+    }, delay);
+};
+
 // API Route to download, convert, and serve .mp4 files
 app.get("/download", async (req, res) => {
     const fileUrl = req.query.url;
-    if (!fileUrl) {
-        return res.status(400).json({ error: "❌ Missing URL parameter" });
+    
+    // Validate URL before processing
+    if (!fileUrl || !isValidUrl(fileUrl)) {
+        return res.status(400).json({ error: "❌ Invalid or missing URL parameter" });
     }
 
+    // Generate a unique request ID
+    const requestId = generateRequestId();
+    console.log(`📥 [${requestId}] Processing request for: ${fileUrl}`);
+
     try {
-        console.log(`⬇️ Downloading: ${fileUrl}`);
+        console.log(`⬇️ [${requestId}] Downloading: ${fileUrl}`);
 
         const response = await axiosInstance({
             url: fileUrl,
             method: "GET",
             responseType: "stream",
-            headers: {
-                "User-Agent": "Mozilla/5.0",
-                "Accept": "*/*"
-            }
+            headers: { "User-Agent": "Mozilla/5.0", "Accept": "*/*" }
         });
 
-        // Generate a unique filename
         const isMkv = fileUrl.toLowerCase().endsWith(".mkv");
-        const originalFilename = generateUniqueFilename(isMkv ? ".mkv" : ".mp4");
+        const originalFilename = `${requestId}${isMkv ? ".mkv" : ".mp4"}`;
         const originalFilePath = path.join(DOWNLOAD_DIR, originalFilename);
 
-        const mp4Filename = originalFilename.replace(".mkv", ".mp4");
+        const mp4Filename = `${requestId}.mp4`;
         const mp4FilePath = path.join(DOWNLOAD_DIR, mp4Filename);
 
         const writer = fs.createWriteStream(originalFilePath);
@@ -91,13 +101,13 @@ app.get("/download", async (req, res) => {
 
         writer.on("close", async () => {
             const hostUrl = `${req.protocol}://${req.get("host")}`;
-            
+
             if (isMkv) {
                 try {
                     await convertToMp4(originalFilePath, mp4FilePath);
                     fs.unlinkSync(originalFilePath); // Remove MKV file
                 } catch (error) {
-                    console.error("❌ Conversion error:", error.message);
+                    console.error(`❌ [${requestId}] Conversion error:`, error.message);
                     return res.status(500).json({ error: "❌ Conversion failed" });
                 }
             }
@@ -105,17 +115,17 @@ app.get("/download", async (req, res) => {
             const servedUrl = `${hostUrl}/files/${mp4Filename}`;
             scheduleFileDeletion(mp4FilePath);
 
-            console.log(`✅ Download & conversion complete: ${servedUrl}`);
+            console.log(`✅ [${requestId}] Download & conversion complete: ${servedUrl}`);
             res.json({ message: "Download & conversion complete", fileUrl: servedUrl });
         });
 
         writer.on("error", (err) => {
-            console.error("❌ Error writing file:", err);
+            console.error(`❌ [${requestId}] Error writing file:`, err);
             res.status(500).json({ error: "Error saving file" });
         });
 
     } catch (error) {
-        console.error("❌ Download error:", error.message);
+        console.error(`❌ [${requestId}] Download error:`, error.message);
         res.status(500).json({ error: "Failed to download file" });
     }
 });