Update api/routes/pdf.py

api/routes/pdf.py

@@ -22,14 +22,17 @@ router = APIRouter()
 
 @router.get("/{patient_id}/pdf", response_class=Response)
 async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get_current_user)):
-    # Suppress logging for this route
-    logger.setLevel(logging.CRITICAL)
+    logger.info(f"Generating PDF for patient {patient_id} by {current_user.get('email')}")
+    
+    if current_user.get('role') not in ['doctor', 'admin']:
+        logger.warning(f"Unauthorized PDF generation attempt by {current_user.get('email')}")
+        raise HTTPException(
+            status_code=status.HTTP_403_FORBIDDEN,
+            detail="Only clinicians can generate patient PDFs",
+            headers={"WWW-Authenticate": "Bearer"}
+        )
 
     try:
-        if current_user.get('role') not in ['doctor', 'admin']:
-            raise HTTPException(status_code=403, detail="Only clinicians can generate patient PDFs")
-
-        # Determine if patient_id is ObjectId or fhir_id
         try:
             obj_id = ObjectId(patient_id)
             query = {"$or": [{"_id": obj_id}, {"fhir_id": patient_id}]}
@@ -38,9 +41,12 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
 
         patient = await patients_collection.find_one(query)
         if not patient:
-            raise HTTPException(status_code=404, detail="Patient not found")
+            logger.warning(f"Patient not found: {patient_id}")
+            raise HTTPException(
+                status_code=status.HTTP_404_NOT_FOUND,
+                detail="Patient not found"
+            )
 
-        # Prepare table content with proper LaTeX formatting
         def prepare_table_content(items, columns, default_message):
             if not items:
                 return f"\\multicolumn{{{columns}}}{{l}}{{{default_message}}} \\\\"
@@ -54,7 +60,6 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
                 content.append(" & ".join(row) + " \\\\")
             return "\n".join(content)
 
-        # Notes table
         notes = patient.get("notes", [])
         notes_content = prepare_table_content(
             [{
@@ -66,7 +71,6 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
             "No notes available"
         )
 
-        # Conditions table
         conditions = patient.get("conditions", [])
         conditions_content = prepare_table_content(
             [{
@@ -80,7 +84,6 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
             "No conditions available"
         )
 
-        # Medications table
         medications = patient.get("medications", [])
         medications_content = prepare_table_content(
             [{
@@ -94,7 +97,6 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
             "No medications available"
         )
 
-        # Encounters table
         encounters = patient.get("encounters", [])
         encounters_content = prepare_table_content(
             [{
@@ -108,7 +110,6 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
             "No encounters available"
         )
 
-        # LaTeX template with improved table formatting
         latex_template = Template(r"""
 \documentclass[a4paper,12pt]{article}
 \usepackage[utf8]{inputenc}
@@ -189,8 +190,7 @@ $encounters
 \end{document}
 """)
 
-        # Set the generated_on date to 02:54 PM CET, May 17, 2025
-        generated_on = datetime.strptime("2025-05-17 14:54:00+02:00", "%Y-%m-%d %H:%M:%S%z").strftime("%A, %B %d, %Y at %I:%M %p %Z")
+        generated_on = datetime.utcnow().strftime("%A, %B %d, %Y at %I:%M %p UTC")
 
         latex_filled = latex_template.substitute(
             generated_on=generated_on,
@@ -214,7 +214,6 @@ $encounters
             encounters=encounters_content
         )
 
-        # Compile LaTeX in a temporary directory
         with TemporaryDirectory() as tmpdir:
             tex_path = os.path.join(tmpdir, "report.tex")
             pdf_path = os.path.join(tmpdir, "report.pdf")
@@ -223,7 +222,6 @@ $encounters
                 f.write(latex_filled)
 
             try:
-                # Run latexmk twice to ensure proper table rendering
                 for _ in range(2):
                     result = subprocess.run(
                         ["latexmk", "-pdf", "-interaction=nonstopmode", tex_path],
@@ -234,43 +232,44 @@ $encounters
                     )
                 
                 if result.returncode != 0:
+                    logger.error(f"LaTeX compilation failed: stdout={result.stdout}, stderr={result.stderr}")
                     raise HTTPException(
-                        status_code=500,
-                        detail=f"LaTeX compilation failed: stdout={result.stdout}, stderr={result.stderr}"
+                        status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+                        detail=f"LaTeX compilation failed: {result.stderr}"
                     )
 
             except subprocess.CalledProcessError as e:
+                logger.error(f"LaTeX compilation error: stdout={e.stdout}, stderr={e.stderr}")
                 raise HTTPException(
-                    status_code=500,
-                    detail=f"LaTeX compilation failed: stdout={e.stdout}, stderr={e.stderr}"
+                    status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+                    detail=f"LaTeX compilation failed: {e.stderr}"
                 )
 
             if not os.path.exists(pdf_path):
+                logger.error("PDF file was not generated")
                 raise HTTPException(
-                    status_code=500,
+                    status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
                     detail="PDF file was not generated"
                 )
 
             with open(pdf_path, "rb") as f:
                 pdf_bytes = f.read()
 
-            response = Response(
+            logger.info(f"PDF generated successfully for patient {patient_id} by {current_user.get('email')}")
+            return Response(
                 content=pdf_bytes,
                 media_type="application/pdf",
                 headers={"Content-Disposition": f"attachment; filename=patient_{patient.get('fhir_id', 'unknown')}_report.pdf"}
             )
-            return response
 
-    except HTTPException as http_error:
-        raise http_error
+    except HTTPException:
+        raise
     except Exception as e:
+        logger.error(f"Unexpected error generating PDF for patient {patient_id}: {str(e)}")
         raise HTTPException(
-            status_code=500,
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail=f"Unexpected error generating PDF: {str(e)}"
         )
-    finally:
-        # Restore the logger level for other routes
-        logger.setLevel(logging.INFO)
 
-# Export the router as 'pdf' for api.__init__.py
+# Export the router
 pdf = router