Update api/routes.py

api/routes.py

@@ -22,6 +22,7 @@ import uuid
 import re
 import subprocess
 from tempfile import NamedTemporaryFile
+import tempfile
 
 # Configure logging
 logging.basicConfig(
@@ -566,228 +567,96 @@ async def add_note(
             detail=f"Failed to add note: {str(e)}"
         )
 
+
 @router.get("/ehr/patients/{patient_id}/pdf", response_class=Response)
 async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get_current_user)):
-    # Disable logging for this route by setting the logger's level to CRITICAL
-    logger.setLevel(logging.CRITICAL)
+    logger.info(f"Generating PDF for patient: {patient_id} by user {current_user.get('email')}")
 
-    # Re-enable logging after the function exits to avoid affecting other routes
-    try:
-        if current_user.get('role') not in ['doctor', 'admin']:
-            raise HTTPException(status_code=403, detail="Only clinicians can generate patient PDFs")
+    if current_user.get('role') not in ['doctor', 'admin']:
+        raise HTTPException(status_code=403, detail="Only clinicians can generate patient PDFs")
 
-        # Determine if patient_id is ObjectId or fhir_id
+    try:
         try:
             obj_id = ObjectId(patient_id)
-            query = { "$or": [ { "_id": obj_id }, { "fhir_id": patient_id } ] }
-        except InvalidId:
-            query = { "fhir_id": patient_id }
+            query = {"$or": [{"_id": obj_id}, {"fhir_id": patient_id}]}
+        except Exception:
+            query = {"fhir_id": patient_id}
 
         patient = await patients_collection.find_one(query)
 
         if not patient:
             raise HTTPException(status_code=404, detail="Patient not found")
 
-        # Format LaTeX content using .format() to avoid f-string escape issues
-        latex_template = r"""
-\documentclass[a4paper,12pt]{article}
-\usepackage[utf8]{inputenc}
-\usepackage[T1]{fontenc}
-\usepackage{geometry}
-\geometry{margin=1in}
-\usepackage{booktabs,longtable,fancyhdr}
-\pagestyle{fancy}
-\fancyhf{}
-\fancyhead[L]{Patient Report}
-\fancyhead[R]{Generated: \today}
-\fancyfoot[C]{\thepage}
-
-\begin{document}
-
-\begin{center}
-    \Large\textbf{Patient Medical Report} \\
-    \vspace{0.2cm}
-    \textit{Generated on %(generated_on)s}
-\end{center}
-
-\section*{Demographics}
-\begin{itemize}
-    \item \textbf{FHIR ID:} %(fhir_id)s
-    \item \textbf{Full Name:} %(full_name)s
-    \item \textbf{Gender:} %(gender)s
-    \item \textbf{Date of Birth:} %(dob)s
-    \item \textbf{Age:} %(age)s
-    \item \textbf{Address:} %(address)s
-    \item \textbf{Marital Status:} %(marital_status)s
-    \item \textbf{Language:} %(language)s
-\end{itemize}
-
-\section*{Clinical Notes}
-\begin{longtable}{p{3cm}p{3cm}p{7cm}}
-\toprule
-\textbf{Date} & \textbf{Type} & \textbf{Text} \\
-\midrule
-%(notes)s
-\bottomrule
-\end{longtable}
-
-\section*{Conditions}
-\begin{longtable}{p{2cm}p{3cm}p{2cm}p{2cm}p{3cm}}
-\toprule
-\textbf{ID} & \textbf{Code} & \textbf{Status} & \textbf{Onset} & \textbf{Verification} \\
-\midrule
-%(conditions)s
-\bottomrule
-\end{longtable}
-
-\section*{Medications}
-\begin{longtable}{p{2cm}p{4cm}p{2cm}p{2cm}p{2cm}}
-\toprule
-\textbf{ID} & \textbf{Name} & \textbf{Status} & \textbf{Date} & \textbf{Dosage} \\
-\midrule
-%(medications)s
-\bottomrule
-\end{longtable}
-
-\section*{Encounters}
-\begin{longtable}{p{2cm}p{4cm}p{2cm}p{3cm}p{3cm}}
-\toprule
-\textbf{ID} & \textbf{Type} & \textbf{Status} & \textbf{Start} & \textbf{Provider} \\
-\midrule
-%(encounters)s
-\bottomrule
-\end{longtable}
-
-\end{document}
-        """
-
-        # Build the LaTeX-safe rows with escaped special characters
-        notes = "\n".join([
-            "{} & {} & {} \\\\".format(
-                escape_latex_special_chars(n.get("date", "")),
-                escape_latex_special_chars(n.get("type", "")),
-                escape_latex_special_chars(n.get("text", ""))
-            )
-            for n in patient.get("notes", [])
-        ])
-        conditions = "\n".join([
-            "{} & {} & {} & {} & {} \\\\".format(
-                escape_latex_special_chars(c.get("id", "")),
-                escape_latex_special_chars(c.get("code", "")),
-                escape_latex_special_chars(c.get("status", "")),
-                escape_latex_special_chars(c.get("onset_date", "")),
-                escape_latex_special_chars(c.get("verification_status", ""))
-            )
-            for c in patient.get("conditions", [])
-        ])
-        medications = "\n".join([
-            "{} & {} & {} & {} & {} \\\\".format(
-                escape_latex_special_chars(m.get("id", "")),
-                escape_latex_special_chars(m.get("name", "")),
-                escape_latex_special_chars(m.get("status", "")),
-                escape_latex_special_chars(m.get("prescribed_date", "")),
-                escape_latex_special_chars(m.get("dosage", ""))
-            )
-            for m in patient.get("medications", [])
-        ])
-        encounters = "\n".join([
-            "{} & {} & {} & {} & {} \\\\".format(
-                escape_latex_special_chars(e.get("id", "")),
-                escape_latex_special_chars(e.get("type", "")),
-                escape_latex_special_chars(e.get("status", "")),
-                escape_latex_special_chars(e.get("period", {}).get("start", "")),
-                escape_latex_special_chars(e.get("service_provider", ""))
-            )
-            for e in patient.get("encounters", [])
-        ])
-
-        # Update the generated_on date to reflect the current time: 03:14 PM CET, May 16, 2025
-        latex_filled = latex_template % {
-            "generated_on": datetime.strptime("2025-05-16 15:14:00+01:00", "%Y-%m-%d %H:%M:%S%z").strftime("%A, %B %d, %Y at %I:%M %p"),
-            "fhir_id": escape_latex_special_chars(patient.get("fhir_id", "")),
-            "full_name": escape_latex_special_chars(patient.get("full_name", "")),
-            "gender": escape_latex_special_chars(patient.get("gender", "")),
-            "dob": escape_latex_special_chars(patient.get("date_of_birth", "")),
-            "age": escape_latex_special_chars(str(calculate_age(patient.get("date_of_birth", "")) or "N/A")),
-            "address": escape_latex_special_chars("{}, {}, {}, {}, {}".format(
-                patient.get("address", ""),
-                patient.get("city", ""),
-                patient.get("state", ""),
-                patient.get("postal_code", ""),
-                patient.get("country", "")
-            )),
-            "marital_status": escape_latex_special_chars(patient.get("marital_status", "")),
-            "language": escape_latex_special_chars(patient.get("language", "")),
-            "notes": notes or "No notes available \\\\",
-            "conditions": conditions or "No conditions available \\\\",
-            "medications": medications or "No medications available \\\\",
-            "encounters": encounters or "No encounters available \\\\"
-        }
-
-        # Write LaTeX to file with error handling
-        try:
-            with NamedTemporaryFile(suffix=".tex", mode="w", delete=False, encoding="utf-8") as tex_file:
-                tex_file.write(latex_filled)
-                tex_path = tex_file.name
-
-            # Compile LaTeX to PDF
-            try:
-                result = subprocess.run(
-                    ["latexmk", "-pdf", tex_path],
-                    check=True,
-                    capture_output=True,
-                    text=True
-                )
-            except subprocess.CalledProcessError as e:
-                raise HTTPException(
-                    status_code=500,
-                    detail=f"LaTeX compilation failed: {e.stderr}"
-                )
-
-            # Read the generated PDF
-            pdf_path = tex_path.replace(".tex", ".pdf")
-            if not os.path.exists(pdf_path):
-                raise HTTPException(
-                    status_code=500,
-                    detail="PDF file was not generated"
-                )
-
-            with open(pdf_path, "rb") as f:
-                pdf_bytes = f.read()
+        # Create temporary directory
+        with tempfile.TemporaryDirectory() as tmpdir:
+            tex_path = os.path.join(tmpdir, "patient.tex")
+            pdf_path = os.path.join(tmpdir, "patient.pdf")
+
+            latex = f"""
+\\documentclass[a4paper,12pt]{{article}}
+\\usepackage[utf8]{{inputenc}}
+\\usepackage[T1]{{fontenc}}
+\\usepackage{{geometry}}
+\\geometry{{margin=1in}}
+\\usepackage{{booktabs,longtable,fancyhdr}}
+\\pagestyle{{fancy}}
+\\fancyhf{{}}
+\\fancyhead[L]{{Patient Report}}
+\\fancyhead[R]{{Generated: \\today}}
+\\fancyfoot[C]{{\\thepage}}
+
+\\begin{{document}}
+
+\\begin{{center}}
+    \\Large\\textbf{{Patient Medical Report}} \\\\
+    \\vspace{{0.2cm}}
+    \\textit{{Generated on {datetime.now().strftime('%A, %B %d, %Y at %I:%M %p')}}}
+\\end{{center}}
+
+\\section*{{Demographics}}
+\\begin{{itemize}}
+    \\item \\textbf{{FHIR ID:}} {patient.get("fhir_id", "")}
+    \\item \\textbf{{Full Name:}} {patient.get("full_name", "")}
+    \\item \\textbf{{Gender:}} {patient.get("gender", "")}
+    \\item \\textbf{{Date of Birth:}} {patient.get("date_of_birth", "")}
+    \\item \\textbf{{Age:}} {calculate_age(patient.get("date_of_birth", ""))}
+    \\item \\textbf{{Address:}} {patient.get("address", "")}, {patient.get("city", "")}, {patient.get("state", "")}, {patient.get("postal_code", "")}, {patient.get("country", "")}
+    \\item \\textbf{{Marital Status:}} {patient.get("marital_status", "")}
+    \\item \\textbf{{Language:}} {patient.get("language", "")}
+\\end{{itemize}}
+
+\\section*{{Clinical Notes}}
+\\begin{{longtable}}{{p{{3cm}}p{{3cm}}p{{7cm}}}}
+\\toprule
+\\textbf{{Date}} & \\textbf{{Type}} & \\textbf{{Text}} \\\\
+\\midrule
+\\endhead
+{" \\\\ \n".join([f"{n.get('date', '')} & {n.get('type', '')} & {n.get('text', '')}" for n in patient.get("notes", [])])}
+\\bottomrule
+\\end{{longtable}}
+
+\\end{{document}}
+            """
+
+            with open(tex_path, "w") as f:
+                f.write(latex)
 
-            # Clean up temporary files
             try:
-                subprocess.run(["latexmk", "-c", tex_path], check=True, capture_output=True)
-                os.remove(tex_path)
-                os.remove(pdf_path)
-            except Exception as cleanup_error:
-                raise HTTPException(
-                    status_code=500,
-                    detail=f"Failed to clean up temporary files: {str(cleanup_error)}"
-                )
+                subprocess.run(["latexmk", "-pdf", tex_path], check=True, cwd=tmpdir)
+                with open(pdf_path, "rb") as f:
+                    pdf_bytes = f.read()
 
-            return Response(
-                content=pdf_bytes,
-                media_type="application/pdf",
-                headers={"Content-Disposition": f"attachment; filename=patient_{patient.get('fhir_id', 'unknown')}_record.pdf"}
-            )
+                response = Response(content=pdf_bytes, media_type="application/pdf")
+                response.headers["Content-Disposition"] = f"attachment; filename=patient_{patient.get('fhir_id', 'unknown')}_record.pdf"
+                return response
 
-        except IOError as io_error:
-            raise HTTPException(
-                status_code=500,
-                detail=f"Failed to write LaTeX file: {str(io_error)}"
-            )
+            except subprocess.CalledProcessError as e:
+                logger.error(f"LaTeX compilation failed: {e.stderr}")
+                raise HTTPException(status_code=500, detail="LaTeX compilation failed")
 
-    except HTTPException as http_error:
-        raise http_error
     except Exception as e:
-        raise HTTPException(
-            status_code=500,
-            detail=f"Failed to generate PDF: {str(e)}"
-        )
-    finally:
-        # Restore the logger level for other routes
-        logger.setLevel(logging.INFO)
+        logger.error(f"PDF generation error: {e}")
+        raise HTTPException(status_code=500, detail="Failed to generate PDF")
 
 @router.post("/signup", status_code=status.HTTP_201_CREATED)
 async def signup(data: SignupForm):