Update api/routes.py

api/routes.py

@@ -96,18 +96,7 @@ async def create_indexes():
         logger.error(f"Failed to create indexes: {str(e)}")
         raise
 
-# Helper Functions
-def calculate_age(birth_date: str) -> Optional[int]:
-    if not birth_date:
-        return None
-    try:
-        birth_date = datetime.strptime(birth_date.split('T')[0], "%Y-%m-%d")
-        today = datetime.now()
-        return today.year - birth_date.year - (
-            (today.month, today.day) < (birth_date.month, birth_date.day))
-    except ValueError as e:
-        logger.warning(f"Invalid birth date format: {birth_date}, error: {str(e)}")
-        return None
+
 
 def standardize_language(language: str) -> str:
     """Convert language to MongoDB-compatible language code."""
@@ -568,6 +557,14 @@ async def add_note(
         )
 
 
+def calculate_age(birth_date: str):
+    try:
+        date = datetime.strptime(birth_date.split("T")[0], "%Y-%m-%d")
+        today = datetime.now()
+        return today.year - date.year - ((today.month, today.day) < (date.month, date.day))
+    except:
+        return "N/A"
+
 @router.get("/ehr/patients/{patient_id}/pdf", response_class=Response)
 async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get_current_user)):
     logger.info(f"Generating PDF for patient: {patient_id} by user {current_user.get('email')}")
@@ -586,7 +583,13 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
         if not patient:
             raise HTTPException(status_code=404, detail="Patient not found")
 
-        # Prepare LaTeX template
+        # Format note rows safely
+        note_rows = " \\\\\n".join(
+            f"{n.get('date','')} & {n.get('type','')} & {n.get('text','').replace('&', '\\&')}"
+            for n in patient.get("notes", [])
+        )
+
+        # Use Template for safe insertion
         latex_template = Template(r"""
 \documentclass[a4paper,12pt]{article}
 \usepackage[utf8]{inputenc}
@@ -605,7 +608,7 @@ async def generate_patient_pdf(patient_id: str, current_user: dict = Depends(get
 \begin{center}
     \Large\textbf{Patient Medical Report} \\
     \vspace{0.2cm}
-    \textit{Generated on $date}
+    \textit{Generated on $generated_on}
 \end{center}
 
 \section*{Demographics}
@@ -633,15 +636,8 @@ $notes
 \end{document}
 """)
 
-        # Format notes
-        notes_rows = " \\\\\n".join(
-            f"{n.get('date', '')} & {n.get('type', '')} & {n.get('text', '').replace('&', '\\&')}"
-            for n in patient.get("notes", [])
-        )
-
-        # Fill in template
-        latex = latex_template.substitute(
-            date=datetime.now().strftime('%A, %B %d, %Y at %I:%M %p'),
+        latex_filled = latex_template.substitute(
+            generated_on=datetime.now().strftime('%A, %B %d, %Y at %I:%M %p'),
             fhir_id=patient.get("fhir_id", ""),
             full_name=patient.get("full_name", ""),
             gender=patient.get("gender", ""),
@@ -656,35 +652,34 @@ $notes
             ])),
             marital_status=patient.get("marital_status", ""),
             language=patient.get("language", ""),
-            notes=notes_rows
+            notes=note_rows
         )
 
-        # Save and compile PDF
+        # Compile LaTeX in a temporary directory
         with tempfile.TemporaryDirectory() as tmpdir:
             tex_path = os.path.join(tmpdir, "report.tex")
             pdf_path = os.path.join(tmpdir, "report.pdf")
 
             with open(tex_path, "w", encoding="utf-8") as f:
-                f.write(latex)
-
-            try:
-                subprocess.run(["latexmk", "-pdf", "-interaction=nonstopmode", tex_path],
-                               check=True, cwd=tmpdir)
+                f.write(latex_filled)
 
-                with open(pdf_path, "rb") as f:
-                    pdf_bytes = f.read()
+            subprocess.run(["latexmk", "-pdf", "-interaction=nonstopmode", tex_path],
+                           cwd=tmpdir, check=True)
 
-                response = Response(content=pdf_bytes, media_type="application/pdf")
-                response.headers["Content-Disposition"] = f"attachment; filename=patient_{patient.get('fhir_id', 'unknown')}_report.pdf"
-                return response
+            with open(pdf_path, "rb") as f:
+                pdf_bytes = f.read()
 
-            except subprocess.CalledProcessError as e:
-                logger.error(f"LaTeX compilation failed: {e.stderr}")
-                raise HTTPException(status_code=500, detail="LaTeX compilation failed")
+            response = Response(content=pdf_bytes, media_type="application/pdf")
+            response.headers["Content-Disposition"] = f"attachment; filename=patient_{patient.get('fhir_id', 'unknown')}_report.pdf"
+            return response
 
+    except subprocess.CalledProcessError as e:
+        logger.error("LaTeX compilation error: %s", str(e))
+        raise HTTPException(status_code=500, detail="LaTeX compilation failed")
     except Exception as e:
         logger.exception("Unexpected error generating PDF")
-        raise HTTPException(status_code=500, detail="Failed to generate PDF")
+        raise HTTPException(status_code=500, detail="Unexpected error generating PDF")
+
 @router.post("/signup", status_code=status.HTTP_201_CREATED)
 async def signup(data: SignupForm):
     logger.info(f"Signup attempt for email: {data.email}")