Rulga commited on
Commit
0434884
·
1 Parent(s): 7531f8a

Refactor load_qa_pair_for_evaluation function parameters for clarity and update return tuple to include improved answer

Browse files
Files changed (2) hide show
  1. app.py +1 -1
  2. web/evaluation_interface.py +3 -3
app.py CHANGED
@@ -1087,7 +1087,7 @@ with gr.Blocks() as demo:
1087
 
1088
  # Load conversation for evaluation
1089
  load_btn.click(
1090
- fn=lambda x: load_qa_pair_for_evaluation(x, chat_evaluator),
1091
  inputs=[selected_conversation],
1092
  outputs=[question_display, original_answer, improved_answer,
1093
  accuracy, completeness, relevance, clarity, legal_correctness, notes]
 
1087
 
1088
  # Load conversation for evaluation
1089
  load_btn.click(
1090
+ fn=lambda x: load_qa_pair_for_evaluation(conversation_id=x, evaluator=chat_evaluator),
1091
  inputs=[selected_conversation],
1092
  outputs=[question_display, original_answer, improved_answer,
1093
  accuracy, completeness, relevance, clarity, legal_correctness, notes]
web/evaluation_interface.py CHANGED
@@ -82,16 +82,16 @@ def get_qa_pairs_dataframe(evaluator: ChatEvaluator, show_evaluated: bool = Fals
82
  # Return empty DataFrame if no pairs
83
  return pd.DataFrame(columns=["ID", "Question", "Answer", "Evaluated"])
84
 
85
- def load_qa_pair_for_evaluation(evaluator: ChatEvaluator, conversation_id: str) -> Tuple[str, str, Dict, str]:
86
  """
87
  Load a QA pair for evaluation
88
 
89
  Args:
90
- evaluator: ChatEvaluator instance
91
  conversation_id: ID of the conversation to load
 
92
 
93
  Returns:
94
- Tuple of (question, original_answer, existing_ratings, notes)
95
  """
96
  # Get all QA pairs
97
  qa_pairs = evaluator.get_qa_pairs_for_evaluation(limit=1000)
 
82
  # Return empty DataFrame if no pairs
83
  return pd.DataFrame(columns=["ID", "Question", "Answer", "Evaluated"])
84
 
85
+ def load_qa_pair_for_evaluation(conversation_id: str, evaluator: ChatEvaluator) -> Tuple[str, str, str, Dict, str]:
86
  """
87
  Load a QA pair for evaluation
88
 
89
  Args:
 
90
  conversation_id: ID of the conversation to load
91
+ evaluator: ChatEvaluator instance
92
 
93
  Returns:
94
+ Tuple of (question, original_answer, improved_answer, existing_ratings, notes)
95
  """
96
  # Get all QA pairs
97
  qa_pairs = evaluator.get_qa_pairs_for_evaluation(limit=1000)