Fix pdf upload/download storage paths + stop 500s

backend/api.py

@@ -1,50 +1,103 @@
 from __future__ import annotations
 
+import json
+import os
 from pathlib import Path
+from typing import Any, Dict, Optional
+
 from fastapi import FastAPI, UploadFile, File, Form, HTTPException
-from fastapi.responses import FileResponse
+from fastapi.responses import FileResponse, JSONResponse
 
-app = FastAPI()
+app = FastAPI(title="PDF Trainer API", version="1.0")
 
-PDF_DIR = Path("/data/uploads/pdfs")
+DATA_DIR = Path(os.environ.get("DATA_DIR", "/data/uploads")).resolve()
+PDF_DIR = DATA_DIR / "pdfs"
+CFG_DIR = DATA_DIR / "configs"
 PDF_DIR.mkdir(parents=True, exist_ok=True)
+CFG_DIR.mkdir(parents=True, exist_ok=True)
+
 
 @app.get("/health")
-async def health():
+async def health() -> Dict[str, Any]:
     return {"ok": True}
 
+
 @app.post("/api/pdf/{pdf_id}")
 async def put_pdf(
     pdf_id: str,
     file: UploadFile = File(...),
-    pdf_name: str = Form("")
-):
+    pdf_name: Optional[str] = Form(None),
+) -> Dict[str, Any]:
     pdf_path = PDF_DIR / f"{pdf_id}.pdf"
     name_path = PDF_DIR / f"{pdf_id}.name.txt"
 
     data = await file.read()
-    pdf_path.write_bytes(data)
-    name_path.write_text(pdf_name or file.filename or f"{pdf_id}.pdf", encoding="utf-8")
+    if not data:
+        raise HTTPException(status_code=400, detail="empty upload")
+
+    try:
+        pdf_path.write_bytes(data)
+        final_name = (pdf_name or file.filename or f"{pdf_id}.pdf").strip() or f"{pdf_id}.pdf"
+        name_path.write_text(final_name, encoding="utf-8")
+    except Exception as e:
+        raise HTTPException(status_code=500, detail=f"failed to store pdf: {e}")
+
+    return {"ok": True, "pdf_id": pdf_id, "bytes": len(data)}
 
-    return {"ok": True}
 
 @app.get("/api/pdf/{pdf_id}")
 async def get_pdf(pdf_id: str):
     pdf_path = PDF_DIR / f"{pdf_id}.pdf"
-    name_path = PDF_DIR / f"{pdf_id}.name.txt"
-
     if not pdf_path.exists():
         raise HTTPException(status_code=404, detail="pdf not found")
 
+    name_path = PDF_DIR / f"{pdf_id}.name.txt"
     filename = f"{pdf_id}.pdf"
-    if name_path.exists():
-        try:
-            filename = name_path.read_text(encoding="utf-8").strip() or filename
-        except Exception:
-            pass
+    try:
+        if name_path.exists():
+            filename = (name_path.read_text(encoding="utf-8").strip() or filename)
+    except Exception:
+        filename = f"{pdf_id}.pdf"
 
     return FileResponse(
         path=str(pdf_path),
         media_type="application/pdf",
         filename=filename,
+        headers={"x-pdf-name": filename},
     )
+
+
+@app.get("/api/config/{pdf_id}/{template_id}")
+async def get_config(pdf_id: str, template_id: str) -> Dict[str, Any]:
+    cfg_path = CFG_DIR / f"{pdf_id}__{template_id}.json"
+    if not cfg_path.exists():
+        raise HTTPException(status_code=404, detail="config not found")
+    try:
+        return json.loads(cfg_path.read_text(encoding="utf-8"))
+    except Exception as e:
+        raise HTTPException(status_code=500, detail=f"bad config json: {e}")
+
+
+@app.post("/api/send-config")
+async def send_config(payload: Dict[str, Any]) -> Dict[str, Any]:
+    pdf_id = (payload.get("pdf_id") or "").strip()
+    template_id = (payload.get("template_id") or "").strip()
+    config = payload.get("config")
+
+    if not pdf_id:
+        raise HTTPException(status_code=400, detail="Missing pdf_id")
+    if not template_id:
+        raise HTTPException(status_code=400, detail="Missing template_id")
+    if config is None:
+        raise HTTPException(status_code=400, detail="Missing config")
+
+    out = {"pdf_id": pdf_id, "template_id": template_id, "config": config}
+    cfg_path = CFG_DIR / f"{pdf_id}__{template_id}.json"
+
+    try:
+        cfg_path.write_text(json.dumps(out, indent=2, sort_keys=True), encoding="utf-8")
+    except Exception as e:
+        raise HTTPException(status_code=500, detail=f"failed to store config: {e}")
+
+    pdf_exists = (PDF_DIR / f"{pdf_id}.pdf").exists()
+    return {"ok": True, "stored": str(cfg_path), "pdf_exists": pdf_exists, "sftp": "not_implemented_here"}