Update app.py

app.py

@@ -12,40 +12,64 @@ from tools.final_answer import FinalAnswerTool
 from tools.web_search     import DuckDuckGoSearchTool
 
 # -----------------------------------------------------------------------------
-# 1) YOUR CUSTOM TOOLS
+# 1) YOUR CUSTOM TOOLS (with proper docstrings for Args)
 # -----------------------------------------------------------------------------
 @tool
 def get_weather(city: str) -> str:
-    """Fetches current weather info for a given city using wttr.in."""
+    """
+    Fetches current weather info for a given city using wttr.in.
+
+    Args:
+        city: Name of the city to get the weather for.
+    """
     try:
         resp = requests.get(f"https://wttr.in/{city}?format=3")
-        return (f"The current weather in {city} is: {resp.text}"
-                if resp.ok else f"Failed fetching weather for {city}.")
+        if resp.ok:
+            return f"The current weather in {city} is: {resp.text}"
+        return f"Failed fetching weather for {city}."
     except Exception as e:
         return f"Error: {e}"
 
 @tool
 def generate_pun(topic: str) -> str:
-    """Generates a spontaneous pun based on a given topic."""
+    """
+    Generates a spontaneous pun based on a given topic.
+
+    Args:
+        topic: The subject to base the pun on.
+    """
     puns = {
-        "banana": "I find bananas very *a-peeling*.",
-        "fish":   "You cod not be more fin-tastic!",
+        "banana":   "I find bananas very *a-peeling*.",
+        "fish":     "You cod not be more fin-tastic!",
         "computer": "My computer wanted to dance, so I gave it the disk-o.",
         "coffee":   "I’ve bean thinking about you!",
         "time":     "I wanted to be a watchmaker, but I just didn’t have the time.",
         "weather":  "I tried to catch some fog... but I mist.",
     }
-    return puns.get(topic.lower(),
-                    f"I don't have a pun for '{topic}' yet, but I’ll *try* not to make a joke of it!")
+    return puns.get(
+        topic.lower(),
+        f"I don't have a pun for '{topic}' yet, but I’ll *try* not to make a joke of it!"
+    )
 
 @tool
 def my_custom_tool(arg1: str, arg2: int) -> str:
-    """A placeholder tool you can flesh out later."""
+    """
+    A placeholder tool you can flesh out later.
+
+    Args:
+        arg1: The first argument.
+        arg2: The second argument.
+    """
     return "What magic will you build?"
 
 @tool
 def get_current_time_in_timezone(timezone: str) -> str:
-    """Fetches the current local time in a specified timezone."""
+    """
+    Fetches the current local time in a specified timezone.
+
+    Args:
+        timezone: A string representing a valid timezone (e.g., 'America/New_York').
+    """
     try:
         tz = pytz.timezone(timezone)
         now = datetime.now(tz).strftime("%Y-%m-%d %H:%M:%S")
@@ -54,7 +78,7 @@ def get_current_time_in_timezone(timezone: str) -> str:
         return f"Error fetching time for timezone '{timezone}': {e}"
 
 # -----------------------------------------------------------------------------
-# 2) LOAD PROMPTS & INSTANTIATE YOUR AGENT
+# 2) LOAD PROMPTS & INSTANTIATE YOUR AGENT (unchanged)
 # -----------------------------------------------------------------------------
 with open("prompts.yaml", "r") as f:
     prompt_templates = yaml.safe_load(f)
@@ -92,7 +116,7 @@ class BasicAgent:
         return self.agent.run(question)
 
 # -----------------------------------------------------------------------------
-# 3) EVALUATION LOGIC
+# 3) EVALUATION LOGIC (unchanged)
 # -----------------------------------------------------------------------------
 DEFAULT_API_URL = "https://agents-course-unit4-scoring.hf.space"
 
@@ -104,7 +128,6 @@ def run_and_submit_all(profile: Optional[gr.OAuthProfile]):
     questions_url = f"{DEFAULT_API_URL}/questions"
     submit_url    = f"{DEFAULT_API_URL}/submit"
 
-    # fetch questions
     try:
         r = requests.get(questions_url, timeout=15)
         r.raise_for_status()
@@ -115,12 +138,12 @@ def run_and_submit_all(profile: Optional[gr.OAuthProfile]):
     if not questions:
         return "No questions returned.", None
 
-    # run agent
-    agent = BasicAgent()
-    logs = []
+    agent   = BasicAgent()
+    logs    = []
     answers = []
     for item in questions:
-        tid = item.get("task_id"); q = item.get("question")
+        tid = item.get("task_id")
+        q   = item.get("question")
         if not tid or not q:
             continue
         ans = agent(q)
@@ -130,16 +153,15 @@ def run_and_submit_all(profile: Optional[gr.OAuthProfile]):
     if not answers:
         return "Agent produced no answers.", pd.DataFrame(logs)
 
-    # submit
     try:
         payload = {
-            "username":    profile.username,
-            "agent_code":  f"https://huggingface.co/spaces/{space_id}/tree/main",
-            "answers":     answers,
+            "username":   profile.username,
+            "agent_code": f"https://huggingface.co/spaces/{space_id}/tree/main",
+            "answers":    answers,
         }
         r2 = requests.post(submit_url, json=payload, timeout=60)
         r2.raise_for_status()
-        res = r2.json()
+        res    = r2.json()
         status = (
             f"✔ Submission Successful!\n"
             f"User: {res.get('username')}\n"
@@ -153,7 +175,7 @@ def run_and_submit_all(profile: Optional[gr.OAuthProfile]):
         return f"Submission Failed: {e}", pd.DataFrame(logs)
 
 # -----------------------------------------------------------------------------
-# 4) GRADIO EVALUATION UI
+# 4) GRADIO EVALUATION UI (unchanged)
 # -----------------------------------------------------------------------------
 with gr.Blocks() as demo:
     gr.Markdown("# Basic Agent Evaluation Runner")