Fucking finally ! split render working

server-plugins/split-render.js

@@ -1,7 +1,7 @@
 import _ from 'lodash'
 import fs from 'fs'
 import { Plugin } from './plugin.js';
-import { exec, spawn } from 'child_process'
+import { exec } from 'child_process'
 import _path from 'path';
 import { PerformanceRecorder } from 'common-utils';
 
@@ -26,13 +26,13 @@ export class SplitRenderPlugin extends Plugin {
         const getVideoDuration = `ffprobe -v quiet -show_entries format=duration -of csv=p=0 "${outFile}"`;
         exec(getVideoDuration, (error, stdout, stderr) => {
           if (error) {
-            console.error(`Error getting overlay duration: ${error.message}`);
+            console.error(`[SplitRenderPlugin] Error getting overlay duration: ${error.message}`);
             reject(error);
             return;
           }
 
           const overlayDuration = parseFloat(stdout.trim());
-          console.log(`Overlay duration: ${overlayDuration} seconds`);
+          console.log(`[SplitRenderPlugin] Overlay duration: ${overlayDuration} seconds`);
 
           let inputFiles = [];
           let sceneIndex = 0;
@@ -52,6 +52,12 @@ export class SplitRenderPlugin extends Plugin {
                 let publicFilePath = `public/${fileName}`;
                 inputFiles.push(`-ss 0 -t ${clipDuration} -i "${publicFilePath}"`);
               }
+              else if (type === 'image') {
+                let fileName = _path.basename(path);
+                let publicFilePath = `public/${fileName}`;
+                // loop
+                inputFiles.push(`-loop 1 -ss 0 -t ${Math.min(durationInSeconds, overlayDuration)} -i "${publicFilePath}"`);
+              }
             }
             sceneIndex++;
           });
@@ -59,7 +65,7 @@ export class SplitRenderPlugin extends Plugin {
           // Add the front overlay video (transparent webm) - this controls the final duration
           inputFiles.push(`-ss 0 -t ${overlayDuration} -i "${outFile}"`);
           const finalOutFile = `out/final_${jobId}.mp4`
-
+          let ffmpegProcess
           if (inputFiles.length > 1) {
             // Build the ffmpeg command
             const inputPart = inputFiles.join(' ');
@@ -67,60 +73,32 @@ export class SplitRenderPlugin extends Plugin {
             const backVideoIndex = 0; // First input is the back video
 
             // Create filter complex for overlay with transparency
-            const filterComplex = `"[${frontVideoIndex}:v]colorkey=0x000000:0.08:0.02[fg];[${backVideoIndex}:v][fg]overlay=0:0:format=auto"`;
+            const filterComplex = `[${frontVideoIndex}:v]colorkey=0x000000:0.08:0.02[fg];[${backVideoIndex}:v][fg]overlay=0:0:format=auto`;
 
-            // Remove -shortest so the output duration matches the overlay video (outFile)
-            ffmpegCommand = `ffmpeg ${inputPart} -filter_complex ${filterComplex} -c:v libx264 -pix_fmt yuv420p ${finalOutFile}`;
-          }
-          else {
-            resolve('No input files to process. Skipping split-render post process');
-            return
-          }
-
-          //run ffmpeg command 
-          if (ffmpegCommand) {
-            console.log('Running ffmpeg command:', ffmpegCommand);
-
-            const ffmpegProcess = spawn('ffmpeg', ffmpegCommand.split(' ').slice(1), { stdio: 'pipe' });
+            // Build single ffmpeg command string
+            const ffmpegCommand = `ffmpeg ${inputPart} -filter_complex "${filterComplex}" -c:v libx264 -pix_fmt yuv420p -y ${finalOutFile}`;
+            console.log('[SplitRenderPlugin] Running ffmpeg command:', ffmpegCommand);
 
-            let stdoutData = '';
-            let stderrData = '';
-
-            // Stream stdout in real-time
-            ffmpegProcess.stdout.on('data', (data) => {
-              const output = data.toString();
-              console.log('[FFmpeg stdout]:', output);
-              stdoutData += output;
-            });
-
-            // Stream stderr in real-time (FFmpeg outputs progress info to stderr)
-            ffmpegProcess.stderr.on('data', (data) => {
-              const output = data.toString();
-              console.log('[FFmpeg stderr]:', output);
-              stderrData += output;
-            });
-
-            ffmpegProcess.on('close', (code) => {
-              if (code === 0) {
-                fs.renameSync(outFile, 'raw_' + outFile)
-                fs.renameSync(finalOutFile, outFile)
-                console.log('FFmpeg process completed successfully, took ', perf.elapsedString());
-                resolve(stdoutData || 'FFmpeg completed successfully');
-              } else {
-                const fullErrorLog = `FFmpeg process exited with code ${code}\n\nSTDOUT:\n${stdoutData}\n\nSTDERR:\n${stderrData}`;
-                console.error('FFmpeg failed:', fullErrorLog);
+            exec(ffmpegCommand, (error, stdout, stderr) => {
+              if (error) {
+                const fullErrorLog = `FFmpeg process failed: ${error.message}\n\nSTDOUT:\n${stdout}\n\nSTDERR:\n${stderr}`;
+                console.error('[SplitRenderPlugin] FFmpeg failed:', fullErrorLog);
                 reject(new Error(fullErrorLog));
+                return;
               }
-            });
-
-            ffmpegProcess.on('error', (error) => {
-              const fullErrorLog = `FFmpeg spawn error: ${error.message}\n\nSTDOUT:\n${stdoutData}\n\nSTDERR:\n${stderrData}`;
-              console.error('FFmpeg spawn error:', fullErrorLog);
-              reject(new Error(fullErrorLog));
+              console.log('[SplitRenderPlugin] FFmpeg process completed successfully, took ', perf.elapsedString());
+              console.log('[SplitRenderPlugin] [FFmpeg stdout]:', stdout);
+              if (stderr) {
+                console.log('[SplitRenderPlugin] [FFmpeg stderr]:', stderr);
+              }
+              resolve(stdout || 'FFmpeg completed successfully');
             });
           } else {
-            resolve('No ffmpeg command generated');
+            resolve('No input files to process. Skipping split-render post process');
+            return;
           }
+
+
         });
       } else {
         resolve('No output file found');