update

backend/app/main.py

@@ -2798,6 +2798,22 @@ async def patch_deal(deal_id: int, body: CrmDealPatchRequest, t: TenantContext =
     return _enrich_deal_response(db, row)
 
 
+@app.delete("/api/deals/{deal_id}")
+async def delete_deal(deal_id: int, t: TenantContext = Depends(get_tenant_context)):
+    db = t.db
+    row = (
+        db.query(CrmDeal)
+        .filter(CrmDeal.tenant_id == t.tenant_id, CrmDeal.id == deal_id)
+        .first()
+    )
+    if not row:
+        raise HTTPException(status_code=404, detail="Deal not found")
+    _deal_access_or_403(row, t)
+    db.delete(row)
+    db.commit()
+    return {"ok": True, "id": deal_id}
+
+
 @app.post("/api/deals/seed-demo")
 async def seed_demo_deals(t: TenantContext = Depends(get_tenant_context)):
     db = t.db

frontend/src/pages/Deals.jsx

@@ -1,6 +1,6 @@
-import React, { useCallback, useEffect, useMemo, useState } from 'react';
+import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
 import { Link } from 'react-router-dom';
-import { GitBranch, Loader2, LayoutGrid, MessageSquare } from 'lucide-react';
+import { GitBranch, Loader2, LayoutGrid, MessageSquare, Trash2, UserPlus } from 'lucide-react';
 import { Button } from '@/components/ui/button';
 import { Select, SelectTrigger, SelectContent, SelectItem } from '@/components/ui/select';
 import AppShell from '@/components/layout/AppShell';
@@ -28,6 +28,8 @@ const STAGES = [
 const EMPTY_COUNTRY_KEY = '__country_none__';
 const EMPTY_OWNER_KEY = '__owner_none__';
 const MEMBER_TAKE_OWNERSHIP_VALUE = '__member_take_ownership__';
+/** Bulk toolbar: no owner/stage chosen yet */
+const BULK_NONE = '__bulk_none__';
 
 /** Accent bars for By Country / By Owner groups (rotate). */
 const GROUP_BAR_ROTATING = [
@@ -150,6 +152,8 @@ function GroupedDealTbody({
     isAdmin,
     currentUserId,
     tenantMembers,
+    selectedDealIds,
+    onToggleDealSelected,
 }) {
     const sumDeal = sumNumeric(deals, 'deal_value');
     const sumForecast = sumNumeric(deals, 'forecast_value');
@@ -170,6 +174,8 @@ function GroupedDealTbody({
                     isAdmin={isAdmin}
                     currentUserId={currentUserId}
                     tenantMembers={tenantMembers}
+                    selected={selectedDealIds.includes(deal.id)}
+                    onToggleSelected={onToggleDealSelected}
                 />
             ))}
             <tr className="bg-slate-50/90 text-slate-700 border-b border-slate-100">
@@ -360,7 +366,17 @@ function PipelineBoard({ columns, openDeal, patchDeal, createDeal, createBusy })
     );
 }
 
-function DealRow({ deal, patchDeal, updateStage, openDeal, isAdmin, currentUserId, tenantMembers }) {
+function DealRow({
+    deal,
+    patchDeal,
+    updateStage,
+    openDeal,
+    isAdmin,
+    currentUserId,
+    tenantMembers,
+    selected,
+    onToggleSelected,
+}) {
     const meta = stageMeta(deal.stage);
     const safeStage = STAGES.some((s) => s.value === deal.stage) ? deal.stage : 'new';
     const closeSel = closeProbabilitySelectValue(deal.close_probability);
@@ -383,7 +399,16 @@ function DealRow({ deal, patchDeal, updateStage, openDeal, isAdmin, currentUserI
             className="border-b border-slate-100 hover:bg-violet-50/40 cursor-pointer"
         >
             <td className="px-2 py-2 w-10 text-center align-middle" onClick={(e) => e.stopPropagation()}>
-                <input type="checkbox" className="rounded border-slate-300" aria-label="Select row" />
+                <input
+                    type="checkbox"
+                    className="rounded border-slate-300"
+                    checked={selected}
+                    onChange={(e) => {
+                        e.stopPropagation();
+                        onToggleSelected(deal.id);
+                    }}
+                    aria-label={`Select ${deal.name || 'deal'}`}
+                />
             </td>
             <td
                 className="px-3 py-2 align-top min-w-[16rem] max-w-[min(28rem,40vw)] font-medium"
@@ -672,6 +697,11 @@ export default function Deals() {
     const [companyFetchError, setCompanyFetchError] = useState('');
     const [me, setMe] = useState(null);
     const [tenantMembers, setTenantMembers] = useState([]);
+    const [selectedDealIds, setSelectedDealIds] = useState([]);
+    const [bulkOwnerValue, setBulkOwnerValue] = useState(BULK_NONE);
+    const [bulkStageValue, setBulkStageValue] = useState(BULK_NONE);
+    const [bulkBusy, setBulkBusy] = useState(false);
+    const selectAllCheckboxRef = useRef(null);
 
     const isAdmin = me?.current_role === 'admin';
     const currentUserId = me?.user_id ?? null;
@@ -721,6 +751,43 @@ export default function Deals() {
         return () => clearTimeout(t);
     }, [fetchDeals]);
 
+    useEffect(() => {
+        setSelectedDealIds((ids) => ids.filter((id) => deals.some((d) => d.id === id)));
+    }, [deals]);
+
+    useEffect(() => {
+        setSelectedDealIds([]);
+        setBulkOwnerValue(BULK_NONE);
+        setBulkStageValue(BULK_NONE);
+    }, [dealsView]);
+
+    useEffect(() => {
+        const el = selectAllCheckboxRef.current;
+        if (!el) return;
+        if (deals.length === 0) {
+            el.indeterminate = false;
+            return;
+        }
+        el.indeterminate = selectedDealIds.length > 0 && selectedDealIds.length < deals.length;
+    }, [deals, selectedDealIds]);
+
+    const onToggleDealSelected = useCallback((id) => {
+        setSelectedDealIds((prev) => (prev.includes(id) ? prev.filter((x) => x !== id) : [...prev, id]));
+    }, []);
+
+    const toggleSelectAll = useCallback(() => {
+        setSelectedDealIds((prev) => {
+            if (deals.length === 0) return [];
+            const allOn = deals.every((d) => prev.includes(d.id));
+            if (allOn) return [];
+            return deals.map((d) => d.id);
+        });
+    }, [deals]);
+
+    const clearDealSelection = useCallback(() => {
+        setSelectedDealIds([]);
+    }, []);
+
     const dealsByStage = useMemo(() => {
         return STAGES.map((s) => ({
             ...s,
@@ -936,9 +1003,153 @@ export default function Deals() {
         setDealDetail(null);
     };
 
+    const bulkDeleteDeals = async () => {
+        if (selectedDealIds.length === 0) return;
+        if (!window.confirm(`Delete ${selectedDealIds.length} deal(s)? This cannot be undone.`)) return;
+        setBulkBusy(true);
+        const ids = [...selectedDealIds];
+        try {
+            const results = await Promise.allSettled(
+                ids.map((id) =>
+                    apiFetch(`/api/deals/${id}`, { method: 'DELETE' }).then(async (res) => {
+                        if (!res.ok) {
+                            const data = await res.json().catch(() => ({}));
+                            throw new Error(
+                                typeof data.detail === 'string' ? data.detail : 'Delete failed'
+                            );
+                        }
+                    })
+                )
+            );
+            const failed = results.filter((r) => r.status === 'rejected').length;
+            if (failed) {
+                alert(`${failed} delete(s) failed. The list will refresh.`);
+            }
+            if (dealDetail && ids.includes(dealDetail.id)) closePanel();
+            setSelectedDealIds([]);
+            await fetchDeals();
+        } finally {
+            setBulkBusy(false);
+        }
+    };
+
+    const bulkApplyOwner = async () => {
+        if (!isAdmin || bulkOwnerValue === BULK_NONE || selectedDealIds.length === 0) return;
+        const patch =
+            bulkOwnerValue === EMPTY_OWNER_KEY
+                ? { owner_user_id: null }
+                : { owner_user_id: Number(bulkOwnerValue) };
+        setBulkBusy(true);
+        try {
+            await Promise.all(
+                selectedDealIds.map((id) =>
+                    apiFetch(`/api/deals/${id}`, {
+                        method: 'PATCH',
+                        headers: { 'Content-Type': 'application/json' },
+                        body: JSON.stringify(patch),
+                    }).then(async (res) => {
+                        const data = await res.json().catch(() => ({}));
+                        if (!res.ok) {
+                            throw new Error(
+                                typeof data.detail === 'string' ? data.detail : 'Update failed'
+                            );
+                        }
+                        return data;
+                    })
+                )
+            );
+            setBulkOwnerValue(BULK_NONE);
+            await fetchDeals();
+        } catch (e) {
+            console.error(e);
+            alert(e.message || 'Could not assign owner');
+            await fetchDeals();
+        } finally {
+            setBulkBusy(false);
+        }
+    };
+
+    const bulkTakeOwnership = async () => {
+        if (currentUserId == null || selectedDealIds.length === 0) return;
+        setBulkBusy(true);
+        try {
+            await Promise.all(
+                selectedDealIds.map((id) =>
+                    apiFetch(`/api/deals/${id}`, {
+                        method: 'PATCH',
+                        headers: { 'Content-Type': 'application/json' },
+                        body: JSON.stringify({ owner_user_id: currentUserId }),
+                    }).then(async (res) => {
+                        const data = await res.json().catch(() => ({}));
+                        if (!res.ok) {
+                            throw new Error(
+                                typeof data.detail === 'string' ? data.detail : 'Update failed'
+                            );
+                        }
+                        return data;
+                    })
+                )
+            );
+            await fetchDeals();
+        } catch (e) {
+            console.error(e);
+            alert(
+                e.message ||
+                    'Could not take ownership of all selected deals. You can only claim unassigned deals you are allowed to edit.'
+            );
+            await fetchDeals();
+        } finally {
+            setBulkBusy(false);
+        }
+    };
+
+    const bulkApplyStage = async () => {
+        if (bulkStageValue === BULK_NONE || selectedDealIds.length === 0) return;
+        setBulkBusy(true);
+        try {
+            await Promise.all(
+                selectedDealIds.map((id) =>
+                    apiFetch(`/api/deals/${id}`, {
+                        method: 'PATCH',
+                        headers: { 'Content-Type': 'application/json' },
+                        body: JSON.stringify({ stage: bulkStageValue }),
+                    }).then(async (res) => {
+                        const data = await res.json().catch(() => ({}));
+                        if (!res.ok) {
+                            throw new Error(
+                                typeof data.detail === 'string' ? data.detail : 'Update failed'
+                            );
+                        }
+                        return data;
+                    })
+                )
+            );
+            setBulkStageValue(BULK_NONE);
+            await fetchDeals();
+        } catch (e) {
+            console.error(e);
+            alert(e.message || 'Could not change stage');
+            await fetchDeals();
+        } finally {
+            setBulkBusy(false);
+        }
+    };
+
     const dealPanelCloseSel =
         dealDetail != null ? closeProbabilitySelectValue(dealDetail.close_probability) : '__clear__';
 
+    const bulkOwnerTriggerLabel = useMemo(() => {
+        if (bulkOwnerValue === BULK_NONE) return 'Assign owner';
+        if (bulkOwnerValue === EMPTY_OWNER_KEY) return 'Unassigned';
+        const m = (tenantMembers || []).find((x) => String(x.user_id) === bulkOwnerValue);
+        return m ? (m.name || m.email || `User ${m.user_id}`).trim() : 'Assign owner';
+    }, [bulkOwnerValue, tenantMembers]);
+
+    const bulkStageTriggerLabel = useMemo(() => {
+        if (bulkStageValue === BULK_NONE) return 'Change stage';
+        return stageMeta(bulkStageValue).label;
+    }, [bulkStageValue]);
+
     return (
         <AppShell
             title="Deals"
@@ -997,6 +1208,137 @@ export default function Deals() {
                 sectionCount={total}
                 sectionOpen={sectionOpen}
                 onSectionToggle={() => setSectionOpen(!sectionOpen)}
+                tableToolbar={
+                    !loading && dealsView !== 'pipeline' && deals.length > 0 ? (
+                        <div
+                            className="flex flex-wrap items-center gap-2 border-b border-slate-100 bg-slate-50/90 px-4 py-2.5"
+                            aria-busy={bulkBusy}
+                        >
+                            <span className="text-xs font-medium text-slate-600">
+                                {selectedDealIds.length > 0
+                                    ? `${selectedDealIds.length} selected`
+                                    : 'Select rows below'}
+                            </span>
+                            <Button
+                                type="button"
+                                variant="outline"
+                                size="icon"
+                                className="h-8 w-8 shrink-0 text-slate-700"
+                                disabled={selectedDealIds.length === 0 || bulkBusy}
+                                title="Delete selected deals"
+                                onClick={bulkDeleteDeals}
+                            >
+                                <Trash2 className="h-4 w-4" aria-hidden />
+                                <span className="sr-only">Delete selected</span>
+                            </Button>
+                            {isAdmin ? (
+                                <div className="flex flex-wrap items-center gap-1.5 border-l border-slate-200 pl-2">
+                                    <UserPlus className="h-4 w-4 shrink-0 text-slate-500" aria-hidden />
+                                    <Select value={bulkOwnerValue} onValueChange={setBulkOwnerValue}>
+                                        <SelectTrigger
+                                            className="h-8 w-[min(100%,11rem)] max-w-[13rem] border-slate-200 bg-white text-xs shadow-sm"
+                                            title="Assign owner"
+                                        >
+                                            <span className="truncate text-left">{bulkOwnerTriggerLabel}</span>
+                                        </SelectTrigger>
+                                        <SelectContent className="min-w-[10rem]">
+                                            <SelectItem value={BULK_NONE}>
+                                                <span className="text-slate-500">Choose owner…</span>
+                                            </SelectItem>
+                                            <SelectItem value={EMPTY_OWNER_KEY}>Unassigned</SelectItem>
+                                            {(tenantMembers || []).map((m) => (
+                                                <SelectItem key={m.user_id} value={String(m.user_id)}>
+                                                    {(m.name || m.email || `User ${m.user_id}`).trim()}
+                                                </SelectItem>
+                                            ))}
+                                        </SelectContent>
+                                    </Select>
+                                    <Button
+                                        type="button"
+                                        size="sm"
+                                        variant="secondary"
+                                        className="h-8"
+                                        disabled={
+                                            selectedDealIds.length === 0 ||
+                                            bulkOwnerValue === BULK_NONE ||
+                                            bulkBusy
+                                        }
+                                        onClick={bulkApplyOwner}
+                                    >
+                                        Apply
+                                    </Button>
+                                </div>
+                            ) : (
+                                <div className="flex items-center gap-1 border-l border-slate-200 pl-2">
+                                    <Button
+                                        type="button"
+                                        variant="outline"
+                                        size="sm"
+                                        className="h-8 gap-1.5 px-2"
+                                        disabled={selectedDealIds.length === 0 || bulkBusy}
+                                        title="Assign yourself as owner on selected deals"
+                                        onClick={bulkTakeOwnership}
+                                    >
+                                        <UserPlus className="h-4 w-4 shrink-0" aria-hidden />
+                                        <span className="hidden sm:inline">Take ownership</span>
+                                    </Button>
+                                </div>
+                            )}
+                            <div className="flex flex-wrap items-center gap-1.5 border-l border-slate-200 pl-2">
+                                <GitBranch className="h-4 w-4 shrink-0 text-slate-500" aria-hidden />
+                                <Select value={bulkStageValue} onValueChange={setBulkStageValue}>
+                                    <SelectTrigger
+                                        className="h-8 w-[min(100%,9.5rem)] max-w-[11rem] border-slate-200 bg-white text-xs shadow-sm"
+                                        title="Change stage"
+                                    >
+                                        <span className="truncate text-left">{bulkStageTriggerLabel}</span>
+                                    </SelectTrigger>
+                                    <SelectContent className="min-w-[10rem]">
+                                        <SelectItem value={BULK_NONE}>
+                                            <span className="text-slate-500">Choose stage…</span>
+                                        </SelectItem>
+                                        {STAGES.map((s) => (
+                                            <SelectItem key={s.value} value={s.value}>
+                                                <span
+                                                    className={cn(
+                                                        'rounded-full px-2 py-0.5 text-xs font-medium inline-block',
+                                                        s.className
+                                                    )}
+                                                >
+                                                    {s.label}
+                                                </span>
+                                            </SelectItem>
+                                        ))}
+                                    </SelectContent>
+                                </Select>
+                                <Button
+                                    type="button"
+                                    size="sm"
+                                    variant="secondary"
+                                    className="h-8"
+                                    disabled={
+                                        selectedDealIds.length === 0 ||
+                                        bulkStageValue === BULK_NONE ||
+                                        bulkBusy
+                                    }
+                                    onClick={bulkApplyStage}
+                                >
+                                    Apply
+                                </Button>
+                            </div>
+                            <Button
+                                type="button"
+                                variant="ghost"
+                                size="sm"
+                                className="ml-auto h-8 text-slate-600"
+                                disabled={selectedDealIds.length === 0 || bulkBusy}
+                                onClick={clearDealSelection}
+                            >
+                                Clear selection
+                            </Button>
+                        </div>
+                    ) : null
+                }
             >
                 <div className="w-full min-w-0 overflow-x-auto">
                     {loading ? (
@@ -1036,7 +1378,21 @@ export default function Deals() {
                         <table className="w-full text-sm min-w-[1120px]">
                             <thead>
                                 <tr className="bg-slate-50 text-left text-slate-600 border-b border-slate-200">
-                                    <th className="px-2 py-2 w-10" aria-label="Select row" />
+                                    <th className="px-2 py-2 w-10 text-center">
+                                        <input
+                                            ref={selectAllCheckboxRef}
+                                            type="checkbox"
+                                            className="rounded border-slate-300"
+                                            checked={
+                                                deals.length > 0 &&
+                                                selectedDealIds.length === deals.length &&
+                                                deals.every((d) => selectedDealIds.includes(d.id))
+                                            }
+                                            onChange={toggleSelectAll}
+                                            aria-label="Select all deals"
+                                            title="Select all"
+                                        />
+                                    </th>
                                     <th className="px-3 py-2 font-medium min-w-[16rem] max-w-[min(28rem,40vw)]">
                                         Deal
                                     </th>
@@ -1067,6 +1423,8 @@ export default function Deals() {
                                             isAdmin={isAdmin}
                                             currentUserId={currentUserId}
                                             tenantMembers={tenantMembers}
+                                            selected={selectedDealIds.includes(deal.id)}
+                                            onToggleSelected={onToggleDealSelected}
                                         />
                                     ))}
                                 </tbody>
@@ -1103,6 +1461,8 @@ export default function Deals() {
                                         isAdmin={isAdmin}
                                         currentUserId={currentUserId}
                                         tenantMembers={tenantMembers}
+                                        selectedDealIds={selectedDealIds}
+                                        onToggleDealSelected={onToggleDealSelected}
                                     />
                                 ))
                             ) : dealsView === 'byCountry' ? (
@@ -1127,6 +1487,8 @@ export default function Deals() {
                                         isAdmin={isAdmin}
                                         currentUserId={currentUserId}
                                         tenantMembers={tenantMembers}
+                                        selectedDealIds={selectedDealIds}
+                                        onToggleDealSelected={onToggleDealSelected}
                                     />
                                 ))
                             ) : dealsView === 'byOwner' ? (
@@ -1161,6 +1523,8 @@ export default function Deals() {
                                         isAdmin={isAdmin}
                                         currentUserId={currentUserId}
                                         tenantMembers={tenantMembers}
+                                        selectedDealIds={selectedDealIds}
+                                        onToggleDealSelected={onToggleDealSelected}
                                     />
                                 ))
                             ) : null}